All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <wangmy@fujitsu.com>, <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v3] python3-packaging: upgrade 25.0 -> 26.0
Date: Thu, 05 Feb 2026 13:10:54 +0100	[thread overview]
Message-ID: <DG70NLZ9YPDQ.1CPDRKUREZP7J@bootlin.com> (raw)
In-Reply-To: <20260203091329.1294-1-wangmy@fujitsu.com>

On Tue Feb 3, 2026 at 10:13 AM CET, wangmy via lists.openembedded.org wrote:
> From: Wang Mingyu <wangmy@fujitsu.com>
>
> Modify run-ptest.in to skip test_pylock.py.
>

Hi Wang,

Thanks for the new version.

This was reviewed during the today patch review session, and two
comments were made:
- First, the commit message should explain why this test is being
  disabled. I know this is linked with the tomli dependency, but please
  say so into the commit message.
- The second point is about the disabling itself. Did you had a look at
  possibilities to modify the test so it can still run in oe setup?

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2026-02-05 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  9:13 [OE-core] [PATCH v3] python3-packaging: upgrade 25.0 -> 26.0 Wang Mingyu
2026-02-05 12:10 ` Mathieu Dubois-Briand [this message]
2026-02-10 13:15 ` Ross Burton
2026-02-10 14:49   ` Ross Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DG70NLZ9YPDQ.1CPDRKUREZP7J@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=wangmy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.