From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Haroen Tmimi" <tmimiharoen@gmail.com>, <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: rtl8723bs: constify _action_public_str in rtw_ieee80211.c
Date: Thu, 05 Feb 2026 09:53:17 -0600 [thread overview]
Message-ID: <DG75DVGDRTBP.3UNKFULPJYWP4@gmail.com> (raw)
In-Reply-To: <20260205120909.161336-1-tmimiharoen@gmail.com>
On Thu Feb 5, 2026 at 6:09 AM CST, Haroen Tmimi wrote:
> Make the _action_public_str array "static const char * const".
>
> This ensures the array entries are read-only, preventing accidental
> modification of the pointers.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@gmail.com>
Looks good to me.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
ET
next prev parent reply other threads:[~2026-02-05 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 12:09 [PATCH v2] staging: rtl8723bs: constify _action_public_str in rtw_ieee80211.c Haroen Tmimi
2026-02-05 15:53 ` Ethan Tidmore [this message]
2026-02-07 13:40 ` Greg KH
2026-02-07 14:06 ` Haroen Tmimi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG75DVGDRTBP.3UNKFULPJYWP4@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=tmimiharoen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.