All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonin Godard" <antonin.godard@bootlin.com>
To: "Quentin Schulz" <quentin.schulz@cherry.de>, <foss@0leil.net>,
	<docs@lists.yoctoproject.org>
Subject: Re: [docs] [PATCH v3] convert SVGs to PDF and PNG using sphinxcontrib.rsvgconverter plugin
Date: Thu, 12 Feb 2026 10:49:21 +0100	[thread overview]
Message-ID: <DGCW11KABQIL.QJTTJ8CE3QZO@bootlin.com> (raw)
In-Reply-To: <5288e4be-8e16-4447-b1fd-94d21aa91c4f@cherry.de>

On Thu Feb 12, 2026 at 10:39 AM CET, Quentin Schulz wrote:
> Hi Antonin,
>
> On 2/12/26 9:50 AM, Antonin Godard wrote:
>> Hi,
>> 
>> On Wed Feb 11, 2026 at 4:25 PM CET, Quentin Schulz via lists.yoctoproject.org wrote:
>> [...]
>>> diff --git a/documentation/tools/host_packages_scripts/pip3_docs.sh b/documentation/tools/host_packages_scripts/pip3_docs.sh
>>> index 907ecec55..3e4045e7e 100644
>>> --- a/documentation/tools/host_packages_scripts/pip3_docs.sh
>>> +++ b/documentation/tools/host_packages_scripts/pip3_docs.sh
>>> @@ -1 +1 @@
>>> -sudo pip3 install sphinx sphinx_rtd_theme pyyaml sphinx-copybutton
>>> +sudo pip3 install sphinx sphinx_rtd_theme pyyaml sphinx-copybutton 'sphinxcontrib-svg2pdfconverter>=2.0.0'
>> 
>> pip3_docs.sh is not used for ubuntu and debian, meaning we need to find the
>
> Woopsies.
>
>> equivalent package to add to
>> documentation/tools/host_packages_scripts/ubuntu_docs.sh, or write a custom
>
> There's none as far as I could tell and even if there was one, unlikely 
> to be 2.0.0 for all Debian/Ubuntu versions as they are generally pretty 
> conservative with upgrades and this was a recent one.
>
>> pip3_docs.sh file for ubuntu/debian.
>> 
>> Or drop the ubuntu_docs.sh file and use pip3_docs.sh for ubuntu/debian, which
>> would make this kind of mistakes unlikely to happen. What do you think?
>> 
>
> I don't mind either way. Makes it easier to maintain if all use the same 
> packages from pip is my opinion.
>
> What would you prefer?

I prefer having pip3_docs.sh shared between all. Do you mind deleting
ubuntu_docs.sh and replacing it with pip3_docs.sh in a separate patch?

Thanks!
Antonin


  reply	other threads:[~2026-02-12  9:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 15:25 [PATCH v3] convert SVGs to PDF and PNG using sphinxcontrib.rsvgconverter plugin Quentin Schulz
2026-02-12  8:50 ` [docs] " Antonin Godard
2026-02-12  9:39   ` Quentin Schulz
2026-02-12  9:49     ` Antonin Godard [this message]
2026-02-12 10:57       ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGCW11KABQIL.QJTTJ8CE3QZO@bootlin.com \
    --to=antonin.godard@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=foss@0leil.net \
    --cc=quentin.schulz@cherry.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.