From: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: <xen-devel@lists.xenproject.org>, Jan Beulich <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
Anthony PERARD <anthony.perard@vates.tech>,
Michal Orzel <michal.orzel@amd.com>,
"Julien Grall" <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 2/2] x86: Force HAP to be enabled when PV and shadow paging are compiled out
Date: Fri, 13 Feb 2026 20:13:09 +0100 [thread overview]
Message-ID: <DGE2N97NJMIR.LU2XTI1URT8S@amd.com> (raw)
In-Reply-To: <aY9wqBi9xKQv9tiQ@Mac.lan>
On Fri Feb 13, 2026 at 7:42 PM CET, Roger Pau Monné wrote:
>> >> diff --git a/xen/arch/x86/mm/Makefile b/xen/arch/x86/mm/Makefile
>> >> index 960f6e8409..64fde82c50 100644
>> >> --- a/xen/arch/x86/mm/Makefile
>> >> +++ b/xen/arch/x86/mm/Makefile
>> >> @@ -1,4 +1,4 @@
>> >> -obj-y += shadow/
>> >> +obj-$(CONFIG_OPT_HAP) += shadow/
>> >
>> > I think you can use:
>> >
>> > obj-$(findstring y,$(CONFIG_PV) $(CONFIG_SHADOW_PAGING)) += ...
>>
>> Hmmm. I guess I shouldn't just include it twice, like we do for other .o files.
>
> I see, so use:
>
> obj-$(CONFIG_PV) += shadow/
> obj-$(CONFIG_SHADOW_PAGING) += shadow/
>
> Maybe that's simpler really, and it's a pattern we already use
> elsewhere.
I meant them being folder with makefiles potentially doing things that should
only be done once. I don't know if we dedup tokens somewhere. These makefiles
are rather arcane.
>
> Thanks, Roger.
next prev parent reply other threads:[~2026-02-13 19:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 13:37 [PATCH 0/2] x86: Const-ify hvm_enabled and hap_enabled() when possible Alejandro Vallejo
2026-02-13 13:37 ` [PATCH 1/2] x86: Make hvm_enabled a constant unless both PV and HVM are both compiled Alejandro Vallejo
2026-02-13 14:26 ` Roger Pau Monné
2026-02-13 16:01 ` Andrew Cooper
2026-02-13 16:33 ` Roger Pau Monné
2026-02-13 17:04 ` Alejandro Vallejo
2026-02-13 18:30 ` Roger Pau Monné
2026-02-13 13:37 ` [PATCH 2/2] x86: Force HAP to be enabled when PV and shadow paging are compiled out Alejandro Vallejo
2026-02-13 15:09 ` Roger Pau Monné
2026-02-13 17:30 ` Alejandro Vallejo
2026-02-13 18:42 ` Roger Pau Monné
2026-02-13 19:13 ` Alejandro Vallejo [this message]
2026-02-13 19:54 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGE2N97NJMIR.LU2XTI1URT8S@amd.com \
--to=alejandro.garciavallejo@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.