From: "Antonin Godard" <antonin.godard@bootlin.com>
To: <bitbake-devel@lists.openembedded.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Antonin Godard" <antonin.godard@bootlin.com>
Subject: Re: [PATCH v2 3/4] bitbake-setup: print colored diffs
Date: Wed, 18 Feb 2026 16:27:15 +0100 [thread overview]
Message-ID: <DGI6Z0US5NPC.6Y8DAVVEYWRG@bootlin.com> (raw)
In-Reply-To: <20260218-improve-bbsetup-readability-v2-3-351584e5df9c@bootlin.com>
Hi,
On Wed Feb 18, 2026 at 2:15 PM CET, Antonin Godard wrote:
[...]
> @@ -728,7 +761,9 @@ def init_config(top_dir, settings, args):
>
> def get_diff(file1, file2):
> try:
> - bb.process.run('diff -uNr {} {}'.format(file1, file2))
> + bb.process.run('diff --color={} -uNr {} {}'.format("always" if BBSETUP_COLOR else "never",
> + file1,
> + file2))
Oops, this slipped through, but shouldn't be changed at all since it is removed
in the next commit. I will resend the series.
Antonin
next prev parent reply other threads:[~2026-02-18 15:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 13:15 [PATCH v2 0/4] bitbake-setup: Improve readability Antonin Godard
2026-02-18 13:15 ` [PATCH v2 1/4] bitbake-setup: define a color_enabled() helper function Antonin Godard
2026-02-18 13:15 ` [PATCH v2 2/4] bitbake-setup: improve readability of choices Antonin Godard
2026-02-18 13:15 ` [PATCH v2 3/4] bitbake-setup: print colored diffs Antonin Godard
2026-02-18 15:27 ` Antonin Godard [this message]
2026-02-19 9:36 ` [bitbake-devel] " Alexander Kanavin
2026-02-19 10:18 ` Antonin Godard
2026-02-19 11:13 ` Alexander Kanavin
2026-02-20 9:14 ` Antonin Godard
2026-02-18 13:15 ` [PATCH v2 4/4] bitbake-setup: drop get_diff and replace by run_git_diff Antonin Godard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGI6Z0US5NPC.6Y8DAVVEYWRG@bootlin.com \
--to=antonin.godard@bootlin.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.