All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Linus Walleij" <linusw@kernel.org>,
	"Ethan Tidmore" <ethantidmore06@gmail.com>
Cc: <joshua.henderson@microchip.com>, <linux-gpio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: pinctrl-pic32: Fix resource leaks
Date: Fri, 27 Feb 2026 15:01:01 -0600	[thread overview]
Message-ID: <DGQ1PH7L50P5.1S6WZBTYH2SNR@gmail.com> (raw)
In-Reply-To: <CAD++jLkYaEHEy=P68MRLEFsoxDFh5yxna7Eby8KeDzm8F7Zm3Q@mail.gmail.com>

On Thu Feb 26, 2026 at 4:37 PM CST, Linus Walleij wrote:

...

> Can't you just use devm_clk_get_enabled() and let devres do this?

I thought about that but wasn't sure because I saw:

	ret = gpiochip_add_data(&bank->gpio_chip, bank);

Later in the function and knew that you're not really suppose to mix
manual resource allocation and devres.

Thanks,

ET

  reply	other threads:[~2026-02-27 21:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 20:28 [PATCH] pinctrl: pinctrl-pic32: Fix resource leaks Ethan Tidmore
2026-02-26 22:37 ` Linus Walleij
2026-02-27 21:01   ` Ethan Tidmore [this message]
2026-02-27 21:12     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGQ1PH7L50P5.1S6WZBTYH2SNR@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=joshua.henderson@microchip.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.