From: "Danilo Krummrich" <dakr@kernel.org>
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<hanguidong02@gmail.com>, <ysato@users.sourceforge.jp>,
<dalias@libc.org>, <glaubitz@physik.fu-berlin.de>,
<abelvesa@kernel.org>, <srini@kernel.org>,
<s.nawrocki@samsung.com>, <nuno.sa@analog.com>,
<driver-core@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<imx@lists.linux.dev>, <linux-hwmon@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-sound@vger.kernel.org>,
<linux-sh@vger.kernel.org>, "Guenter Roeck" <groeck7@gmail.com>
Subject: Re: [PATCH 2/3] hwmon: axi-fan: don't use driver_override as IRQ name
Date: Mon, 02 Mar 2026 11:00:13 +0100 [thread overview]
Message-ID: <DGS7J5TC7WPA.17DR914PV3IJN@kernel.org> (raw)
In-Reply-To: <6e1c57f6-ac82-4e64-a49a-8b3ddc782b54@roeck-us.net>
On Mon Mar 2, 2026 at 1:51 AM CET, Guenter Roeck wrote:
> On 3/1/26 16:25, Danilo Krummrich wrote:
>> Do not use driver_override as IRQ name, as it is not guaranteed to point
>> to a valid string; use dev_name() instead.
>>
>> Fixes: 8412b410fa5e ("hwmon: Support ADI Fan Control IP")
>> Signed-off-by: Danilo Krummrich <dakr@kernel.org>
>> ---
>> drivers/hwmon/axi-fan-control.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c
>> index b7bb325c3ad9..ec4bbb104449 100644
>> --- a/drivers/hwmon/axi-fan-control.c
>> +++ b/drivers/hwmon/axi-fan-control.c
>> @@ -507,7 +507,7 @@ static int axi_fan_control_probe(struct platform_device *pdev)
>> ret = devm_request_threaded_irq(&pdev->dev, ctl->irq, NULL,
>> axi_fan_control_irq_handler,
>> IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
>> - pdev->driver_override, ctl);
>> + dev_name(&pdev->dev), ctl);
>
> The devm_request_threaded_irq() API documentation says:
>
> @devname: An ascii name for the claiming device, dev_name(dev) if NULL
>
> So NULL should be sufficient.
I usually prefer to be explicit, but I can change it to NULL.
Thanks,
Danilo
next prev parent reply other threads:[~2026-03-02 10:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 0:25 [PATCH 0/3] driver core: generalize driver_override infrastructure Danilo Krummrich
2026-03-02 0:25 ` [PATCH 1/3] driver core: generalize driver_override in struct device Danilo Krummrich
2026-03-02 7:35 ` Gui-Dong Han
2026-03-02 8:36 ` Gui-Dong Han
2026-03-02 10:05 ` Danilo Krummrich
2026-03-02 11:04 ` Gui-Dong Han
2026-03-02 10:00 ` Geert Uytterhoeven
2026-03-02 10:26 ` Danilo Krummrich
2026-03-02 10:38 ` Geert Uytterhoeven
2026-03-02 11:03 ` Danilo Krummrich
2026-03-02 10:23 ` Armin Wolf
2026-03-02 16:28 ` Danilo Krummrich
2026-03-02 0:25 ` [PATCH 2/3] hwmon: axi-fan: don't use driver_override as IRQ name Danilo Krummrich
2026-03-02 0:51 ` Guenter Roeck
2026-03-02 10:00 ` Danilo Krummrich [this message]
2026-03-02 11:02 ` Nuno Sá
2026-03-02 0:25 ` [PATCH 3/3] driver core: platform: use generic driver_override infrastructure Danilo Krummrich
2026-03-02 8:55 ` Gui-Dong Han
2026-03-02 9:41 ` [PATCH 0/3] driver core: generalize " Gui-Dong Han
2026-03-02 10:12 ` Danilo Krummrich
2026-03-02 10:59 ` Gui-Dong Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGS7J5TC7WPA.17DR914PV3IJN@kernel.org \
--to=dakr@kernel.org \
--cc=abelvesa@kernel.org \
--cc=dalias@libc.org \
--cc=driver-core@lists.linux.dev \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gregkh@linuxfoundation.org \
--cc=groeck7@gmail.com \
--cc=hanguidong02@gmail.com \
--cc=imx@lists.linux.dev \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nuno.sa@analog.com \
--cc=rafael@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=srini@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.