From: Arun Raghavan <arunr@valvesoftware.com>
To: Rong Zhang <i@rong.moe>, Jaroslav Kysela <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Cryolitia PukNgae <cryolitia@uniontech.com>,
Arun Raghavan <arunr@valvesoftware.com>,
<linux-sound@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, "Icenowy Zheng" <uwu@icenowy.me>,
<stable@vger.kernel.org>
Subject: Re: [External Mail] [PATCH v2 1/8] Revert "ALSA: usb: Increase volume range that triggers a warning"
Date: Mon, 2 Mar 2026 12:53:21 -0800 [thread overview]
Message-ID: <DGSLF8NH5JAV.59WNEOEXYHV@valvesoftware.com> (raw)
In-Reply-To: <20260302185900.427415-2-i@rong.moe>
On Mon Mar 2, 2026 at 10:58 AM PST, Rong Zhang wrote:
> UAC uses 2 bytes to store volume values, so the maximum volume range is
> 0xFFFF (65535, val = -32768/32767/1).
>
> The reverted commit bumpped the range of triggering the warning to >
> 65535, effectively making the range check a no-op. It didn't fix
> anything but covered any potential problems and deviated from the
> original intention of the range check.
>
> This reverts commit 6b971191fcfc9e3c2c0143eea22534f1f48dbb62.
>
> Fixes: 6b971191fcfc ("ALSA: usb: Increase volume range that triggers a warning")
> Cc: stable@vger.kernel.org
> Signed-off-by: Rong Zhang <i@rong.moe>
Thanks for catching and fixing this.
Acked-by: Arun Raghavan <arunr@valvesoftware.com>
next prev parent reply other threads:[~2026-03-02 20:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 18:58 [PATCH v2 0/8] ALSA: usb-audio: Add quirks for linear volume devices and deconflict VID Rong Zhang
2026-03-02 18:58 ` [PATCH v2 1/8] Revert "ALSA: usb: Increase volume range that triggers a warning" Rong Zhang
2026-03-02 20:53 ` Arun Raghavan [this message]
2026-03-02 18:58 ` [PATCH v2 2/8] ALSA: usb-audio: Add helper function for volume range checks Rong Zhang
2026-03-02 18:58 ` [PATCH v2 3/8] ALSA: usb-audio: Improve " Rong Zhang
2026-03-02 18:58 ` [PATCH v2 4/8] ALSA: usb-audio: Support string-descriptor-based quirk table entry Rong Zhang
2026-03-03 6:37 ` Takashi Iwai
2026-03-02 18:58 ` [PATCH v2 5/8] ALSA: usb-audio: Deconflict VID between Focusrite Novation & MV-SILICON Rong Zhang
2026-03-02 18:58 ` [PATCH v2 6/8] ALSA: usb-audio: Add QUIRK_FLAG_MIXER_{PLAYBACK,CAPTURE}_LINEAR_VOL Rong Zhang
2026-03-02 18:58 ` [PATCH v2 7/8] ALSA: usb-audio: Add linear volume quirk for Hotone Audio Pulze Mini Rong Zhang
2026-03-02 18:58 ` [PATCH v2 8/8] ALSA: usb-audio: Apply linear volume quirk on MV-SILICON devices Rong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGSLF8NH5JAV.59WNEOEXYHV@valvesoftware.com \
--to=arunr@valvesoftware.com \
--cc=corbet@lwn.net \
--cc=cryolitia@uniontech.com \
--cc=i@rong.moe \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.