From: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
To: Mohammed Bilal <mohammed.bilal@intel.com>,
<igt-dev@lists.freedesktop.org>
Cc: <jeevan.b@intel.com>, <kunal1.joshi@intel.com>,
<sebastian.brzezinka@intel.com>
Subject: Re: [PATCH v1 1/2] tests/chamelium/audio: Fix ALSA handle leak on skipped audio config
Date: Wed, 4 Mar 2026 12:19:22 +0100 [thread overview]
Message-ID: <DGTYGUU0VE90.LDNB0J6POGFZ@intel.com> (raw)
In-Reply-To: <20260304100553.3075443-2-mohammed.bilal@intel.com>
Hi Mohammed,
On Wed Mar 4, 2026 at 11:05 AM CET, Mohammed Bilal wrote:
> When the audio configuration check fails, the loop continues without
> closing previously opened ALSA handles. This leads to handle leaks
> across iterations and may eventually cause file descriptor exhaustion
> or configuration failures.
>
> Fix by ensuring the handles are closed before continuing.
>
> Signed-off-by: Mohammed Bilal <mohammed.bilal@intel.com>
> ---
This is a clean fix, I have no concerns.
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
--
Best regards,
Sebastian
next prev parent reply other threads:[~2026-03-04 11:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 10:05 [PATCH v1 0/2] tests/chamelium/audio: Fix resource leaks in audio tests Mohammed Bilal
2026-03-04 10:05 ` [PATCH v1 1/2] tests/chamelium/audio: Fix ALSA handle leak on skipped audio config Mohammed Bilal
2026-03-04 11:19 ` Sebastian Brzezinka [this message]
2026-03-04 10:05 ` [PATCH v1 2/2] tests/chamelium/audio: Fix resource leaks on assertion failure Mohammed Bilal
2026-03-04 12:18 ` Sebastian Brzezinka
2026-03-04 17:36 ` Bilal, Mohammed
2026-03-05 6:55 ` Sebastian Brzezinka
2026-03-05 3:28 ` ✓ i915.CI.BAT: success for tests/chamelium/audio: Fix resource leaks in audio tests Patchwork
2026-03-05 11:13 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-05 12:31 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-06 3:52 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGTYGUU0VE90.LDNB0J6POGFZ@intel.com \
--to=sebastian.brzezinka@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
--cc=kunal1.joshi@intel.com \
--cc=mohammed.bilal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.