From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BD78EB1042 for ; Tue, 10 Mar 2026 10:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:Subject:From: To:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4kwtoX7EkbEeZ8hNjrBhJI4a/orLttVoPQKye+s0Cr8=; b=0JRBbqhNywk+1u x0RW/B98y1mY0LtXlZWNgi+hEEnpCiaCArr6R1KLdqp51EcKZEPN3PG3g5a2oO5c5GSKjUspF2t8w mTmJP9LVWFt9zbAeoCLJxVbHjRkHjeljcESekNqvmBxQ9JE4o7i0NswStzZcLUfYU9gpmSsQ5Th6p c3GqSJy4efqtbuXTBOPPnF2Gxn77ni8dnzjAaFdvyp7W2/jnYbXtzbI/Ma4GdwLjMG49IuEQrXbJZ OTb+Qys7kAw3ZFhh34C0+NV1LPrMTAlfWIPBMxPG2WmwTTrEHe2LQGVa8dIOTfJ96PCrYejMAHMZ2 6sINvOwD1TEtpYYekEHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzuHl-00000009Bm9-3CVq; Tue, 10 Mar 2026 10:25:57 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vzuHi-00000009BjD-17iT for linux-riscv@lists.infradead.org; Tue, 10 Mar 2026 10:25:56 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 2BC3A1A2DAA; Tue, 10 Mar 2026 10:25:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E125060002; Tue, 10 Mar 2026 10:25:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 463D410369BAC; Tue, 10 Mar 2026 11:25:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773138347; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=71zUaXhdHoKDWjtB0MpHNOgpcJ2zjizbeuue0R2NhYs=; b=ohsqZQwQhJncrpf2sUV56DY/Oed/6DOyVDtua+44r0ig+r48WFVmQUWOFuCQyq7RLjALlC rk1ctQJbX1gYoXruqKwwWR4K9kh017398iv5o7m28IWra8DVDNpNWdLEuBc2wL7aQH/52m hZj+BPUNxKfk10mOMkqCqw+vsaIxjdtxSzybao1oCz6Ik+TjImkUBEzVb+jRUadhp+tP4o sUrVctqWiNgJVHLtLwNc2TjE6CapLs2jyxl5XO+3L1ghujyUbobqvvo37zy5qGvjgtE4T2 pHmkz373PMMSnoO6cOUxPG2J1+y/VzZZFZZx2r4yi5nK4LpOJzGGkHIyi/0oIg== Mime-Version: 1.0 Date: Tue, 10 Mar 2026 11:25:37 +0100 Message-Id: To: "Icenowy Zheng" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Drew Fustini" , "Guo Ren" , "Fu Wei" From: "Luca Ceresoli" Subject: Re: [PATCH v7 3/8] drm: verisilicon: add a driver for Verisilicon display controllers Cc: "Philipp Zabel" , "Dmitry Baryshkov" , "Michal Wilczynski" , "Han Gao" , "Yao Zi" , , , , X-Mailer: aerc 0.20.1 References: <20260129023922.1527729-1-zhengxingda@iscas.ac.cn> <20260129023922.1527729-4-zhengxingda@iscas.ac.cn> <301a33fc27bd01bb50d57779c2f9eb51a4fafaa5.camel@iscas.ac.cn> <57436150684e72049b62657caec544a2f18aab1c.camel@iscas.ac.cn> In-Reply-To: <57436150684e72049b62657caec544a2f18aab1c.camel@iscas.ac.cn> X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260310_032554_450267_EEB7DA40 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGVsbG8gSWNlbm93eSwKCk9uIE1vbiBNYXIgOSwgMjAyNiBhdCA1OjUxIFBNIENFVCwgSWNlbm93 eSBaaGVuZyB3cm90ZToKPiDlnKggMjAyNi0wMy0xMOS6jOeahCAwMDozNSArMDgwMO+8jEljZW5v d3kgWmhlbmflhpnpgZPvvJoKPiA9PT09PT09PT09PT09PT09IDg8ID09PT09PT09PT09PT09PT09 PQo+PiA+ID4gKwlpZiAoSVNfRVJSKGJyaWRnZSkpCj4+ID4gPiArCQlyZXR1cm4gRVJSX1BUUihQ VFJfRVJSKGJyaWRnZSkpOwo+PiA+ID4gKwo+PiA+ID4gKwlicmlkZ2UtPmNydGMgPSBjcnRjOwo+ PiA+ID4gKwlicmlkZ2UtPmludGYgPSBpbnRmOwo+PiA+ID4gKwlicmlkZ2UtPm5leHRfYnJpZGdl ID0gbmV4dDsKPj4gPgo+PiA+IFRoZXJlIGlzIG5vdyBhIG5leHRfYnJpZGdlIGZpZWxkIGluIHN0 cnVjdCBkcm1fYnJpZGdlLCB3aGljaAo+PiA+IGhhbmRsZXMKPj4gPiB0aGUKPj4gPiBicmlkZ2Ug bGlmZXRpbWUgaW4gYSBzYWZlciB3YXkgYW5kIG1vcmUgc2ltcGx5IFswXSwgc28geW91IGNvdWxk Cj4+ID4gdXNlCj4+ID4gaXQ6Cj4+Cj4+IEdsYWQgdG8gaGVhciBzdWNoIGEgZmllbGQgZXhpc3Rz IG5vdy4gV2lsbCBtb3JlIGNvZGUgYWJvdXQKPj4gbmV4dF9icmlkZ2UKPj4gbGlmZXRpbWUgbWFu YWdlbWVudCBiZWluZyBzaGFyZWQ/Cj4KPiBMb29rcyBsaWtlIG5vdyBtYW55IGRyaXZlcnMgY2Fu IGp1c3Qgc2hhcmUgdGhlIC5hdHRhY2ggZnVuY3Rpb24sCj4gYmVjYXVzZSB0aGV5J3JlIGFsbCBk b2luZyB0aGUgc2FtZSB0aGluZzoKPgo+IGBgYAo+IGludCBkcm1fYnJpZGdlX2F0dGFjaF9uZXh0 KHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UsCj4gCQkJICAgc3RydWN0IGRybV9lbmNvZGVyICpl bmNvZGVyLAo+IAkJCSAgIGVudW0gZHJtX2JyaWRnZV9hdHRhY2hfZmxhZ3MgZmxhZ3MpCj4gewo+ IAlyZXR1cm4gZHJtX2JyaWRnZV9hdHRhY2goZW5jb2RlciwgYnJpZGdlLT5uZXh0X2JyaWRnZSwK PiAJCQkJIGJyaWRnZSwgZmxhZ3MpOwo+IH0KPiBgYGAKPgo+IEF0IGxlYXN0IHZzX2JyaWRnZV9h dHRhY2ggaGVyZSBhbmQgbWVzb25fZW5jb2Rlcl8qX2F0dGFjaCAobmFtZWQKPiBlbmNvZGVyIGJ1 dCB0aGV5J3JlIGJyaWRnZSBkcml2ZXJzIG5vdykgbWF0Y2ggdGhpcyBwYXR0ZXJuICh0aGUgbGF0 dGVyCj4gZG9lcyBhIGNhc3QgZnJvbSBgc3RydWN0IGRybV9icmlkZ2UgKmAgdG8gdGhlaXIgc3Vi Y2xhc3NlcywgYnV0IHRoZW4KPiBvbmx5IGFjY2Vzc2luZyB0aGUgYGJyaWRnZWAgZmllbGQgb2Yg dGhlIHN1YmNsYXNzZXMgYW5kIGRvaW5nIHRoZSBzYW1lCj4gdGhpbmdzIGhlcmUpLgoKSW5kZWVk LCBzZXZlcmFsIGRyaXZlcnMgYXJlIG1vcmUgYW5kIG1vcmUgc2ltaWxhciBpbiB0aGlzIHJlc3Bl Y3Qgc28gYQpoZWxwZXIgY291bGQgZGVkdXBsaWNhdGUgYSBiaXQgb2YgY29kZSBpbiBhbiBlYXN5 IHdheSBoZXJlLgoKTHVjYQoKLS0KTHVjYSBDZXJlc29saSwgQm9vdGxpbgpFbWJlZGRlZCBMaW51 eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxpbi5jb20KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcg bGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6648844E053 for ; Tue, 10 Mar 2026 10:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773138357; cv=none; b=jLVOq+r1eERmFyBXPY4KT+H3sjPgYzz/gRk+Riq8wH1T1S/rrvLXV44mxBbHdCmCICgUlLCsTY6TKHf4BYk6D9dHc4O9M8DgFwUtFDf8Z3HcCTRIgQ4quyPcw9Qr3/4awWgom1gYtbUlyrmpLOJDIYjB6AEpW3nR6D3shNO9A64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773138357; c=relaxed/simple; bh=VmIGNdX8ajFRakIFSP2vEMfccnBICqmCQcblVAkapjI=; h=Mime-Version:Content-Type:Date:Message-Id:To:From:Subject:Cc: References:In-Reply-To; b=RNh415xsP82I4cuWFyQOF6IZmIwaZOEbQ3w6EsxePRVsfXzl5NQMmOf47CtdCBTie/wiGpfLpG43Jn+05wbEHuY/GS9F/nWjZTzMtjBPd4//IT2JA+RRZo0SYldsdyrYWzW99bZQ7OPiqdceA3tk6qY2HEFjAgFYgiSHp6bCU5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ohsqZQwQ; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ohsqZQwQ" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 378EF4E42563; Tue, 10 Mar 2026 10:25:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E125060002; Tue, 10 Mar 2026 10:25:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 463D410369BAC; Tue, 10 Mar 2026 11:25:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1773138347; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=71zUaXhdHoKDWjtB0MpHNOgpcJ2zjizbeuue0R2NhYs=; b=ohsqZQwQhJncrpf2sUV56DY/Oed/6DOyVDtua+44r0ig+r48WFVmQUWOFuCQyq7RLjALlC rk1ctQJbX1gYoXruqKwwWR4K9kh017398iv5o7m28IWra8DVDNpNWdLEuBc2wL7aQH/52m hZj+BPUNxKfk10mOMkqCqw+vsaIxjdtxSzybao1oCz6Ik+TjImkUBEzVb+jRUadhp+tP4o sUrVctqWiNgJVHLtLwNc2TjE6CapLs2jyxl5XO+3L1ghujyUbobqvvo37zy5qGvjgtE4T2 pHmkz373PMMSnoO6cOUxPG2J1+y/VzZZFZZx2r4yi5nK4LpOJzGGkHIyi/0oIg== Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 10 Mar 2026 11:25:37 +0100 Message-Id: To: "Icenowy Zheng" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Drew Fustini" , "Guo Ren" , "Fu Wei" From: "Luca Ceresoli" Subject: Re: [PATCH v7 3/8] drm: verisilicon: add a driver for Verisilicon display controllers Cc: "Philipp Zabel" , "Dmitry Baryshkov" , "Michal Wilczynski" , "Han Gao" , "Yao Zi" , , , , X-Mailer: aerc 0.20.1 References: <20260129023922.1527729-1-zhengxingda@iscas.ac.cn> <20260129023922.1527729-4-zhengxingda@iscas.ac.cn> <301a33fc27bd01bb50d57779c2f9eb51a4fafaa5.camel@iscas.ac.cn> <57436150684e72049b62657caec544a2f18aab1c.camel@iscas.ac.cn> In-Reply-To: <57436150684e72049b62657caec544a2f18aab1c.camel@iscas.ac.cn> X-Last-TLS-Session-Version: TLSv1.3 Hello Icenowy, On Mon Mar 9, 2026 at 5:51 PM CET, Icenowy Zheng wrote: > =E5=9C=A8 2026-03-10=E4=BA=8C=E7=9A=84 00:35 +0800=EF=BC=8CIcenowy Zheng= =E5=86=99=E9=81=93=EF=BC=9A > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D 8< =3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> > > + if (IS_ERR(bridge)) >> > > + return ERR_PTR(PTR_ERR(bridge)); >> > > + >> > > + bridge->crtc =3D crtc; >> > > + bridge->intf =3D intf; >> > > + bridge->next_bridge =3D next; >> > >> > There is now a next_bridge field in struct drm_bridge, which >> > handles >> > the >> > bridge lifetime in a safer way and more simply [0], so you could >> > use >> > it: >> >> Glad to hear such a field exists now. Will more code about >> next_bridge >> lifetime management being shared? > > Looks like now many drivers can just share the .attach function, > because they're all doing the same thing: > > ``` > int drm_bridge_attach_next(struct drm_bridge *bridge, > struct drm_encoder *encoder, > enum drm_bridge_attach_flags flags) > { > return drm_bridge_attach(encoder, bridge->next_bridge, > bridge, flags); > } > ``` > > At least vs_bridge_attach here and meson_encoder_*_attach (named > encoder but they're bridge drivers now) match this pattern (the latter > does a cast from `struct drm_bridge *` to their subclasses, but then > only accessing the `bridge` field of the subclasses and doing the same > things here). Indeed, several drivers are more and more similar in this respect so a helper could deduplicate a bit of code in an easy way here. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com