All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Ethan Tidmore" <ethantidmore06@gmail.com>,
	"Michael Margolin" <mrgolin@amazon.com>,
	"Jason Gunthorpe" <jgg@ziepe.ca>, <linux-rdma@vger.kernel.org>
Cc: "Leon Romanovsky" <leon@kernel.org>,
	"Gal Pressman" <gal.pressman@linux.dev>,
	"Yossi Leybovich" <sleybo@amazon.com>,
	"Daniel Kranzdorf" <dkkranzd@amazon.com>,
	"Yonatan Nachum" <ynachum@amazon.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/efa: Fix possible deadlock
Date: Sat, 14 Mar 2026 00:38:25 -0500	[thread overview]
Message-ID: <DH29H950UC56.1SCS13IC5SR8K@gmail.com> (raw)
In-Reply-To: <20260314045730.1143862-1-ethantidmore06@gmail.com>

On Fri Mar 13, 2026 at 11:57 PM CDT, Ethan Tidmore wrote:
> In the error path for efa_com_alloc_comp_ctx() the lock assigned to
> &aq->avail_cmds is not released.
>
> Add release for &aq->avail_cmds in efa_com_alloc_comp_ctx() error path.

Detected by Smatch:
drivers/infiniband/hw/efa/efa_com.c:662 efa_com_cmd_exec() warn:
inconsistent returns '&aq->avail_cmds'

>
> Fixes: ef3b06742c8a2 ("RDMA/efa: Fix use of completion ctx after free")
> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
> ---

Forgot to add the Smatch warning, if this version is good please add
this to the commit message.

Thanks,

ET

  reply	other threads:[~2026-03-14  5:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14  4:57 [PATCH] RDMA/efa: Fix possible deadlock Ethan Tidmore
2026-03-14  5:38 ` Ethan Tidmore [this message]
2026-03-16 20:20 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH29H950UC56.1SCS13IC5SR8K@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=dkkranzd@amazon.com \
    --cc=gal.pressman@linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mrgolin@amazon.com \
    --cc=sleybo@amazon.com \
    --cc=ynachum@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.