From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C078010706DD for ; Sat, 14 Mar 2026 14:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Cc :From:Subject:Message-Id:Date:Content-Type:Content-Transfer-Encoding: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Xl+Uf18fqruXHqchg5arUmkQufHcl9O3lBTne7YsaaQ=; b=foPYF/FsUiCdXXypUcGqb8gwLy ihpdUrY0Rw6pQib3CVs+Mt+z+XTL3+Py26k1U3ejQUjLaA2O+g5UYiozcMVRJdKBUzFj2Y4SARC0u Z2nS6HbfvpKvNrZJFV1ujLWtych6s4zm+R6hK3fHeFxlrtzALvRwphTsv23EKbIT6k6uz9t4UM/ky LSDAGMt+PDyTpgZ9PG4oKUaZHQGXM4MOk8z8OMwbU//RGT/jw9SrqFBPszKYsF0oEXpei3IsL8Ref 7xmN125PpcwaDyDY4j7UQoQoOeDalDuvrTY41TOfrmcGRcWTa9sYJClI4fDyj9DTmxZuTWObhp43o RlPag1sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w1PqL-00000001uup-2IHi; Sat, 14 Mar 2026 14:19:53 +0000 Received: from out-171.mta1.migadu.com ([95.215.58.171]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w1PqH-00000001uto-117Q for linux-arm-kernel@lists.infradead.org; Sat, 14 Mar 2026 14:19:51 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1773497976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xl+Uf18fqruXHqchg5arUmkQufHcl9O3lBTne7YsaaQ=; b=EGLEwi+WJkwvV8gz682AmrPTMD1U66aeOBTeWeosWn8TziuY17rzTDlXucPem7yuwUbLq7 k3uD0kFRayntDssYJGY5sVuAI4wWbmSzOu41+ADPrUqBWx/pcBVOU/y3PRMs7gzvDGYPQp pAUXoiRHvDVg7A3RYc4ZIKtqh/wY2k3K/nqRwi0G2EU1+QwCIg9Yt9XjmSAnqGUL6Hxno4 bUE/fjvSpd7TFrBVCvYoMrAD9BRmxj8kEs1IeCwDxG1FQZv8v6n0o9bdsXtqGvZM0FsP3S 0NOxd6rWdW1wq8uXlM6U+ImQcs3Sb6OhNdv01nvwlWX2ZRas/1r+Da2eeYSf5w== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 14 Mar 2026 15:19:22 +0100 Message-Id: Subject: Re: [PATCH v2 0/3] media: rockchip: rkvdec: add support for the VDPU346 variant X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" Cc: "Christian Hewitt" , "Detlev Casanova" , =?utf-8?q?Olivier_Cr=C3=AAte?= , "Ezequiel Garcia" , "Mauro Carvalho Chehab" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" , "Diederik de Haas" , "Dmitry Osipenko" , "Thomas Gleixner" , "Dragan Simic" , "Chukun Pan" , , , , , To: "Nicolas Dufresne" References: <20251226113140.573759-1-christianshewitt@gmail.com> In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260314_071950_697641_98C588A0 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nicolas, On Sun Mar 8, 2026 at 10:40 PM CET, Nicolas Dufresne wrote: > Le vendredi 26 d=C3=A9cembre 2025 =C3=A0 11:31 +0000, Christian Hewitt a = =C3=A9crit=C2=A0: >> This series depends upon Detlev Casanova's current v7 series for VDPU381= and >> VDPU383 support [0]. It adds support for the VDPU346 IP block used for H= 264, >> HEVC and (in active work) VP9 on the RK356X boards. VDPU346 appears to b= e a >> close relation to VDPU381 used with RK3588, except with a single core, o= utput >> limited to 4K, and minor feature differences, e.g. HEVC level 5.1 on VDP= U346 >> vs 6.1 on VDPU381. To handle differences we declare a new compatible. >>=20 >> The device-tree changes are derived from prior-art in Detlev's patches f= or >> RK3576 and RK3588, the vendor kernel [1], and some earlier patch attempt= s >> from Piotr Oniszczuk and Diederik de Haas. >>=20 >> The register differences between VDPU346 and VDPU381 appear to be minima= l so >> we currently and intentionally reuse the VDPU381 h264, hevc, and regs fi= les >> to avoid duplicating code. There is some evidence of buffer size changes= in >> testing which still need to be explored. If further register analysis ne= eds >> separate files for VDPU346 the refactoring will be beyond my current n00= b >> coding skills and I will either need some coaching or would be happy to = pass >> the series over to a more experienced developer. > > A fluster score and explained error report is missing your this cover let= ter.=20 > This will probably highlight some of the instability issues reported in t= his > series. I'll mark the series are "Change Request", as you have few review > comments and now this test. > > Overall, I'd like to see probably investigations of the problem before go= ing > ahead. FTR: You replied to v2 while there is a v3 here: https://patch.msgid.link/20260110053727.2295260-1-christianshewitt@gmail.co= m/ It (still) doesn't have a fluster score, but it is the currently most recent version posted on the MLs. Cheers, Diederik From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD54E10706DB for ; Sat, 14 Mar 2026 14:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Cc:From: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J9vNYzCSgehCX2Jtj/edRUPpC0rOzDPpCMD64BSYo6E=; b=pkTun2VXQoxgwg j9E8FFoRsgAva98kiPk7DLJu7uk4Yh9YDXE/9GuoOd3/w5SqP6PzvSTxqD41aDyhMPBdFaQZrvzRL M4EBFXNPP9wrz0qX8LBqfr8SI8MaCtnCb6EjTgX151di8DTYJOby9VpSC49XqOOaftJy82SQhzbZO TUFiuJo8W4PH2pCtnMLYznj6PXX0bIagx6SpQKtc4H80hAjHxdJIWndkOxkZcr0uBtevUOJoDlgi1 BX+HdYYNJ1E0yrmZeX9WtvAl2HEJK7loTqXaAXZfx5aAxcCJXEZ3Zh53lmH5A0EmsYGGtkn+eIP7T 2bprVXH6X66txWqGGaaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w1PqE-00000001utX-16Pw; Sat, 14 Mar 2026 14:19:46 +0000 Received: from out-177.mta1.migadu.com ([95.215.58.177]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w1PqB-00000001utA-21ND for linux-rockchip@lists.infradead.org; Sat, 14 Mar 2026 14:19:45 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1773497976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xl+Uf18fqruXHqchg5arUmkQufHcl9O3lBTne7YsaaQ=; b=EGLEwi+WJkwvV8gz682AmrPTMD1U66aeOBTeWeosWn8TziuY17rzTDlXucPem7yuwUbLq7 k3uD0kFRayntDssYJGY5sVuAI4wWbmSzOu41+ADPrUqBWx/pcBVOU/y3PRMs7gzvDGYPQp pAUXoiRHvDVg7A3RYc4ZIKtqh/wY2k3K/nqRwi0G2EU1+QwCIg9Yt9XjmSAnqGUL6Hxno4 bUE/fjvSpd7TFrBVCvYoMrAD9BRmxj8kEs1IeCwDxG1FQZv8v6n0o9bdsXtqGvZM0FsP3S 0NOxd6rWdW1wq8uXlM6U+ImQcs3Sb6OhNdv01nvwlWX2ZRas/1r+Da2eeYSf5w== Date: Sat, 14 Mar 2026 15:19:22 +0100 Message-Id: Subject: Re: [PATCH v2 0/3] media: rockchip: rkvdec: add support for the VDPU346 variant X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" Cc: "Christian Hewitt" , "Detlev Casanova" , =?utf-8?q?Olivier_Cr=C3=AAte?= , "Ezequiel Garcia" , "Mauro Carvalho Chehab" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" , "Diederik de Haas" , "Dmitry Osipenko" , "Thomas Gleixner" , "Dragan Simic" , "Chukun Pan" , , , , , To: "Nicolas Dufresne" References: <20251226113140.573759-1-christianshewitt@gmail.com> In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260314_071944_115650_97C98AF1 X-CRM114-Status: GOOD ( 14.89 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgTmljb2xhcywKCk9uIFN1biBNYXIgOCwgMjAyNiBhdCAxMDo0MCBQTSBDRVQsIE5pY29sYXMg RHVmcmVzbmUgd3JvdGU6Cj4gTGUgdmVuZHJlZGkgMjYgZMOpY2VtYnJlIDIwMjUgw6AgMTE6MzEg KzAwMDAsIENocmlzdGlhbiBIZXdpdHQgYSDDqWNyaXTCoDoKPj4gVGhpcyBzZXJpZXMgZGVwZW5k cyB1cG9uIERldGxldiBDYXNhbm92YSdzIGN1cnJlbnQgdjcgc2VyaWVzIGZvciBWRFBVMzgxIGFu ZAo+PiBWRFBVMzgzIHN1cHBvcnQgWzBdLiBJdCBhZGRzIHN1cHBvcnQgZm9yIHRoZSBWRFBVMzQ2 IElQIGJsb2NrIHVzZWQgZm9yIEgyNjQsCj4+IEhFVkMgYW5kIChpbiBhY3RpdmUgd29yaykgVlA5 IG9uIHRoZSBSSzM1NlggYm9hcmRzLiBWRFBVMzQ2IGFwcGVhcnMgdG8gYmUgYQo+PiBjbG9zZSBy ZWxhdGlvbiB0byBWRFBVMzgxIHVzZWQgd2l0aCBSSzM1ODgsIGV4Y2VwdCB3aXRoIGEgc2luZ2xl IGNvcmUsIG91dHB1dAo+PiBsaW1pdGVkIHRvIDRLLCBhbmQgbWlub3IgZmVhdHVyZSBkaWZmZXJl bmNlcywgZS5nLiBIRVZDIGxldmVsIDUuMSBvbiBWRFBVMzQ2Cj4+IHZzIDYuMSBvbiBWRFBVMzgx LiBUbyBoYW5kbGUgZGlmZmVyZW5jZXMgd2UgZGVjbGFyZSBhIG5ldyBjb21wYXRpYmxlLgo+PiAK Pj4gVGhlIGRldmljZS10cmVlIGNoYW5nZXMgYXJlIGRlcml2ZWQgZnJvbSBwcmlvci1hcnQgaW4g RGV0bGV2J3MgcGF0Y2hlcyBmb3IKPj4gUkszNTc2IGFuZCBSSzM1ODgsIHRoZSB2ZW5kb3Iga2Vy bmVsIFsxXSwgYW5kIHNvbWUgZWFybGllciBwYXRjaCBhdHRlbXB0cwo+PiBmcm9tIFBpb3RyIE9u aXN6Y3p1ayBhbmQgRGllZGVyaWsgZGUgSGFhcy4KPj4gCj4+IFRoZSByZWdpc3RlciBkaWZmZXJl bmNlcyBiZXR3ZWVuIFZEUFUzNDYgYW5kIFZEUFUzODEgYXBwZWFyIHRvIGJlIG1pbmltYWwgc28K Pj4gd2UgY3VycmVudGx5IGFuZCBpbnRlbnRpb25hbGx5IHJldXNlIHRoZSBWRFBVMzgxIGgyNjQs IGhldmMsIGFuZCByZWdzIGZpbGVzCj4+IHRvIGF2b2lkIGR1cGxpY2F0aW5nIGNvZGUuIFRoZXJl IGlzIHNvbWUgZXZpZGVuY2Ugb2YgYnVmZmVyIHNpemUgY2hhbmdlcyBpbgo+PiB0ZXN0aW5nIHdo aWNoIHN0aWxsIG5lZWQgdG8gYmUgZXhwbG9yZWQuIElmIGZ1cnRoZXIgcmVnaXN0ZXIgYW5hbHlz aXMgbmVlZHMKPj4gc2VwYXJhdGUgZmlsZXMgZm9yIFZEUFUzNDYgdGhlIHJlZmFjdG9yaW5nIHdp bGwgYmUgYmV5b25kIG15IGN1cnJlbnQgbjAwYgo+PiBjb2Rpbmcgc2tpbGxzIGFuZCBJIHdpbGwg ZWl0aGVyIG5lZWQgc29tZSBjb2FjaGluZyBvciB3b3VsZCBiZSBoYXBweSB0byBwYXNzCj4+IHRo ZSBzZXJpZXMgb3ZlciB0byBhIG1vcmUgZXhwZXJpZW5jZWQgZGV2ZWxvcGVyLgo+Cj4gQSBmbHVz dGVyIHNjb3JlIGFuZCBleHBsYWluZWQgZXJyb3IgcmVwb3J0IGlzIG1pc3NpbmcgeW91ciB0aGlz IGNvdmVyIGxldHRlci4gCj4gVGhpcyB3aWxsIHByb2JhYmx5IGhpZ2hsaWdodCBzb21lIG9mIHRo ZSBpbnN0YWJpbGl0eSBpc3N1ZXMgcmVwb3J0ZWQgaW4gdGhpcwo+IHNlcmllcy4gSSdsbCBtYXJr IHRoZSBzZXJpZXMgYXJlICJDaGFuZ2UgUmVxdWVzdCIsIGFzIHlvdSBoYXZlIGZldyByZXZpZXcK PiBjb21tZW50cyBhbmQgbm93IHRoaXMgdGVzdC4KPgo+IE92ZXJhbGwsIEknZCBsaWtlIHRvIHNl ZSBwcm9iYWJseSBpbnZlc3RpZ2F0aW9ucyBvZiB0aGUgcHJvYmxlbSBiZWZvcmUgZ29pbmcKPiBh aGVhZC4KCkZUUjogWW91IHJlcGxpZWQgdG8gdjIgd2hpbGUgdGhlcmUgaXMgYSB2MyBoZXJlOgpo dHRwczovL3BhdGNoLm1zZ2lkLmxpbmsvMjAyNjAxMTAwNTM3MjcuMjI5NTI2MC0xLWNocmlzdGlh bnNoZXdpdHRAZ21haWwuY29tLwoKSXQgKHN0aWxsKSBkb2Vzbid0IGhhdmUgYSBmbHVzdGVyIHNj b3JlLCBidXQgaXQgaXMgdGhlIGN1cnJlbnRseSBtb3N0CnJlY2VudCB2ZXJzaW9uIHBvc3RlZCBv biB0aGUgTUxzLgoKQ2hlZXJzLAogIERpZWRlcmlrCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgt cm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg==