From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Mashiro Chen" <mashiro.chen@mailbox.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dan Carpenter" <error27@gmail.com>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] staging: rtl8723bs: macro fixes in basic_types.h
Date: Mon, 30 Mar 2026 14:36:03 +0000 [thread overview]
Message-ID: <DHG6XM1H014T.B4RW4LAW5XXU@linux.dev> (raw)
In-Reply-To: <20260330114232.91431-1-mashiro.chen@mailbox.org>
Hi Mashiro,
Thanks for the v2. This series is a solid improvement. Cleaning up the
basic_types.h header is a necessary step toward eventually getting
qqthis driver out of staging and into the mainline networking tree.
Here is my formal review of the series.
Patch 1/3: Excellent catch by Dan Carpenter here. Removing the
WRITEEF/READEF macros is far superior to fixing them. Specifically,
the latent bug in WRITEEF4BYTE (which incorrectly used EF2BYTE) is now
gone without adding any binary bloat.
Patch 2/3: This correctly silences the COMPLEX_MACRO warnings from
checkpatch.pl. While these macros are candidates for a full refactor
into <linux/bitfield.h> eventually, your fix ensures operator
precedence is respected in the meantime.
Patch 3/3: Clean and trivial.
So for the series:
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
prev parent reply other threads:[~2026-03-30 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 11:42 [PATCH v2 0/3] staging: rtl8723bs: macro fixes in basic_types.h Mashiro Chen
2026-03-30 11:42 ` [PATCH v2 1/3] staging: rtl8723bs: remove unused WRITEEF/READEF byte macros Mashiro Chen
2026-03-30 11:42 ` [PATCH v2 2/3] staging: rtl8723bs: wrap complex macros with parentheses Mashiro Chen
2026-03-30 11:42 ` [PATCH v2 3/3] staging: rtl8723bs: remove redundant blank lines in basic_types.h Mashiro Chen
2026-03-30 14:36 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHG6XM1H014T.B4RW4LAW5XXU@linux.dev \
--to=luka.gejak@linux.dev \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mashiro.chen@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.