All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Linus Probert" <linus.probert@gmail.com>,
	"Ethan Tidmore" <ethantidmore06@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/7] staging: rtl8723bs: rename EFUSE_Read1Byte() to rtw_efuse_read_1_byte()
Date: Fri, 03 Apr 2026 20:17:10 -0500	[thread overview]
Message-ID: <DHJZ2NZMM7HS.3MA13Q4NVQN6O@gmail.com> (raw)
In-Reply-To: <DHJV2X9P1XP8.2L6P5A8Y7G3EC@gmail.com>

On Fri Apr 3, 2026 at 5:09 PM CDT, Linus Probert wrote:
> On Fri Apr 3, 2026 at 11:39 PM CEST, Ethan Tidmore wrote:
>> On Thu Apr 2, 2026 at 12:42 AM CDT, Linus Probert wrote:
>>> Renames EFUSE_Read1Byte to rtw_efuse_read_1_byte in order to conform to
>>> kernel code styl.
>>
>> I missed that you misspelt style in my last review. Sorry about that.
>> Also, its generally wanted that you include the change logs in the
>> actual patches themselves.
>
> No worries. I'll fix and also include all the v0-v6 history in the
> individual patches.
>
> I had one question. If you have provided feedback on a
> patchset. Should I include you in the 'too' or just stick to whatever
> get_maintainer.pl spits out? Can't recall reading about any general MO
> regarding this.

There is no hard-and-fast rule but it'd be good etiquette to CC someone
if they reviewed your patchset.

Thanks,

ET

>
> Br,
> Linus


  reply	other threads:[~2026-04-04  1:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02  5:42 [PATCH v5 0/7] staging: rtl8723bs: rename/remove functions Linus Probert
2026-04-02  5:42 ` [PATCH v5 1/7] staging: rtl8723bs: rename global function Efuse_CalculateWordCnts Linus Probert
2026-04-02  5:42 ` [PATCH v5 2/7] staging: rtl8723bs: efuse_OneByteRead() -> rtw_efuse_one_byte_read() Linus Probert
2026-04-02  5:42 ` [PATCH v5 3/7] staging: rtl8723bs: rename EFUSE_Read1Byte() to rtw_efuse_read_1_byte() Linus Probert
2026-04-03 21:39   ` Ethan Tidmore
2026-04-03 22:09     ` Linus Probert
2026-04-04  1:17       ` Ethan Tidmore [this message]
2026-04-02  5:42 ` [PATCH v5 4/7] staging: rtl8723bs: EFUSE_ShadowMapUpdate -> rtw_efuse_shadow_map_update Linus Probert
2026-04-02  5:42 ` [PATCH v5 5/7] staging: rtl8723bs: rename EFUSE_ShadowRead() to rtw_efuse_shadow_read() Linus Probert
2026-04-02  5:42 ` [PATCH v5 6/7] staging: rtl8723bs: remove two unused function prototypes Linus Probert
2026-04-02  5:42 ` [PATCH v5 7/7] staging: rtl8723bs: remove space before tab Linus Probert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHJZ2NZMM7HS.3MA13Q4NVQN6O@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.probert@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.