All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "David Carlier" <devnexen@gmail.com>
Cc: Danilo Krummrich <dakr@kernel.org>,
	Alice Ryhl <aliceryhl@google.com>,
	Simona Vetter <simona@ffwll.ch>, Gary Guo <gary@garyguo.net>,
	Alistair Popple <apopple@nvidia.com>,
	Eliot Courtney <ecourtney@nvidia.com>,
	nouveau@lists.freedesktop.org
Subject: Re: [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message
Date: Mon, 06 Apr 2026 10:17:24 +0900	[thread overview]
Message-ID: <DHLOBXHYJDLY.7TN3A9EM5LS5@nvidia.com> (raw)
In-Reply-To: <20260331103744.605683-1-devnexen@gmail.com>

On Tue Mar 31, 2026 at 7:37 PM JST, David Carlier wrote:
> The SEC2 mailbox debug output formats MBOX1 without a colon separator,
> producing "MBOX10xdead" instead of "MBOX1: 0xdead". The GSP debug
> message a few lines above uses the correct format.
>
> Fixes: 5949d419c193 ("gpu: nova-core: gsp: Boot GSP")
> Signed-off-by: David Carlier <devnexen@gmail.com>
> ---
>  drivers/gpu/nova-core/gsp/boot.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/boot.rs
> index 6f707b3d1a54..18f356c9178e 100644
> --- a/drivers/gpu/nova-core/gsp/boot.rs
> +++ b/drivers/gpu/nova-core/gsp/boot.rs
> @@ -195,7 +195,7 @@ pub(crate) fn boot(
>              Some(wpr_handle as u32),
>              Some((wpr_handle >> 32) as u32),
>          )?;
> -        dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1);
> +        dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1);
>  
>          if mbox0 != 0 {
>              dev_err!(pdev, "Booter-load failed with error {:#x}\n", mbox0);
> -- 
> 2.53.0

As agreed upon with Danilo, pushed into drm-rust-next! Thanks for the fix.

      parent reply	other threads:[~2026-04-06  1:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-31 10:37 [PATCH] gpu: nova-core: fix missing colon in SEC2 boot debug message David Carlier
2026-03-31 19:19 ` John Hubbard
2026-04-04  2:19 ` Alexandre Courbot
2026-04-04  9:37   ` Danilo Krummrich
2026-04-06  1:17 ` Alexandre Courbot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHLOBXHYJDLY.7TN3A9EM5LS5@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=devnexen@gmail.com \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=nouveau@lists.freedesktop.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.