From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Pranav Desai" <contact.pranavdesai@gmail.com>,
<gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <straube.linux@gmail.com>,
<b9788213@gmail.com>, <bera@yuzu.li>
Subject: Re: [PATCH 1/2] staging: rtl8723bs: remove commented-out dead code in HalPhyRf_8723B.c
Date: Thu, 09 Apr 2026 15:57:46 +0200 [thread overview]
Message-ID: <DHOODQY42WIB.K8JZ49O3K7QL@linux.dev> (raw)
In-Reply-To: <20260409034859.42356-1-contact.pranavdesai@gmail.com>
On Thu Apr 9, 2026 at 5:48 AM CEST, Pranav Desai wrote:
> Remove commented-out code blocks
>
> Signed-off-by: Pranav Desai <contact.pranavdesai@gmail.com>
Hi Pranav,
This patch removes some comments that describe code that is not
commented-out. Please carefully review this patch to ensure you are
only removing commented-out C code (and comments that explicitly
describe that dead code). Do not remove active comments.
Best regards,
Luka Gejak
> ---
> .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 85 -------------------
> 1 file changed, 85 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> index 8f6849f2277e..63c848ebd661 100644
> --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> @@ -361,9 +361,6 @@ static u8 phy_PathA_IQK_8723B(
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_RCK_OS, bRFRegOffsetMask, 0x18000);
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G1, bRFRegOffsetMask, 0x0003f);
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G2, bRFRegOffsetMask, 0xc7f87);
> - /* disable path B PA in TXIQK mode */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xed, bRFRegOffsetMask, 0x00020); */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x43, bRFRegOffsetMask, 0x40ec1); */
>
> /* 1 Tx IQK */
> /* IQK setting */
> @@ -374,7 +371,6 @@ static u8 phy_PathA_IQK_8723B(
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_Tone_A, bMaskDWord, 0x38008c1c);
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_Tone_B, bMaskDWord, 0x38008c1c);
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_Tone_B, bMaskDWord, 0x38008c1c);
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_A, bMaskDWord, 0x8214010a); */
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_A, bMaskDWord, 0x821303ea);
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_PI_A, bMaskDWord, 0x28110000);
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_B, bMaskDWord, 0x82110000);
> @@ -401,8 +397,6 @@ static u8 phy_PathA_IQK_8723B(
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf9000000);
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf8000000);
>
> - /* delay x ms */
> - /* PlatformStallExecution(IQK_DELAY_TIME_8723B*1000); */
> mdelay(IQK_DELAY_TIME_8723B);
>
> /* restore Ant Path */
> @@ -462,7 +456,6 @@ static u8 phy_PathA_RxIQK8723B(
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G1, bRFRegOffsetMask, 0x0001f);
> /* LNA2 off, PA on for Dcut */
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G2, bRFRegOffsetMask, 0xf7fb7);
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_WE_LUT, 0x80000, 0x0); */
> PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_IQK, bMaskH3Bytes, 0x808000);
>
> /* IQK setting */
> @@ -475,7 +468,6 @@ static u8 phy_PathA_RxIQK8723B(
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_Tone_B, bMaskDWord, 0x38008c1c);
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_Tone_B, bMaskDWord, 0x38008c1c);
>
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_A, bMaskDWord, 0x82160c1f); */
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_A, bMaskDWord, 0x82130ff0);
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_PI_A, bMaskDWord, 0x28110000);
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_B, bMaskDWord, 0x82110000);
> @@ -502,8 +494,6 @@ static u8 phy_PathA_RxIQK8723B(
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf9000000);
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf8000000);
>
> - /* delay x ms */
> - /* PlatformStallExecution(IQK_DELAY_TIME_8723B*1000); */
> mdelay(IQK_DELAY_TIME_8723B);
>
> /* restore Ant Path */
> @@ -546,7 +536,6 @@ static u8 phy_PathA_RxIQK8723B(
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G1, bRFRegOffsetMask, 0x0001f);
> /* LAN2 on, PA off for Dcut */
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G2, bRFRegOffsetMask, 0xf7d77);
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_WE_LUT, 0x80000, 0x0); */
>
> /* PA, PAD setting */
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xdf, bRFRegOffsetMask, 0xf80);
> @@ -563,7 +552,6 @@ static u8 phy_PathA_RxIQK8723B(
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_Tone_B, bMaskDWord, 0x38008c1c);
>
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_A, bMaskDWord, 0x82110000);
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_PI_A, bMaskDWord, 0x281604c2); */
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_PI_A, bMaskDWord, 0x2813001f);
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_B, bMaskDWord, 0x82110000);
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_PI_B, bMaskDWord, 0x28110000);
> @@ -589,8 +577,6 @@ static u8 phy_PathA_RxIQK8723B(
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf9000000);
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf8000000);
>
> - /* delay x ms */
> - /* PlatformStallExecution(IQK_DELAY_TIME_8723B*1000); */
> mdelay(IQK_DELAY_TIME_8723B);
>
> /* restore Ant Path */
> @@ -642,12 +628,6 @@ static u8 phy_PathB_IQK_8723B(struct adapter *padapter)
> /* leave IQK mode */
> PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_IQK, bMaskH3Bytes, 0x000000);
>
> - /* in TXIQK mode */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_WE_LUT, 0x80000, 0x1); */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_RCK_OS, bRFRegOffsetMask, 0x20000); */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G1, bRFRegOffsetMask, 0x0003f); */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G2, bRFRegOffsetMask, 0xc7f87); */
> - /* enable path B PA in TXIQK mode */
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xed, 0x20, 0x1);
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x43, bRFRegOffsetMask, 0x30fc1);
>
> @@ -663,7 +643,6 @@ static u8 phy_PathB_IQK_8723B(struct adapter *padapter)
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_Tone_B, bMaskDWord, 0x38008c1c);
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_Tone_B, bMaskDWord, 0x38008c1c);
>
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_A, bMaskDWord, 0x82140114); */
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_A, bMaskDWord, 0x821303ea);
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_PI_A, bMaskDWord, 0x28110000);
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_B, bMaskDWord, 0x82110000);
> @@ -677,7 +656,6 @@ static u8 phy_PathB_IQK_8723B(struct adapter *padapter)
>
> /* switch to path B */
> PHY_SetBBReg(pDM_Odm->Adapter, 0x948, bMaskDWord, 0x00000280);
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xb0, bRFRegOffsetMask, 0xeffe0); */
>
> /* GNT_BT = 0 */
> PHY_SetBBReg(pDM_Odm->Adapter, 0x764, bMaskDWord, 0x00000800);
> @@ -686,8 +664,6 @@ static u8 phy_PathB_IQK_8723B(struct adapter *padapter)
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf9000000);
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf8000000);
>
> - /* delay x ms */
> - /* PlatformStallExecution(IQK_DELAY_TIME_88E*1000); */
> mdelay(IQK_DELAY_TIME_8723B);
>
> /* restore Ant Path */
> @@ -757,7 +733,6 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_Tone_B, bMaskDWord, 0x38008c1c);
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_Tone_B, bMaskDWord, 0x38008c1c);
>
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_A, bMaskDWord, 0x82160c1f); */
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_A, bMaskDWord, 0x82130ff0);
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_PI_A, bMaskDWord, 0x28110000);
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_B, bMaskDWord, 0x82110000);
> @@ -771,7 +746,6 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
>
> /* switch to path B */
> PHY_SetBBReg(pDM_Odm->Adapter, 0x948, bMaskDWord, 0x00000280);
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xb0, bRFRegOffsetMask, 0xeffe0); */
>
> /* GNT_BT = 0 */
> PHY_SetBBReg(pDM_Odm->Adapter, 0x764, bMaskDWord, 0x00000800);
> @@ -781,8 +755,6 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf8000000);
>
>
> - /* delay x ms */
> - /* PlatformStallExecution(IQK_DELAY_TIME_88E*1000); */
> mdelay(IQK_DELAY_TIME_8723B);
>
> /* restore Ant Path */
> @@ -825,16 +797,11 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_RCK_OS, bRFRegOffsetMask, 0x18000);
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G1, bRFRegOffsetMask, 0x0001f);
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_TXPA_G2, bRFRegOffsetMask, 0xf7d77);
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_WE_LUT, 0x80000, 0x0); */
>
> /* open PA S1 & close SMIXER */
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xed, 0x20, 0x1);
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x43, bRFRegOffsetMask, 0x30ebd);
>
> - /* PA, PAD setting */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xdf, bRFRegOffsetMask, 0xf80); */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x56, bRFRegOffsetMask, 0x51000); */
> -
> /* IQK setting */
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK, bMaskDWord, 0x01004800);
>
> @@ -845,7 +812,6 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_Tone_B, bMaskDWord, 0x38008c1c);
>
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_A, bMaskDWord, 0x82110000);
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_PI_A, bMaskDWord, 0x281604c2); */
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_PI_A, bMaskDWord, 0x2813001f);
> PHY_SetBBReg(pDM_Odm->Adapter, rTx_IQK_PI_B, bMaskDWord, 0x82110000);
> PHY_SetBBReg(pDM_Odm->Adapter, rRx_IQK_PI_B, bMaskDWord, 0x28110000);
> @@ -858,7 +824,6 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
>
> /* switch to path B */
> PHY_SetBBReg(pDM_Odm->Adapter, 0x948, bMaskDWord, 0x00000280);
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xb0, bRFRegOffsetMask, 0xeffe0); */
>
> /* GNT_BT = 0 */
> PHY_SetBBReg(pDM_Odm->Adapter, 0x764, bMaskDWord, 0x00000800);
> @@ -867,8 +832,6 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf9000000);
> PHY_SetBBReg(pDM_Odm->Adapter, rIQK_AGC_Pts, bMaskDWord, 0xf8000000);
>
> - /* delay x ms */
> - /* PlatformStallExecution(IQK_DELAY_TIME_88E*1000); */
> mdelay(IQK_DELAY_TIME_8723B);
>
> /* restore Ant Path */
> @@ -883,12 +846,6 @@ static u8 phy_PathB_RxIQK8723B(struct adapter *padapter, bool configPathB)
> regEAC = PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord);
> regEA4 = PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord);
>
> - /* PA/PAD controlled by 0x0 */
> - /* leave IQK mode */
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_IQK, 0xffffff00, 0x00000000); */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_B, 0xdf, bRFRegOffsetMask, 0x180); */
> -
> -
>
> /* Allen 20131125 */
> tmp = (regEAC & 0x03FF0000)>>16;
> @@ -960,7 +917,6 @@ static void _PHY_PathAFillIQKMatrix8723B(
> pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xCA0][KEY] = rOFDM0_RxIQExtAnta;
> pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xCA0][VAL] = 0xfffffff & PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_RxIQExtAnta, bMaskDWord);
> pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][KEY] = rOFDM0_XARxIQImbalance;
> -/* pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][VAL] = PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XARxIQImbalance, bMaskDWord); */
> pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][VAL] = 0x40000100;
> return;
> }
> @@ -1020,8 +976,6 @@ static void _PHY_PathBFillIQKMatrix8723B(
>
> /* 2 Tx IQC */
> PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_XDTxAFE, 0xF0000000, ((TX1_C&0x3C0)>>6));
> -/* pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC9C][KEY] = rOFDM0_XDTxAFE; */
> -/* pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC9C][VAL] = PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XDTxAFE, bMaskDWord); */
> pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC94][KEY] = rOFDM0_XCTxAFE;
> pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC94][VAL] = PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XDTxAFE, bMaskDWord);
>
> @@ -1035,7 +989,6 @@ static void _PHY_PathBFillIQKMatrix8723B(
>
> if (bTxOnly) {
> pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC14][KEY] = rOFDM0_XARxIQImbalance;
> -/* pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC14][VAL] = PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XARxIQImbalance, bMaskDWord); */
> pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC14][VAL] = 0x40000100;
> pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][KEY] = rOFDM0_RxIQExtAnta;
> pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][VAL] = 0x0fffffff & PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_RxIQExtAnta, bMaskDWord);
> @@ -1051,7 +1004,6 @@ static void _PHY_PathBFillIQKMatrix8723B(
> pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC14][VAL] = PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_XBRxIQImbalance, bMaskDWord);
>
> reg = (result[final_candidate][7] >> 6) & 0xF;
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rOFDM0_AGCRSSITable, 0x0000F000, reg); */
> pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][KEY] = rOFDM0_RxIQExtAnta;
> pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][VAL] = (reg << 28)|(PHY_QueryBBReg(pDM_Odm->Adapter, rOFDM0_RxIQExtAnta, bMaskDWord)&0x0fffffff);
> }
> @@ -1353,11 +1305,6 @@ static void phy_IQCalibrate_8723B(
>
> _PHY_PathADDAOn8723B(padapter, ADDA_REG, is2T);
>
> -/* no serial mode */
> -
> - /* save RF path for 8723B */
> -/* Path_SEL_BB = PHY_QueryBBReg(pDM_Odm->Adapter, 0x948, bMaskDWord); */
> -/* Path_SEL_RF = PHY_QueryRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xb0, 0xfffff); */
>
> /* MAC settings */
> _PHY_MACSettingCalibration8723B(padapter, IQK_MAC_REG, pDM_Odm->RFCalibrateInfo.IQK_MAC_backup);
> @@ -1370,14 +1317,6 @@ static void phy_IQCalibrate_8723B(
> PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_XCD_RFInterfaceSW, bMaskDWord, 0x22204000);
>
>
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_XAB_RFInterfaceSW, BIT10, 0x01); */
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_XAB_RFInterfaceSW, BIT26, 0x01); */
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_XA_RFInterfaceOE, BIT10, 0x00); */
> -/* PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_XB_RFInterfaceOE, BIT10, 0x00); */
> -
> -
> -/* RX IQ calibration setting for 8723B D cut large current issue when leaving IPS */
> -
> PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_IQK, bMaskH3Bytes, 0x000000);
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_WE_LUT, 0x80000, 0x1);
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_RCK_OS, bRFRegOffsetMask, 0x30000);
> @@ -1389,7 +1328,6 @@ static void phy_IQCalibrate_8723B(
> /* path A TX IQK */
> for (i = 0 ; i < retryCount ; i++) {
> PathAOK = phy_PathA_IQK_8723B(padapter, is2T, RF_Path);
> -/* if (PathAOK == 0x03) { */
> if (PathAOK == 0x01) {
> /* Path A Tx IQK Success */
> PHY_SetBBReg(pDM_Odm->Adapter, rFPGA0_IQK, bMaskH3Bytes, 0x000000);
> @@ -1407,8 +1345,6 @@ static void phy_IQCalibrate_8723B(
> for (i = 0 ; i < retryCount ; i++) {
> PathAOK = phy_PathA_RxIQK8723B(padapter, is2T, RF_Path);
> if (PathAOK == 0x03) {
> -/* result[t][0] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_Before_IQK_A, bMaskDWord)&0x3FF0000)>>16; */
> -/* result[t][1] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK_A, bMaskDWord)&0x3FF0000)>>16; */
> result[t][2] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
> result[t][3] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
> break;
> @@ -1439,8 +1375,6 @@ static void phy_IQCalibrate_8723B(
> for (i = 0 ; i < retryCount ; i++) {
> PathBOK = phy_PathB_RxIQK8723B(padapter, is2T);
> if (PathBOK == 0x03) {
> -/* result[t][0] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_Before_IQK_A, bMaskDWord)&0x3FF0000)>>16; */
> -/* result[t][1] = (PHY_QueryBBReg(pDM_Odm->Adapter, rTx_Power_After_IQK_A, bMaskDWord)&0x3FF0000)>>16; */
> result[t][6] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_Before_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
> result[t][7] = (PHY_QueryBBReg(pDM_Odm->Adapter, rRx_Power_After_IQK_A_2, bMaskDWord)&0x3FF0000)>>16;
> break;
> @@ -1462,9 +1396,6 @@ static void phy_IQCalibrate_8723B(
>
> _PHY_ReloadADDARegisters8723B(padapter, IQK_BB_REG_92C, pDM_Odm->RFCalibrateInfo.IQK_BB_backup, IQK_BB_REG_NUM);
>
> - /* Reload RF path */
> -/* PHY_SetBBReg(pDM_Odm->Adapter, 0x948, bMaskDWord, Path_SEL_BB); */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xb0, 0xfffff, Path_SEL_RF); */
>
> /* Allen initial gain 0xc50 */
> /* Restore RX initial gain */
> @@ -1642,14 +1573,6 @@ void PHY_IQCalibrate_8723B(
>
> /* save default GNT_BT */
> GNT_BT_default = PHY_QueryBBReg(pDM_Odm->Adapter, 0x764, bMaskDWord);
> - /* Save RF Path */
> -/* Path_SEL_BB = PHY_QueryBBReg(pDM_Odm->Adapter, 0x948, bMaskDWord); */
> -/* Path_SEL_RF = PHY_QueryRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xb0, 0xfffff); */
> -
> - /* set GNT_BT = 0, pause BT traffic */
> -/* PHY_SetBBReg(pDM_Odm->Adapter, 0x764, BIT12, 0x0); */
> -/* PHY_SetBBReg(pDM_Odm->Adapter, 0x764, BIT11, 0x1); */
> -
>
> for (i = 0; i < 8; i++) {
> result[0][i] = 0;
> @@ -1742,10 +1665,6 @@ void PHY_IQCalibrate_8723B(
>
> /* restore GNT_BT */
> PHY_SetBBReg(pDM_Odm->Adapter, 0x764, bMaskDWord, GNT_BT_default);
> - /* Restore RF Path */
> -/* PHY_SetBBReg(pDM_Odm->Adapter, 0x948, bMaskDWord, Path_SEL_BB); */
> -/* PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xb0, 0xfffff, Path_SEL_RF); */
> -
> /* Resotr RX mode table parameter */
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_WE_LUT, 0x80000, 0x1);
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, RF_RCK_OS, bRFRegOffsetMask, 0x18000);
> @@ -1754,10 +1673,6 @@ void PHY_IQCalibrate_8723B(
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0xed, 0x20, 0x1);
> PHY_SetRFReg(pDM_Odm->Adapter, RF_PATH_A, 0x43, bRFRegOffsetMask, 0x300bd);
>
> - /* set GNT_BT = HW control */
> -/* PHY_SetBBReg(pDM_Odm->Adapter, 0x764, BIT12, 0x0); */
> -/* PHY_SetBBReg(pDM_Odm->Adapter, 0x764, BIT11, 0x0); */
> -
> if (Is2ant) {
> if (RF_Path == 0x0) /* S1 */
> ODM_SetIQCbyRFpath(pDM_Odm, 0);
prev parent reply other threads:[~2026-04-09 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 3:48 [PATCH 1/2] staging: rtl8723bs: remove commented-out dead code in HalPhyRf_8723B.c Pranav Desai
2026-04-09 3:48 ` [PATCH 2/2] staging: rtl8723bs: fix comment style " Pranav Desai
2026-04-09 14:03 ` Luka Gejak
2026-04-09 13:14 ` [PATCH 1/2] staging: rtl8723bs: remove commented-out dead code " Bera Yüzlü
2026-04-09 13:57 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHOODQY42WIB.K8JZ49O3K7QL@linux.dev \
--to=luka.gejak@linux.dev \
--cc=b9788213@gmail.com \
--cc=bera@yuzu.li \
--cc=contact.pranavdesai@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.