From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44899F44847 for ; Fri, 10 Apr 2026 12:11:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D777B10E94B; Fri, 10 Apr 2026 12:11:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=ubuntu.com header.i=@ubuntu.com header.b="LJVHXfr2"; dkim-atps=neutral Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3EE810E94B for ; Fri, 10 Apr 2026 12:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubuntu.com; h=In-Reply-To: References: To: From: Subject: Cc: Message-Id: Date: Content-Type: Content-Transfer-Encoding: Mime-Version; q=dns/txt; s=fe-953a8a3ca9; t=1775823082; bh=aKYTAnOrtDKEGtEi/In+qbq9TXaAYl881B/XMSw2ewc=; b=LJVHXfr2N8ixqA/EQWgV619u5pSkrvgcSAwnY+HGmYgk9+RoQMPDn83t9yGLTMZvAvYwUyx2g Ucl2wPSU3dQuwgIJWUsn8P+rDxicUSnkS5gFUVQbA5wPZ+Y+O2859sO4dZ0K2gMzQLR4cA1qHDi 3b19/kuSKz8KvfZZpAnPEycQ9WBY4U+Zb7g3Zp3rAzb4rV8aBETpqTfnUMGPShhM7mxSMvhYFKE Dk3mkJMjjYMvtjqv7VHLDE1NmER8G/46Hu+g5FK6aJgAuxiHnMvlK3BJ//P+crVKjp22e7F1PBN MeUOLDb7hAeAva+nmuO0JGCf/lw6UszdiuDh5cwiWncQ== X-Forward-Email-ID: 69d8e6592520a8349e4f62f7 X-Forward-Email-Sender: rfc822; jpeisach@ubuntu.com, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.6.69 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8; format=Flowed Date: Fri, 10 Apr 2026 08:00:23 -0400 Message-Id: Cc: , "SHANMUGAM, SRINIVASAN" Subject: Re: [bug report] drm/amdgpu/amdgpu_connectors: remove amdgpu_connector_free_edid From: "Joshua Peisach" To: "Dan Carpenter" , "Joshua Peisach" , "Alex Deucher" X-Mailer: aerc 0.21.0 References: In-Reply-To: X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri Apr 10, 2026 at 3:32 AM EDT, Dan Carpenter wrote: > > 1057 amdgpu_connector->use_digital =3D > --> 1058 drm_edid_is_digital(amdgpu_conne= ctor->edid); > ^^^^^^^^^^^^= ^^^^^^^^^^ > Use after free. > Lovely. I was wondering if that Claude review[1] was accurate. I also asked in IRC if it was something to be considered about but I didn't get a response[2]. I'll be more pressing next time, sorry. This morning I'm unable to test, but I think reverting the commit that removed amdgpu_connector_free_edid[3] should fix it. What do you think? Thanks again for the report. [1]: https://lore.gitlab.freedesktop.org/drm-ai-reviews/review-overall-2026= 0303211823.76631-1-jpeisach@ubuntu.com/ [2]: https://people.freedesktop.org/~cbrill/dri-log/?channel=3Dradeon&highl= ight_names=3D&date=3D2026-03-17&show_html=3Dtrue [3]: https://gitlab.freedesktop.org/agd5f/linux/-/commit/289479173fb538f3ec= 7aac5206f49e39367ee75c -Josh