Re: [PATCH v2 5/6] gpu: nova-core: skip the IFR header if present

["Alexandre Courbot" <acourbot@nvidia.com>]

On Wed Apr 15, 2026 at 8:50 AM JST, Timur Tabi wrote:
<snip>
>  impl<'a> VbiosIterator<'a> {
>      fn new(dev: &'a device::Device, bar0: &'a Bar0) -> Result<Self> {
> +        let signature = bar0.try_read32(ROM_OFFSET + NV_PBUS_IFR_FMT_FIXED0)?;
> +
> +        // The ROM may start with an Init-from-ROM (IFR) header before the PCI
> +        // Expansion ROM images. Most GPUs apply the IFR offset transparently, but
> +        // GA100 does not, so we must skip the header manually if present.
> +
> +        let current_offset = if signature == NV_PBUS_IFR_FMT_FIXED0_SIGNATURE_VALUE {
> +            let fixed1 = IfrFixed1(bar0.try_read32(ROM_OFFSET + NV_PBUS_IFR_FMT_FIXED1)?);
> +
> +            match fixed1.version() {
> +                // Note: We do not actually expect to see v1 or v2 on these GPUs
> +                1 | 2 => {
> +                    let fixed_data_size = fixed1.fixed_data_size() as usize;

Forgot this in my previous review: please use `u32_as_usize` and the
other relevant functions of nova-core's `num` module to avoid the `as`
keyword as much as possible.