Re: [PATCH] mtd: spi-nor: remove unused NO_OP_CHIP_ERASE flag

From: "Michael Walle" <mwalle@kernel.org>
To: <tkuw584924@gmail.com>, <linux-mtd@lists.infradead.org>
Cc: <tudor.ambarus@linaro.org>, <pratyush@kernel.org>,
	<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
	<Bacem.Daassi@infineon.com>,
	"Takahiro Kuwano" <Takahiro.Kuwano@infineon.com>
Subject: Re: [PATCH] mtd: spi-nor: remove unused NO_OP_CHIP_ERASE flag
Date: Thu, 16 Apr 2026 12:46:07 +0200	[thread overview]
Message-ID: <DHUIOTOESC19.117TN18W5AV86@kernel.org> (raw)
In-Reply-To: <20260416090320.21699-1-Takahiro.Kuwano@infineon.com>

[-- Attachment #1.1: Type: text/plain, Size: 1649 bytes --]

Hi,

On Thu Apr 16, 2026 at 11:03 AM CEST, tkuw584924 wrote:
> --- a/drivers/mtd/spi-nor/core.h
> +++ b/drivers/mtd/spi-nor/core.h
> @@ -124,23 +124,22 @@
>  /* Keep these in sync with the list in debugfs.c */
>  enum spi_nor_option_flags {
>  	SNOR_F_HAS_SR_TB	= BIT(0),
> -	SNOR_F_NO_OP_CHIP_ERASE	= BIT(1),

Can we just drop this line and leave the rest as is? It's already
hard to follow any development in spi-nor due to code churn. I don't
think one hole in the flags hurts. The next new flag can then just
reuse it.

-michael

> -	SNOR_F_BROKEN_RESET	= BIT(2),
> -	SNOR_F_4B_OPCODES	= BIT(3),
> -	SNOR_F_HAS_4BAIT	= BIT(4),
> -	SNOR_F_HAS_LOCK		= BIT(5),
> -	SNOR_F_HAS_16BIT_SR	= BIT(6),
> -	SNOR_F_NO_READ_CR	= BIT(7),
> -	SNOR_F_HAS_SR_TB_BIT6	= BIT(8),
> -	SNOR_F_HAS_4BIT_BP      = BIT(9),
> -	SNOR_F_HAS_SR_BP3_BIT6  = BIT(10),
> -	SNOR_F_IO_MODE_EN_VOLATILE = BIT(11),
> -	SNOR_F_SOFT_RESET	= BIT(12),
> -	SNOR_F_SWP_IS_VOLATILE	= BIT(13),
> -	SNOR_F_RWW		= BIT(14),
> -	SNOR_F_ECC		= BIT(15),
> -	SNOR_F_NO_WP		= BIT(16),
> -	SNOR_F_SWAP16		= BIT(17),
> +	SNOR_F_BROKEN_RESET	= BIT(1),
> +	SNOR_F_4B_OPCODES	= BIT(2),
> +	SNOR_F_HAS_4BAIT	= BIT(3),
> +	SNOR_F_HAS_LOCK		= BIT(4),
> +	SNOR_F_HAS_16BIT_SR	= BIT(5),
> +	SNOR_F_NO_READ_CR	= BIT(6),
> +	SNOR_F_HAS_SR_TB_BIT6	= BIT(7),
> +	SNOR_F_HAS_4BIT_BP      = BIT(8),
> +	SNOR_F_HAS_SR_BP3_BIT6  = BIT(9),
> +	SNOR_F_IO_MODE_EN_VOLATILE = BIT(10),
> +	SNOR_F_SOFT_RESET	= BIT(11),
> +	SNOR_F_SWP_IS_VOLATILE	= BIT(12),
> +	SNOR_F_RWW		= BIT(13),
> +	SNOR_F_ECC		= BIT(14),
> +	SNOR_F_NO_WP		= BIT(15),
> +	SNOR_F_SWAP16		= BIT(16),

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/