From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Maksym Pikhotskyi" <mpikhotskyi@gmail.com>,
<gregkh@linuxfoundation.org>, <error27@gmail.com>,
<ethantidmore06@gmail.com>, <starpt.official@gmail.com>,
<straube.linux@gmail.com>, <sameekshasankpal@gmail.com>,
<arthur.stupa@gmail.com>, <luka.gejak@linux.dev>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] staging: rtl8723bs: reduce nesting in rtw_security.c
Date: Fri, 17 Apr 2026 12:22:18 +0200 [thread overview]
Message-ID: <DHVCT4WZPEBI.2NJ9U6WUXMS8Y@linux.dev> (raw)
In-Reply-To: <20260417095452.23440-2-mpikhotskyi@gmail.com>
On Fri Apr 17, 2026 at 11:54 AM CEST, Maksym Pikhotskyi wrote:
> Improve readability of functions:
> rtw_tkip_encrypt, rtw_tkip_decrypt, rtw_aes_encrypt
> in rtw_security.c by adding early returns for the
> encryption type check and the stainfo null check.
>
> Signed-off-by: Maksym Pikhotskyi <mpikhotskyi@gmail.com>
> ---
> v2: rebase on staging-next. split into a series of patches.
> v3: make subject line and commit message more descriptive.
> ---
...
LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
next prev parent reply other threads:[~2026-04-17 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 9:54 [PATCH v3 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Maksym Pikhotskyi
2026-04-17 9:54 ` [PATCH v3 2/2] staging: rtl8723bs: reduce nesting in rtw_security.c Maksym Pikhotskyi
2026-04-17 10:22 ` Luka Gejak [this message]
2026-04-17 10:20 ` [PATCH v3 1/2] staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHVCT4WZPEBI.2NJ9U6WUXMS8Y@linux.dev \
--to=luka.gejak@linux.dev \
--cc=arthur.stupa@gmail.com \
--cc=error27@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mpikhotskyi@gmail.com \
--cc=sameekshasankpal@gmail.com \
--cc=starpt.official@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.