From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Robertus Diawan Chris" <robertusdchris@gmail.com>,
<gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-kernel-mentees@lists.linuxfoundation.org>,
<skhan@linuxfoundation.org>, <me@brighamcampbell.com>
Subject: Re: [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite()
Date: Mon, 20 Apr 2026 18:16:21 -0500 [thread overview]
Message-ID: <DHYD5F7V8KDQ.3TYZ4U0E8LOJQ@gmail.com> (raw)
In-Reply-To: <20260420044651.164450-1-robertusdchris@gmail.com>
On Sun Apr 19, 2026 at 11:46 PM CDT, Robertus Diawan Chris wrote:
> Commit c1314fe4d28f ("staging: rtl8723bs: remove all RT_TRACE logs
> in hal/ and os_dep/") removed the unnecessary RT_TRACE logs in hal/
> and os_dep/ files, but left the variable "offset" in the Phase 2
> _BlockWrite() function unused, so delete it.
>
> This is reported by Coverity Scan with CID 1408950 as UNUSED_VALUE.
>
> Signed-off-by: Robertus Diawan Chris <robertusdchris@gmail.com>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
next prev parent reply other threads:[~2026-04-20 23:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 4:46 [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite() Robertus Diawan Chris
2026-04-20 23:16 ` Ethan Tidmore [this message]
2026-04-21 14:33 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHYD5F7V8KDQ.3TYZ4U0E8LOJQ@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@brighamcampbell.com \
--cc=robertusdchris@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.