From: "Antonin Godard" <antonin.godard@bootlin.com>
To: "Paul Barker" <paul@pbarker.dev>,
<openembedded-core@lists.openembedded.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [OE-core] [PATCH] sbom-cve-check-common: print warnings on unpatched CVEs
Date: Tue, 21 Apr 2026 14:44:43 +0200 [thread overview]
Message-ID: <DHYUCCNDYUDR.1S88LEZPSWYY1@bootlin.com> (raw)
In-Reply-To: <9369197a4e7f2d032decc797406ecba201fe6799.camel@pbarker.dev>
Hi Paul,
On Tue Apr 21, 2026 at 1:08 PM CEST, Paul Barker wrote:
[...]
>> +SBOM_CVE_CHECK_SHOW_WARNINGS ?= "1"
>> +SBOM_CVE_CHECK_SHOW_WARNINGS[doc] = "Show warning messages when unpatched CVEs are found. \
>> +Requires the SBOM_CVE_CHECK_EXPORT_CVECHECK report type to be enabled"
>> +
>> +def show_warnings_from_file(cvecheck_export_file):
>> + import json
>> + report = {}
>
> We shouldn't need to initialise report here as it is always set if we
> get past the try block below.
Yes indeed
[...]
>
> I think this can be:
>
> show_warnings = bb.utils.to_boolean(d.getVar("SBOM_CVE_CHECK_SHOW_WARNINGS"))
And yes this works too and is slightly shorter. I'll send a v2
Thanks!
Antonin
prev parent reply other threads:[~2026-04-21 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 9:15 [PATCH] sbom-cve-check-common: print warnings on unpatched CVEs Antonin Godard
2026-04-21 11:08 ` [OE-core] " Paul Barker
2026-04-21 12:44 ` Antonin Godard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHYUCCNDYUDR.1S88LEZPSWYY1@bootlin.com \
--to=antonin.godard@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul@pbarker.dev \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.