All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Shyam Sunder Reddy Padira" <shyamsunderreddypadira@gmail.com>,
	<gregkh@linuxfoundation.org>, <ethantidmore06@gmail.com>,
	<straube.linux@gmail.com>, <dan.carpenter@linaro.org>,
	<samasth.norway.ananda@oracle.com>, <vcaron@bearstech.com>,
	<adrishbora@gmail.com>, <ofirmirovsky@gmail.com>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: os_dep: remove redundant else in rtw_dev_unload
Date: Tue, 21 Apr 2026 16:17:16 +0200	[thread overview]
Message-ID: <DHYWB7OYX3LJ.30L4BEH5YUOKM@linux.dev> (raw)
In-Reply-To: <20260418170908.16257-1-shyamsunderreddypadira@gmail.com>

On Sat Apr 18, 2026 at 7:09 PM CEST, Shyam Sunder Reddy Padira wrote:
> Remove the unnecessary else block following a break
> statment to simplify the control flow and improve
> code readability.
>
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 29939bf5a156..3207d6d2c727 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -988,12 +988,10 @@ void rtw_dev_unload(struct adapter *padapter)
>  			rtw_stop_drv_threads(padapter);
>  
>  		while (atomic_read(&pcmdpriv->cmdthd_running)) {
> -			if (cnt > 5) {
> +			if (cnt > 5)
>  				break;
> -			} else {
> -				cnt++;
> -				msleep(10);
> -			}
> +			cnt++;
> +			msleep(10);
>  		}
>  
>  		/* check the status of IPS */

LGTM.

Reviewed-by: Luka Gejak <luka.gejak@linux.dev>

Best regards,
Luka Gejak

      reply	other threads:[~2026-04-21 14:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-18 17:09 [PATCH] staging: rtl8723bs: os_dep: remove redundant else in rtw_dev_unload Shyam Sunder Reddy Padira
2026-04-21 14:17 ` Luka Gejak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHYWB7OYX3LJ.30L4BEH5YUOKM@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=adrishbora@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=ofirmirovsky@gmail.com \
    --cc=samasth.norway.ananda@oracle.com \
    --cc=shyamsunderreddypadira@gmail.com \
    --cc=straube.linux@gmail.com \
    --cc=vcaron@bearstech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.