All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christoph Schlameuss" <schlameuss@linux.ibm.com>
To: "Thomas Huth" <thuth@redhat.com>,
	"Christoph Schlameuss" <schlameuss@linux.ibm.com>,
	<kvm@vger.kernel.org>
Cc: "Janosch Frank" <frankja@linux.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andrew Jones" <andrew.jones@linux.dev>,
	"Nicholas Piggin" <npiggin@gmail.com>
Subject: Re: [kvm-unit-tests PATCH 1/3] scripts/checkpatch.pl: Add empty codespell and const_structs configs
Date: Fri, 24 Apr 2026 09:36:47 +0200	[thread overview]
Message-ID: <DI17O7XO24UY.1UTBAQJVIGSCE@linux.ibm.com> (raw)
In-Reply-To: <87e4fcbf-92bd-4f74-9db9-369e4ba8bca8@redhat.com>

On Fri Apr 24, 2026 at 9:00 AM CEST, Thomas Huth wrote:
> On 23/04/2026 16.16, Christoph Schlameuss wrote:
>> Without these files each patch is flagged with these errors providing no
>> value and swamping actually found warnings and errors:
>> 
>> ● xxxxxxxxxxxx: commit title
>>    ● checkpatch.pl: No typos will be found - file '.../kvm-unit-tests/scripts/spelling.txt': No such file or directory
>>    ● checkpatch.pl: No structs that should be const will be found - file '.../kvm-unit-tests/scripts/const_structs.checkpatch': No such file or directory
>
> Very weird, we've got the checkpatch.pl script in the tree since a while, 
> but I cannot remember having seen these warnings in the past. However, I 
> just tried to run checkpatch.pl with a patch, and I now get them, too ...
>

Maybe you did have a git setting modifying the arguments? IMO this just should
at least somewhat work OOTB.

>> diff --git a/scripts/const_structs.checkpatch b/scripts/const_structs.checkpatch
>> new file mode 100644
>> index 000000000000..e69de29bb2d1
>
> Maybe add "virtio_config_ops" to the file so that it does not look so empty?
>
> Anyway:
> Reviewed-by: Thomas Huth <thuth@redhat.com>

I agree that it does look strange completely empty. Will add virtio_config_ops.

Thanks

  reply	other threads:[~2026-04-24  7:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 14:16 [kvm-unit-tests PATCH 0/3] scripts: Configure and update tools to allow basic b4 usage Christoph Schlameuss
2026-04-23 14:16 ` [kvm-unit-tests PATCH 1/3] scripts/checkpatch.pl: Add empty codespell and const_structs configs Christoph Schlameuss
2026-04-24  7:00   ` Thomas Huth
2026-04-24  7:36     ` Christoph Schlameuss [this message]
2026-04-23 14:16 ` [kvm-unit-tests PATCH 2/3] scripts/checkpatch.pl: Copy kernel codespell file Christoph Schlameuss
2026-04-23 14:16 ` [kvm-unit-tests PATCH 3/3] scripts/get_maintainer.pl: Ignore --nogit-chief-penguins option Christoph Schlameuss
2026-04-24  7:31   ` Thomas Huth
2026-04-24  7:41     ` Christoph Schlameuss
2026-04-24  7:19 ` [kvm-unit-tests PATCH 0/3] scripts: Configure and update tools to allow basic b4 usage Thomas Huth
2026-04-24  7:42   ` Christoph Schlameuss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DI17O7XO24UY.1UTBAQJVIGSCE@linux.ibm.com \
    --to=schlameuss@linux.ibm.com \
    --cc=andrew.jones@linux.dev \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=npiggin@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.