From: "Théo Lebrun" <theo.lebrun@bootlin.com>
To: "Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>
Cc: linux-mips@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Jerome Brunet" <jbrunet@baylibre.com>
Subject: Re: [PATCH v7 3/3] reset: eyeq: drop device_set_of_node_from_dev() done by parent
Date: Wed, 29 Apr 2026 11:11:39 +0200 [thread overview]
Message-ID: <DI5ITKXOJOEE.28MZGWL8UPDOA@bootlin.com> (raw)
In-Reply-To: <177742824867.5403.11815560359227140766@localhost.localdomain>
On Wed Apr 29, 2026 at 4:04 AM CEST, Stephen Boyd wrote:
> Quoting Théo Lebrun (2026-02-25 08:55:07)
>> Our parent driver (clk-eyeq) now does the
>> device_set_of_node_from_dev(dev, dev->parent)
>> call through the newly introduced devm_auxiliary_device_create() helper.
>>
>> Doing it again in the reset-eyeq probe would be redundant.
>> Drop both the WARN_ON() and the device_set_of_node_from_dev() call.
>> Also fix the following comment that talks about "our newfound OF node".
>>
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
>> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
>> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
>> ---
>
> Applied to clk-fixes
Thanks Stephen!
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-04-29 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 16:55 [PATCH v7 0/3] clk: eyeq: instantiate generic PHY children auxiliary device Théo Lebrun
2026-02-25 16:55 ` [PATCH v7 1/3] clk: eyeq: use the auxiliary device creation helper Théo Lebrun
2026-04-29 2:03 ` Stephen Boyd
2026-02-25 16:55 ` [PATCH v7 2/3] clk: eyeq: add EyeQ5 children auxiliary device for generic PHYs Théo Lebrun
2026-04-29 2:04 ` Stephen Boyd
2026-02-25 16:55 ` [PATCH v7 3/3] reset: eyeq: drop device_set_of_node_from_dev() done by parent Théo Lebrun
2026-04-29 2:04 ` Stephen Boyd
2026-04-29 9:11 ` Théo Lebrun [this message]
2026-04-20 8:51 ` [PATCH v7 0/3] clk: eyeq: instantiate generic PHY children auxiliary device Benoît Monin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DI5ITKXOJOEE.28MZGWL8UPDOA@bootlin.com \
--to=theo.lebrun@bootlin.com \
--cc=benoit.monin@bootlin.com \
--cc=gregory.clement@bootlin.com \
--cc=jbrunet@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.