From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Cc: "Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Rob Clark" <robin.clark@oss.qualcomm.com>,
"Dmitry Baryshkov" <lumag@kernel.org>,
"Abhinav Kumar" <abhinav.kumar@linux.dev>,
"Jessica Zhang" <jesszhan0024@gmail.com>,
"Sean Paul" <sean@poorly.run>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"John Stultz" <jstultz@google.com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Michal Simek" <michal.simek@amd.com>,
"Hui Pu" <Hui.Pu@gehealthcare.com>,
"Ian Ray" <ian.ray@gehealthcare.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>,
<freedreno@lists.freedesktop.org>,
<linux-arm-kernel@lists.infradead.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v4 01/11] drm/bridge: drm_bridge_get/put(): ignore ERR_PTR
Date: Mon, 04 May 2026 16:13:32 +0200 [thread overview]
Message-ID: <DI9YDFTUBA4R.3NBES5EAMOD03@bootlin.com> (raw)
In-Reply-To: <20260504135300.GE1344263@killaraus.ideasonboard.com>
Hi Laurent,
On Mon May 4, 2026 at 3:53 PM CEST, Laurent Pinchart wrote:
> On Mon, May 04, 2026 at 12:45:04PM +0200, Luca Ceresoli wrote:
>> Most functions returning a struct drm_bridge pointer currently return a
>> valid pointer or NULL, but this restricts their ability to return an error
>> code describing the error kind.
>>
>> In preparation to have new APIs that can return a struct drm_bridge pointer
>> holding an ERR_PTR (and for those which already do) make drm_bridge_get()
>> and drm_bridge_put() ignore ERR_PTR values, just like they ignore NULL
>> pointers.
>
> The change in drm_bridge_put() looks good to me. I'm less sure about
> drm_bridge_get(), is there a valid use case to call get() on a bridge
> that is not valid ? Doesn't it indicate a clear error in the caller ?
Good point. Indeed I don't have a valid use case in mind.
I guess I can drop the drm_bridge_get() and send v5. Should there be a
valid use case it will emerge at some point and this can be rediscussed.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-05-04 14:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 10:45 [PATCH v4 00/11] drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 01/11] drm/bridge: drm_bridge_get/put(): ignore ERR_PTR Luca Ceresoli
2026-05-04 13:53 ` Laurent Pinchart
2026-05-04 14:13 ` Luca Ceresoli [this message]
2026-05-04 10:45 ` [PATCH v4 02/11] drm/bridge: add of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-04 14:55 ` Laurent Pinchart
2026-05-04 15:03 ` Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 03/11] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 04/11] drm/hisilicon/kirin: " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 05/11] drm/bridge: chrontel-ch7033: " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 06/11] drm/bridge: lontium-lt9611uxc: " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 07/11] drm/bridge: lt9611: " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 08/11] drm/bridge: adv7511: " Luca Ceresoli
2026-05-04 15:22 ` Laurent Pinchart
2026-05-04 10:45 ` [PATCH v4 09/11] drm/bridge: lt8713sx: " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 10/11] drm: zynqmp_dp: " Luca Ceresoli
2026-05-04 15:24 ` Laurent Pinchart
2026-05-05 14:05 ` Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 11/11] drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-04 15:27 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DI9YDFTUBA4R.3NBES5EAMOD03@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=Hui.Pu@gehealthcare.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=ian.ray@gehealthcare.com \
--cc=jernej.skrabec@gmail.com \
--cc=jesszhan0024@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jstultz@google.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=michal.simek@amd.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.