All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Walle" <mwalle@kernel.org>
To: "Linus Walleij" <linusw@kernel.org>,
	"Bartosz Golaszewski" <brgl@kernel.org>
Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Alex Elder" <elder@riscstar.com>
Subject: Re: [PATCH v2 1/2] gpio: regmap: Support sparsed fixed direction
Date: Mon, 11 May 2026 09:18:11 +0200	[thread overview]
Message-ID: <DIFNX8HLL7X3.JGSENU7W32X4@kernel.org> (raw)
In-Reply-To: <20260508-regmap-gpio-sparse-fixed-dir-v2-1-deee84df3027@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

Hi,

On Fri May 8, 2026 at 2:51 PM CEST, Linus Walleij wrote:
> On some regmapped GPIOs apparently only a sparser selection
> of the lines (not all) are actually fixed direction.
>
> Support this situation by adding an optional bitmap indicating
> which GPIOs are actually fixed direction and which are not.

Thanks, this patch looks good. But could we invert the logic and use
fixed_direction_mask as that feels more natural to me?

And for legacy reasons, so we don't have to change the drivers:

if (!fixed_direction_mask && fixed_direction_output)
	fixed_direction_mask = ~1

Or we just go ahead and change the two drivers. Up to you.

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

  parent reply	other threads:[~2026-05-11  7:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 12:51 [PATCH v2 0/2] Improvement spotted during patch review Linus Walleij
2026-05-08 12:51 ` [PATCH v2 1/2] gpio: regmap: Support sparsed fixed direction Linus Walleij
2026-05-08 13:03   ` Alex Elder
2026-05-10 13:31     ` Alex Elder
2026-05-11  7:18   ` Michael Walle [this message]
2026-05-11 19:00     ` Linus Walleij
2026-05-08 12:51 ` [PATCH v2 2/2] gpio: regmap: Don't set a fixed direction line Linus Walleij
2026-05-11  7:24   ` Michael Walle
2026-05-11  9:56 ` [PATCH v2 0/2] Improvement spotted during patch review Bartosz Golaszewski
2026-05-11 12:15   ` Linus Walleij
2026-05-11 12:18     ` Alex Elder
2026-05-11 12:32 ` Bartosz Golaszewski
2026-05-11 12:39   ` Michael Walle
2026-05-11 12:44     ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIFNX8HLL7X3.JGSENU7W32X4@kernel.org \
    --to=mwalle@kernel.org \
    --cc=brgl@kernel.org \
    --cc=elder@riscstar.com \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.