All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: <ljs@kernel.org>, <vbabka@kernel.org>, <Liam.Howlett@oracle.com>,
	<urezki@gmail.com>, <ojeda@kernel.org>, <boqun@kernel.org>,
	<bjorn3_gh@protonmail.com>, <lossin@kernel.org>,
	<a.hindborg@kernel.org>, <aliceryhl@google.com>,
	<tmgross@umich.edu>, <rust-for-linux@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] rust: alloc: cleanup doctest imports to "kernel vertical" style
Date: Tue, 12 May 2026 16:29:00 +0200	[thread overview]
Message-ID: <DIGRPMX66CLE.1RQYNPA5OXP97@kernel.org> (raw)
In-Reply-To: <DIGRC3P3FDOB.YA7DAMG3A8UR@garyguo.net>

On Tue May 12, 2026 at 4:11 PM CEST, Gary Guo wrote:
> On Mon May 11, 2026 at 10:41 PM BST, Danilo Krummrich wrote:
>> @@ -174,8 +174,11 @@ impl Vmalloc {
>>      /// # Examples
>>      ///
>>      /// ```
>> -    /// # use core::ptr::{NonNull, from_mut};
>> -    /// # use kernel::{page, prelude::*};
>> +    /// # use core::ptr::{
>> +    /// #     from_mut,
>> +    /// #     NonNull, //
>> +    /// # };
>
> I thought the consensus was that hidden lines don't need to use vertical import
> style.

Don't need to, but still can; I generally prefer to keep it consistent.

We can drop the - for doc-comments - unnecessary '//' though, which my muscle
memory inserted regardless. :)

  reply	other threads:[~2026-05-12 14:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 21:41 [PATCH 1/2] rust: alloc: cleanup imports and use "kernel vertical" style Danilo Krummrich
2026-05-11 21:41 ` [PATCH 2/2] rust: alloc: cleanup doctest imports to " Danilo Krummrich
2026-05-12 13:46   ` Eliot Courtney
2026-05-12 14:11   ` Gary Guo
2026-05-12 14:29     ` Danilo Krummrich [this message]
2026-05-12 13:46 ` [PATCH 1/2] rust: alloc: cleanup imports and use " Eliot Courtney
2026-05-12 14:28   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIGRPMX66CLE.1RQYNPA5OXP97@kernel.org \
    --to=dakr@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=urezki@gmail.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.