All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maxwell Doose" <m32285159@gmail.com>
To: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Maxwell Doose" <m32285159@gmail.com>
Cc: jic23@kernel.org, "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] iio: imu: kmx61: Use guard(mutex)() over manual locking
Date: Wed, 13 May 2026 09:45:12 -0500	[thread overview]
Message-ID: <DIHMOLAPN64W.1W0OU35JH5SLJ@gmail.com> (raw)
In-Reply-To: <agR4OExvzbhCNsjk@ashevche-desk.local>

On Wed May 13, 2026 at 8:10 AM CDT, Andy Shevchenko wrote:
> On Tue, May 12, 2026 at 09:06:54PM -0500, Maxwell Doose wrote:
>> Include linux/cleanup.h to take advantage of new macros.
>> 
>> Replace manual mutex_lock() and mutex_unlock() calls across the file
>> with guard(mutex)() and scoped_guard() where appropriate to simplify
>> error paths and eliminate manual locking calls.
>> 
>> Add new helper function kmx61_read_for_each_active_channel() to mitigate
>> certain style issues and to prevent notifying that the IRQ is finished
>> whilst holding the lock.
>> 
>> Update certain returns, and add default case to return -EINVAL in
>> kmx61_read_raw().
>> 
>> Remove now-redundant gotos and ret variables, as the new RAII macros
>> make them unneeded.
>
> Have you used --histogram algo when prepared patch? Please, do it, if
> not yet. It might improve the diff itself and hence makes reviewers a bit
> more happier.

I *think* I used --histogram, I'm not sure what happened :/

best regards,
max


  reply	other threads:[~2026-05-13 14:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13  2:06 [PATCH v6] iio: imu: kmx61: Use guard(mutex)() over manual locking Maxwell Doose
2026-05-13 13:10 ` Andy Shevchenko
2026-05-13 14:45   ` Maxwell Doose [this message]
2026-05-13 16:33     ` Andy Shevchenko
2026-05-16 13:01 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DIHMOLAPN64W.1W0OU35JH5SLJ@gmail.com \
    --to=m32285159@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.