From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79365CD4F49 for ; Mon, 18 May 2026 10:06:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9AD7D10E2FB; Mon, 18 May 2026 10:06:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Yv4fNDnz"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 389B010E2FB for ; Mon, 18 May 2026 10:06:25 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9E29D60125; Mon, 18 May 2026 10:06:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4467BC2BCB7; Mon, 18 May 2026 10:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779098784; bh=KEg6Hi3hlNlYZ8PLaUPxZCx0yAZdeP8lxPT8W/F/GRs=; h=Date:Cc:To:From:Subject:References:In-Reply-To:From; b=Yv4fNDnzvQTTsMICDyydMPzGN6duSaXxxOe9DkC2Wyzrtki2wSExsdPqR/ndREnlF mPhb9+tNab2n1abKKuTd6JAyc43QGmEijX+gjdFw6iqDKm/K4UvgJ5vAO9G1eYbMXd xLe6DWvYHREE9mQfifaDbqxW/Yp2bVI7DnDiBi/f/CIdNQ+4EHohNYm06j28QGJM4v 8TstbTnp43c+I61UNJE5Z1t3eCzjkpHIt2d3E9mVGCUXwTWBDt7e0K80dVpT+SpYXx ieYLVPGe6MnRjDXvjg0EkMzWee9YGjtqk9VqSBY54uaWr7Fdq2E8KxC4RF1kNwZHTP c73lR91L8tqPg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 18 May 2026 12:06:19 +0200 Message-Id: Cc: "Miguel Ojeda" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "David Airlie" , "Simona Vetter" , "Sumit Semwal" , =?utf-8?q?Christian_K=C3=B6nig?= , "Daniel Almeida" , , To: "Alvin Sun" From: "Danilo Krummrich" Subject: Re: [PATCH 08/13] rust: drm/gem: add GEM object query helpers for debugfs References: <20260326-b4-tyr-debugfs-v1-0-074badd18716@linux.dev> <20260326-b4-tyr-debugfs-v1-8-074badd18716@linux.dev> <9839e1fc-faa2-4e98-9f46-b6449bf0f35a@linux.dev> In-Reply-To: <9839e1fc-faa2-4e98-9f46-b6449bf0f35a@linux.dev> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon May 18, 2026 at 9:39 AM CEST, Alvin Sun wrote: > A generic Debug impl for GemObject? Other drivers like Nova might need=20 > different > output in a different style. Why is any of Tyr or Nova special here? There's already a lot of common debugfs code in DRM [1] (which is per DRM device), including some GEM info. If that is not enough, why can't we extend it / add another entry? > How about a dedicated debugfs data structure for GEM Object instead? Say,= a > get_debugfs_info() method that handles synchronization internally and avo= ids > exposing unnecessary interfaces? It would need to be guarded with a debugfs config, otherwise we'd still exp= ose information a driver should never touch directly, which can easily become a= bit messy. But again, why do we expect any of those drivers to be special? I think thi= s can just be common code. [1] https://elixir.bootlin.com/linux/v7.0.8/source/drivers/gpu/drm/drm_debu= gfs.c