From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1618FCD343F for ; Mon, 18 May 2026 20:31:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TIAw+MKS3ATpToEtxobOVj+40qGUbskQMhM97B23m9k=; b=OtJDDuxCzzyHhY YTPWA7ivXU1kuUHStb6BG0mAYFv2c+pH6M2keWtiyZ9a4wQrbnFeG3WNMrVYnFCC6OQlyMSqCVPyA pUjOI9ijzkF++pql3mCANzYgn9MMLKhX4SESfMgNvz7KIf6lc+ErEUqIkME5X/OXLQZ9NrQws8YoY CC/gmrO1y4ZVOSKrfS942mhsK78LX/ZHvFlDI0F1OXORP2IyhJJA+1l9uJyP7IJWeLmqBB+JSrNFs PFYRGpiSM1I2CUsAThlwSRMz3FBavuyTHoUymA6sTIzPIi7vfGUucZCmoGGJ3ONePilXTtBIrCSjQ qmUZWIRWDoLQeoU3IQdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wP4c0-0000000GtYA-2Ape; Mon, 18 May 2026 20:30:52 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wP4by-0000000GtXR-13qO for linux-riscv@lists.infradead.org; Mon, 18 May 2026 20:30:51 +0000 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-38eab6cf7d8so21991401fa.1 for ; Mon, 18 May 2026 13:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779136247; x=1779741047; darn=lists.infradead.org; h=in-reply-to:references:user-agent:to:from:subject:cc:message-id :date:content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=P3VrP2DxIv6LPTx8GCJD3YcqwFHoOIh8jqWRtmtbvYw=; b=hKMva8OleS42mkgbHhy2u/1eA+UzzFV1qlmWUX9+GXY32fHWMIui0HpDJmubQIvasH tl5rSU6PVKHaQ0goZ/FETBO+OASlURtcZdOvLHYbleH9rOxZpraK9pq6u9mbEXcZvE+t 3/qkqw/ksDkRTfKndDlFkM63QyWB1zDG9jT29F78pfaSxLpjjZPZwjb9KdSKWPUvLQjl j0EpVmZ8KQqL0kzWNbKOj9TJwv9VY5155qeWDqFlTVUVPp+M9cQoBcNTD2Urj1g6fmhs 4BUfIBQ3IUA3t7sbIhzW5ho4gtHnR/DE0PgCAg0KYVjgHZMfTLoj80ak6336yYdQf9cr aWqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779136247; x=1779741047; h=in-reply-to:references:user-agent:to:from:subject:cc:message-id :date:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P3VrP2DxIv6LPTx8GCJD3YcqwFHoOIh8jqWRtmtbvYw=; b=K3+zeLl7zBTkQgvEo8rysgxv7o2JWyeum7pd64lev2RijbNS9drIuHH2IgDES373eR u+ogvQOISMaf69LEY5jrlcEkV9dI/Bxvoz6XsjivoRDJDOuy0iL2heknXDDn4VhM0kDM QBaa3m26ZcBpVP3lzQnX0qFAsmfW4QuXZD8dHUTCy+mpXrdJwaHD5wcQJ1xLR6b+EK1H FS9iYrHNFr7ytqQJHLWA1wWgeMVCVDCuSpXRkQI8bSQSkbKXgU4EuZlWt3eeYSY4zHZt XmFVlJdwr00p7fka9IAbJ0CjU0F6+TxGoF3KczViDJyEjhsvFOyQNW/HYQRzZEegp+P1 qKBw== X-Forwarded-Encrypted: i=1; AFNElJ9EwSeonvvGdKYeIW1kfFHzJg4OTWTdl7nwsIW2icY3i+4pvUXsuxUVdcIhCnF+rh0BOCVh6yKhTxm18Q==@lists.infradead.org X-Gm-Message-State: AOJu0Yy8OH+1euBbPGroMpZ2UmLI0ocYMd18XH8pMuL8NyWq0cpdUplj OcvthV/l4AxvfdpDvQ4npA87xCgPFEGX0Oh8XRvIj0iGl2AdvDtB9JhW X-Gm-Gg: Acq92OE6KuGCbA1ZPrPNMggD3WPxQBPH+pvDsQ99UOkD50qudpJ7aM163GFz9jyatzd hC/BUode7A7Em/GaOiwK025eAWvCpWNzXgYlRPBbvGx5oSzDsl1Dy6MdKlxqaW6RVcdl2zikxVC 8rXcsohAgEf2vs+E5eUtynV5YYtCllWcbVRPjwktI/GE9neRoC6ByHTT7Pm6g+O8UXQ5t5+1nCk bc6cLGtyrMSt0Dq51CagCgeCsu7Ocb+25KhudTGA8KZ7HZ2QSVCq2BvtzHSheH6pk41nYGwVY4V o6LZlXO5O+Wvh8It2yUAs4I37E2D/RwMtQNR8W2qXPADDAIsgGpt4jnFRg4QbNcGCG+xPHiITTY 10mgzBLzlO5mC6cL4Yrtdgd/xaDB8cnEA+1pIculj7P4mIRiAPYRnpTT8VehOrcPZu5nkmNRovS ztuqvJjzosDW+vtj49qwCEMA== X-Received: by 2002:a05:651c:198f:b0:395:940a:d84b with SMTP id 38308e7fff4ca-395940ae415mr19226801fa.3.1779136247215; Mon, 18 May 2026 13:30:47 -0700 (PDT) Received: from localhost ([178.205.236.109]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-395887dfbbfsm14243301fa.40.2026.05.18.13.30.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 13:30:46 -0700 (PDT) Mime-Version: 1.0 Date: Mon, 18 May 2026 23:37:39 +0300 Message-Id: Cc: "Albert Ou" , "Alexandre Ghiti" , "Chunyan Zhang" , "Matthew Bystrin" , "Palmer Dabbelt" , "Paul Walmsley" , "Samuel Holland" Subject: Re: [PATCH v2] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe() From: "Matthew Bystrin" To: "Jiakai Xu" , , User-Agent: aerc/0.21.0-0-g5549850facc2 References: <20260517143704.659416-1-xujiakai2025@iscas.ac.cn> In-Reply-To: <20260517143704.659416-1-xujiakai2025@iscas.ac.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260518_133050_301503_7C67A965 X-CRM114-Status: GOOD ( 10.40 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi! > @@ -68,19 +68,24 @@ void notrace walk_stackframe(struct task_struct *task, struct pt_regs *regs, > pc = task->thread.ra; > } > > + if (!task) > + task = current; > + > + high = (unsigned long)task_pt_regs(task); After noticing end_of_stack() function I'm not sure task_pt_regs() is the best candidate for the boundary. Let's see what maintainers are going to say. > + > for (;;) { > struct stackframe *frame; > > if (unlikely(!__kernel_text_address(pc) || (level++ >= 0 && !fn(arg, pc)))) > break; > > - if (unlikely(!fp_is_valid(fp, sp))) > + if (unlikely(!fp_is_valid(fp, sp, high))) > break; > > /* Unwind stack frame */ > frame = (struct stackframe *)fp - 1; > sp = fp; > - if (regs && (regs->epc == pc) && fp_is_valid(frame->ra, sp)) { > + if (regs && (regs->epc == pc) && fp_is_valid(frame->ra, sp, high)) { > /* We hit function where ra is not saved on the stack */ > fp = frame->ra; > pc = regs->ra; > -- > 2.34.1 All in all looks fine. Reviewed-by: Matthew Bystrin -- Best regards Matt _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66C9E1EF39E for ; Mon, 18 May 2026 20:30:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779136250; cv=none; b=N2iCpmBlvuBjyoJlD/JZXI1M+rxG2V6Eb+EYR3A14voXbnqyiqgoXyv/j/8AvE/kZpWIfJ32wIVbC36Tf5SHxsiWZa4JiO/Bwz3Y4sAFppSfqlwZ9fVVzTB5OkBJ1oCsywuUm9I1Z3g6uVVWsAC7mvgAE3I1VcgN0KaygBCeWcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779136250; c=relaxed/simple; bh=Bgh2kH9CNf57bsJP1VWxRj/kQtBg4sgA850x1yGs8EE=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=tiUkbX4r4ZK9VD7E8iVTf66CzwUIxWHG/L/CUbzSW3S/ckHngBPAf7NUggIgRGwd8/9tHBk6VtV4jzHr20/KZ6APdfSfxmlanvBBCa4T4aPXS2HBPSpiB3f4x/Mq7Ss0YjeGmXZdn3injffufiJ16Ul6RG5/eKrF97uAt/GYMGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ddNO1dHa; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ddNO1dHa" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-38eab6cf7d8so21991391fa.1 for ; Mon, 18 May 2026 13:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779136247; x=1779741047; darn=vger.kernel.org; h=in-reply-to:references:user-agent:to:from:subject:cc:message-id :date:content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=P3VrP2DxIv6LPTx8GCJD3YcqwFHoOIh8jqWRtmtbvYw=; b=ddNO1dHaIboxE8NX7u3rrGa6dSAU4xl2A6BwhCHRtvcluYtBj7VMIZxhp/zd1ZzmEW rRVCYWCbWicdf+oBSMeyQaGJSHBWM0ci31JbLS3wgyhEbJPLqLCLVmU+zB0obNh7W2TN Z8ejjasjBorsoCCEFdblSry2DSLOWir5ZpI7MdksrAUWKNsS/d7K/qhz3n0UICOOSNKt dAUwkS8RmUPJLzl398yUNwHaRRptIVeSx3JbArajkmDAJjwb6hIs8G0FzzvaszG7kW3m Ko6e1dYJHBakkcc8guJc1zH+TKNMJmFKMqvdW/kg8BrAJuC9L2wBeWwxenjVDs0nfxbr 63Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779136247; x=1779741047; h=in-reply-to:references:user-agent:to:from:subject:cc:message-id :date:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P3VrP2DxIv6LPTx8GCJD3YcqwFHoOIh8jqWRtmtbvYw=; b=aOWs05HOrtJJ3mFTJjO3TaCyGZ7VbjxbmE3psBgl7wytOb9aQOAprZrecEheWb5NOS 2lsr7rmg3qgk8iWH1qIx5C1XT65doIIT60NJyTpV5euukhXW/DY+LLjX5KR1HWTiARvb UA/6YWzA0Q+b32HD4R5YbEHiLX0428nhTBnXgZ4ne+xXWFifqG+yBDUD1Wu1b0PI5V8B OG/bQQLk3HYmh+7uz8fQspyoEZ3XTRPXb5KMU/g329sEmqMFOw6lmSStfecme/HLhBid AlYsVWBOip4yBvGcEWx/TYTBiaI/kOugcsWHxk0osiTHVOqNFW+0f6Y+2O4LMpyN8FJC XvVg== X-Forwarded-Encrypted: i=1; AFNElJ8lhBHmRg35uZbESLriZjXJ4s/Ymcw3LZF2s2e+UeONJjSCeqJUNI9xkc7BYmAyLJakwwDVquLbWcLSHU0=@vger.kernel.org X-Gm-Message-State: AOJu0YyANkbwyPwklC/mDYiobinlERd2ia2dtF7KPSrwmzPayOH5+q0W 48bLN2i+do3oPZS8uqAKYZHVJgXTAuJCmbGPvoBGcQYMkbt3mOsgnsCm X-Gm-Gg: Acq92OGay5Yvy8PXzTtwMjs3TzKEztX/ApanKHtuwEhvmPWmAs4Sp7b+csSWrVDMl6d hZMPbrXErNedRjG+ZpdZjxCnPxtmKmQoIHa50vVPL33/MeDQR7jaqtdQFpOLaB+Kigl+eXMdmVs GdkKkY8rF2/WDiGtXtM5dh9qi/667/oPnvZQLmBKAxzZrzmrD+WVrUSqOtfE1bMEl/yY0yLLyXj s1gdXjHxKWkzApYrozTgeF47ajhPdag52wlL7kR3rTiNwrpv+Ind9OntrleOfmWAeASvCsRQ4Xy U771zacHZ7JMQQ36jXG7nF9Dy/uzPQU4w6KIjq4cfFlDSN0OyxKZ83PE2RscJDnBi2Zn8vy0+Xj 1rmlMD/uTRtouYPJkMRp6VwGnPfGYxoPVYhbwGlWZYVgS/UVIy7Pfp9H9+1viYrQOzUQ8BmD/IC QIfdVZunGEfSu/dlcO9Jo/TA== X-Received: by 2002:a05:651c:198f:b0:395:940a:d84b with SMTP id 38308e7fff4ca-395940ae415mr19226801fa.3.1779136247215; Mon, 18 May 2026 13:30:47 -0700 (PDT) Received: from localhost ([178.205.236.109]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-395887dfbbfsm14243301fa.40.2026.05.18.13.30.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 13:30:46 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 18 May 2026 23:37:39 +0300 Message-Id: Cc: "Albert Ou" , "Alexandre Ghiti" , "Chunyan Zhang" , "Matthew Bystrin" , "Palmer Dabbelt" , "Paul Walmsley" , "Samuel Holland" Subject: Re: [PATCH v2] riscv: stacktrace: fix stack-out-of-bounds in walk_stackframe() From: "Matthew Bystrin" To: "Jiakai Xu" , , User-Agent: aerc/0.21.0-0-g5549850facc2 References: <20260517143704.659416-1-xujiakai2025@iscas.ac.cn> In-Reply-To: <20260517143704.659416-1-xujiakai2025@iscas.ac.cn> Hi! > @@ -68,19 +68,24 @@ void notrace walk_stackframe(struct task_struct *task= , struct pt_regs *regs, > pc =3D task->thread.ra; > } > =20 > + if (!task) > + task =3D current; > + > + high =3D (unsigned long)task_pt_regs(task); After noticing end_of_stack() function I'm not sure task_pt_regs() is the b= est candidate for the boundary. Let's see what maintainers are going to say. > + > for (;;) { > struct stackframe *frame; > =20 > if (unlikely(!__kernel_text_address(pc) || (level++ >=3D 0 && !fn(arg,= pc)))) > break; > =20 > - if (unlikely(!fp_is_valid(fp, sp))) > + if (unlikely(!fp_is_valid(fp, sp, high))) > break; > =20 > /* Unwind stack frame */ > frame =3D (struct stackframe *)fp - 1; > sp =3D fp; > - if (regs && (regs->epc =3D=3D pc) && fp_is_valid(frame->ra, sp)) { > + if (regs && (regs->epc =3D=3D pc) && fp_is_valid(frame->ra, sp, high))= { > /* We hit function where ra is not saved on the stack */ > fp =3D frame->ra; > pc =3D regs->ra; > --=20 > 2.34.1 All in all looks fine. Reviewed-by: Matthew Bystrin --=20 Best regards Matt