Re: [PATCH dpdk v5 2/5] net: support multiple stacked VLAN tags

["Robin Jarry" <rjarry@redhat.com>]

Kevin Traynor, May 21, 2026 at 15:38:
>>  	} else if ((proto == rte_cpu_to_be_16(RTE_ETHER_TYPE_MPLS)) ||
>>  		(proto == rte_cpu_to_be_16(RTE_ETHER_TYPE_MPLSM))) {
>
> David's code snipped earlier in the thread suggested that this should be
> change from an 'else if' to an 'if'. It seems to make sense to have it
> as an 'if', not sure if it was deliberate to remove. Though it might not
> be really part of this patch.
>
> -       } else if ((proto == rte_cpu_to_be_16(RTE_ETHER_TYPE_MPLS)) ||
> +       if ((proto == rte_cpu_to_be_16(RTE_ETHER_TYPE_MPLS)) ||
>                 (proto == rte_cpu_to_be_16(RTE_ETHER_TYPE_MPLSM))) {
>                 unsigned int i;

Yes, I deliberately kept this as it was. I can add another patch to
change to a simple if. It makes sense to support MPLS in VLAN.


-- 
Robin

> Place stamp here.