From: "Joshua Peisach" <jpeisach@ubuntu.com>
To: "Sasha Finkelstein" <k@chaosmail.tech>,
"Joshua Peisach" <jpeisach@ubuntu.com>
Cc: "Sven Peter" <sven@kernel.org>, "Janne Grunau" <j@jannau.net>,
"Neal Gompa" <neal@gompa.dev>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>, <linux-kernel@vger.kernel.org>,
<asahi@lists.linux.dev>, <linux-arm-kernel@lists.infradead.org>,
<linux-bluetooth@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v3] Bluetooth: Add Broadcom channel priority commands
Date: Mon, 25 May 2026 10:07:50 -0400 [thread overview]
Message-ID: <DIRTEIGVL56X.1W49YU67DXNUQ@ubuntu.com> (raw)
In-Reply-To: <172D11E7-AF98-43F8-B41B-907738749EA5@chaosmail.tech>
On Mon May 25, 2026 at 10:05 AM EDT, Sasha Finkelstein wrote:
>
>> On May 25, 2026, at 15:58, Joshua Peisach <jpeisach@ubuntu.com> wrote:
>>
>> On Mon May 25, 2026 at 8:11 AM EDT, Sasha Finkelstein wrote:
>>>
>>> + cmd.enable = !!enable;
>>> +
>>
>> Probably a dumb question, but worth asking - what is the purpose of the
>> "!!"? Wouldn't just passing "enable" be sufficient?
>
> This is a way to enforce that the value is exactly 0 or 1, not 0 or non-zero.
>
>>
>> Also, currently, cmd.enable seems to just be set and used in the case
>> of boolean conditions. Would it make sense for the enable field in
>> brcm_prio_cmd to be a bool or does it not really matter?
>>
> Opposite, actually, this struct is fed to firmware, and it needs to be
> specifically a u8.
Got it, thanks!
Reviewed-by: Joshua Peisach <jpeisach@ubuntu.com>
next prev parent reply other threads:[~2026-05-25 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 12:11 [PATCH v3] Bluetooth: Add Broadcom channel priority commands Sasha Finkelstein
2026-05-25 13:58 ` Joshua Peisach
2026-05-25 14:05 ` Sasha Finkelstein
2026-05-25 14:07 ` Joshua Peisach [this message]
2026-05-25 14:29 ` [v3] " bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIRTEIGVL56X.1W49YU67DXNUQ@ubuntu.com \
--to=jpeisach@ubuntu.com \
--cc=asahi@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=j@jannau.net \
--cc=k@chaosmail.tech \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=neal@gompa.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.