From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0839337B015 for ; Mon, 25 May 2026 18:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779734636; cv=none; b=u0hbn06hBTulbT7EBNY6iOPXWmAV98phfDOLeva5A16q7W9izZdy8cTcl36bGThET1dEseyffreNoqSe4rZeQaIriPas6xclnpyx2FmZpcbrQZXhgo9kSt3R2SP5k2nXcvzl51ghNAM5jylI9BJIFS7gJirKTQSZtniXOCMnV/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779734636; c=relaxed/simple; bh=CmOsHB+Uhl8sdbsASRmJ9jCtM9XOokFcRY6XkIyBLoA=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Oidubj95h9Wc0NoB9/aFZ9Dch/p7uy/87Vd6j/mbGx7AjkXUXBEyPNxWkbqLgnnuM+awNttYZar/NeSIr7mE3/IbeIMi94lZ7tPrKsfX8FIKYSeOVrEYcMC/l6xosp0yXgWuAxj9XxEsLIsslKCByl6EE36zWODEF+lzCvTikhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b=a4aTIHj8; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b="a4aTIHj8" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-13621cca8f5so8031178c88.0 for ; Mon, 25 May 2026 11:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20251104.gappssmtp.com; s=20251104; t=1779734634; x=1780339434; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=k/y1qPVvuavN8CW2BepK2QlkOZVNFSQ8VUsqMX7hC/M=; b=a4aTIHj8SFFLp7pb21cHxs3Ob3TIihbRQ7eAc8OPM7fTZHRBFpnftxAIMG8v51iexe QYWZ3hAP964W7fPiG/S0oSL8fZdNpaHt0FOjbX1gvgzvMdbDoMaUwsBazAbBkTIqCkz5 OhLpL8zN1Iygw9O6EbQlVXD0FPBYhinThPNMHMqZNMovIlHnyBXqLZ+AXGJtCNXR2ddL 55OD2syFWE9JZqaNwT6RnBCXIjJOpPkEBN/9HHdJffUQIeHCJADQfftGhTWgmHh6zp5V Y6ETRP3lEvZRRby2lZ5m6Low40fdM+yTx2nFxkuJdpiwSSxddgN3qEkAWYojTO6Mky4b iCbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779734634; x=1780339434; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=k/y1qPVvuavN8CW2BepK2QlkOZVNFSQ8VUsqMX7hC/M=; b=Tn4h0Q7Mel40oIKabeyGPJB1pdqr0ALgAb90quhTE+ezOFZ0FSoKaOswylTzH0+lrM m3zisvPfGyJjRuLDW1Ry04eptIPzGR3pP7xhNJYRuo5OP5Ck7JEWAQePzVMTMVgJZbq1 6NJefIAEsuZZfxuk0HYTxRKq3p/9gimWFHdQJPGUCXQBkDgGEk0xDSJZ5f8cPVIS3LmF /eP+WOJw7cWuSBDxZcetPwObpW5+qrhyD1jbAgfpwK54p+Q/DU7nvGFeyvOlXoqD1m9p unEmnCBLGw5QTo0HcY8ZUaBqS3cUtryqgt2b0y4NKbt/7ERlxAs62yhBCGeJ9J035Hfq 9CEg== X-Forwarded-Encrypted: i=1; AFNElJ9SBBnlNNU2LElnuB+Nr/XpbLoUPTY3Gwbw7cSpkF3oUnfVTuv4aihfoN0syYzZImdQHCvg5lsOZ4vm/H8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxbv5/mguL9P6pJWnoXWLwyQWYW2D6sgQmoTLxlMJd8/j2Jf2zH eWWbOuF049fkM3z9VujZHdu6BmX0x9tC0dD8y+cteba9xz/UhN0oo//4Y/nUWtg0NNE= X-Gm-Gg: Acq92OEHJJJjLlBUhiikFGRxs4p/CqofbdFUPytHYwOrGzFvsS78inIyrHkHaKOJcZI VEGT/ghDxwAi/hAHLKeLAlXr1w06pjQOKHsLpaNQxj833/Sa4Ks3F/CvisCXOYE2/8ZnhSlejBC L8PyMZ1A1m/NmHhcFUC8F2/dOMPS/SKigC/SGGcesTwIp4SJFoavTG/Da/GT4cH6Kb5OGSqHATD TKKU7ZWXVuXuPeQeskDcgMXS+3FMoqGC+SmII2rmCdfC+j1ZQ4s4WbYSy99vVxwsKAxgqt251fO 5Aa9hD4ZY7fvehtp9aEqxLbz0wRrHlPXeKgwhF2kUuidJ03WogWKMw1mYQa7JKY5ydjmSKCWZ6V OmS/3m8KWKOX8pcw6VmD2GxGkyCeVapd6S3kXu8+2nq/isZH59aHIjgj5Ip1JqnMeWBjnKf0hBH QMPC+W+oWhS7kRKFI= X-Received: by 2002:a05:7022:258a:b0:12d:de3e:cc00 with SMTP id a92af1059eb24-1365fd7ad0fmr5429546c88.39.1779734634050; Mon, 25 May 2026 11:43:54 -0700 (PDT) Received: from localhost ([2620:10d:c090:600::ef08]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1366a2e672asm8165970c88.3.2026.05.25.11.43.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 11:43:53 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 25 May 2026 14:43:51 -0400 Message-Id: Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Eduard Zingerman" , "Kumar Kartikeya Dwivedi" , "Yonghong Song" , "Stanislav Fomichev" , "Matt Bobrowski" , "Quan Sun" <2022090917019@std.uestc.edu.cn> Subject: Re: [PATCH bpf 2/2] selftests/bpf: Add return value tests for lsm cgroup From: "Emil Tsalapatis" To: "Xu Kuohai" , , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260523085806.417723-1-xukuohai@huaweicloud.com> <20260523085806.417723-3-xukuohai@huaweicloud.com> In-Reply-To: <20260523085806.417723-3-xukuohai@huaweicloud.com> On Sat May 23, 2026 at 4:58 AM EDT, Xu Kuohai wrote: > From: Xu Kuohai > > Add tests to check return values set by bpf_set_retval() helper for lsm > cgroup programs. After fixing the task_struct arg feel free to add: Reviewed-by: Emil Tsalapatis Nit: The test messages are kinda obscure, could you replace -4095~0 with "v= alid errno or success" or something similar? E.g., test1/2/3/4 could be described as "success"/"valid errno"/"invalid errno"/invalid value" instead of numbers. > > Signed-off-by: Xu Kuohai > --- > .../selftests/bpf/progs/verifier_lsm.c | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/tools/testing/selftests/bpf/progs/verifier_lsm.c b/tools/tes= ting/selftests/bpf/progs/verifier_lsm.c > index 38e8e9176862..2072671ed643 100644 > --- a/tools/testing/selftests/bpf/progs/verifier_lsm.c > +++ b/tools/testing/selftests/bpf/progs/verifier_lsm.c > @@ -188,4 +188,49 @@ int BPF_PROG(null_check, struct file *file) > return 0; > } > =20 > +SEC("lsm_cgroup/socket_create") > +__description("lsm_cgroup with -4095~0 retval test 1") > +__success > +int BPF_PROG(lsm_cgroup_set_retval_zero_valid, struct task_struct *task) > +{ > + bpf_set_retval(0); > + return 0; > +} > + > +SEC("lsm_cgroup/socket_create") > +__description("lsm_cgroup with -4095~0 retval test 2") > +__success > +int BPF_PROG(lsm_cgroup_set_retval_negative_valid, struct task_struct *t= ask) > +{ > + bpf_set_retval(-12); > + return 0; > +} > + > +SEC("lsm_cgroup/socket_create") > +__description("lsm_cgroup with -4095~0 retval test 3") > +__failure __msg("should have been in [-4095, 0]") > +int BPF_PROG(lsm_cgroup_set_retval_negative_invalid, struct task_struct = *task) > +{ > + bpf_set_retval(-4096); > + return 0; > +} > + > +SEC("lsm_cgroup/socket_create") > +__description("lsm_cgroup with -4095~0 retval test 4") > +__failure __msg("should have been in [-4095, 0]") > +int BPF_PROG(lsm_cgroup_set_retval_positive_invalid, struct task_struct = *task) > +{ > + bpf_set_retval(1); > + return 0; > +} > + > +SEC("lsm_cgroup/file_release") > +__description("lsm_cgroup bpf_set_retval on void hook test") > +__failure __msg("BPF_LSM_CGROUP that attach to void LSM hooks can't modi= fy return value") > +int BPF_PROG(lsm_cgroup_set_retval_for_void_hook, struct file *file) > +{ > + bpf_set_retval(0); > + return 0; > +} > + > char _license[] SEC("license") =3D "GPL";