From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 028DD3B9D86 for ; Wed, 27 May 2026 12:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779885640; cv=none; b=ecjkvofhk8q4gx75do34y5841/bURxAtKYfcMbfpWuGpUlimiS5VEzUOTlEESIg1DX7TJ8uYZfxyD8/Kn6yHbOMDiHwp35xRyPmpIiu4dexBgA2vE1ROHY2fpnuXssyKNQvq+X8Y+55YEbZvOw83/RqInsAgXYMua8lNb4+Yvkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779885640; c=relaxed/simple; bh=3sdloD+XAr2MdGyLGRjoiwcZNYCQE5KuJKQ6JvZOQII=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=eNx2qvYkIJtzbeys6oGerTD84GzZ1M3kPnXu87LuIuaYhmCtUTAUX8ytcmbnxqfeEXxSy1UqBUEtEFJFW0E+i33ZCTI2bZ5glATBwvvJtQ/0ddFc/IRv6B1dY2IHOQP6wNjC/Da3wkSY0wL6YYNU/hoH5aDPBxayZs9fXXgdmSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fh3Sg8Tg; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fh3Sg8Tg" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779885637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l04LYP2LMlJOoBKELjJozQ+Fid2YyUQoKe7a4VJIeqs=; b=fh3Sg8TgCogpIEuXIL80i4IomqPGv/zr7lHw0XrnCGWZoi88EAx0zPmMEw7b6WpLr99eg+ pMtknznppdTydoKydEHnIU8ViyZV2R9caaVOYCAxdYcgf7TXZeRI+Anb1Mmb8ngmEOUqKb 8ItdwtaSstQauNvQk9GVHiXsgkvkLmA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 27 May 2026 12:40:34 +0000 Message-Id: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Brendan Jackman" To: "Brendan Jackman" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , , "H. Peter Anvin" , "Andy Lutomirski" , "Peter Zijlstra" , "Thomas Gleixner" Cc: Subject: Re: [PATCH v2 0/3] x86/mm: some cleanups for pagetable setup code References: <20260503-x86-init-cleanup-v2-0-bb690bd2477c@google.com> In-Reply-To: <20260503-x86-init-cleanup-v2-0-bb690bd2477c@google.com> X-Migadu-Flow: FLOW_OUT Hi folks, Can someone take a look at this? Sashiko claims to have pointed out some pre-existing issues [0]: - No synchronisation for pfn_mapped. Maybe this could be fixed by spraying some get_online_mems() or something? Fixing this individual bug in isolation seems a bit pointless though, whenever I look into data structures that get modified during hotplug I get the feeling the synchronisation needs a pretty wide overhaul. Maybe someone else feels differently... - Points out that phys_p4d_init() operates on a single P4D table but doesn't seem to check that the addresses it's operating on are within a single PGD. I'm pretty sure I noticed this before but assumed it was impossible for the range to span multiple PGDs here. But now I look more carefully I see that's not true and I think Sashiko is right here. It also points out that the paddr >=3D paddr_end check looks unreachable, which sounds plausible but I haven't thought it through properly. Happy to fix the latter as an additional patch but I think the rest of this is ready for review regardless. [0]: https://sashiko.dev/#/patchset/20260503-x86-init-cleanup-v2-0-bb690bd2= 477c%40google.com Cheers, Brendan