From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88C053BB126 for ; Tue, 2 Jun 2026 09:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780392410; cv=none; b=TEZwlDmxyA2UTN1enzc2hvc1tf+bRWEXYeMSWfjrEYL67XGeyIj9MXRFeJLpxjZxjDXjOUYhheJHfnT+/exyuebyIVZLtRQaR8Ze8w2C5OzBkiCwp1tDxoyyTdD/nHdJ045PlzYLmjJzvxqqEK8GZWuC2G2k0uLISOC4RL6Nrig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780392410; c=relaxed/simple; bh=UVCp6ynN/3KMjR+ySfgt5V2WPDJAnR6Bevewc+4Bwwk=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=OnfvivWK5pKKwSJGMqB4GFhsPSK2lGOw6Q/f8G1jjBU1JoMTZj2vdR6MQyTt91JSjXWOhuIvU+7ocD8FHwZhHqr2EI9LdXR4eC+ez8PV4DLEZ8/dX8Bxy4u62jiC3iv9vPzX83556LQNfP2nvA+RmFbrokMflBgu8WS7D1OqUPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JOZeYgcx; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JOZeYgcx" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-9154ca1aa1dso299259385a.0 for ; Tue, 02 Jun 2026 02:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780392408; x=1780997208; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Md4hiUePTg+5wfFpWCPNi1KpT4E53tO51pMj7M2RLpo=; b=JOZeYgcxBCKoFoMoZjtiTClkH5+rfeRiKosgaP7N2QQogRbTuAcnE/12+5qt5CCY9Y YarCenbTVK7iIp0ebzhwL1CLcTe5BAsLQpbMHRmdz+1tdavk8LKFGn8BaxHYYkyM5Vmz gWDQExSV5YnI+MaUhPzbNRwmC6VrmK7p32W0VIu3jITUNnjpoJzmEdtanjOd4r1nN7yI 8P3EBqdbxCMAJpJXFTPRkzOmfSSPipTYyoH0YKRlij4pt/408a6xnUG+k6txODUpnB1S vVf6g+7DRkeNF54SZfXwkK2tjkLmnWJv8j2/OaeRq8vKjIFYvnH3y2R5CwWJk4qJk/CS mrpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780392408; x=1780997208; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Md4hiUePTg+5wfFpWCPNi1KpT4E53tO51pMj7M2RLpo=; b=a4pCREKEiF3rqagULmfx9xUlB/pLG+YFkZhA6ruIuvGIw39TD+ttYJG8AqfSjU37IO KO+ccVEyM9+1MpOX3t6vwlqzq46S1DJx7m0vQWhIDJMwAJK/Mkp6N+lF50yNPSM130kj elEZNpBlZpU9Hj188kUIitwE4idiNqUkw9clmYMj/2ddnTm6fabEyPgCcRPPbRqCxzkW TEUrKksU+ampAToAreDV+M80hOe9Am7S9XKKwhLdsQUlfePcLKfPipcB/g/0V9UBrvXs pZlTuu1IK8w5RT3l7hNSQaGzgRtU9i/q8lN7HC4XGyf5UeLo351R/xI/g+UjcQLDxudJ PX7A== X-Forwarded-Encrypted: i=1; AFNElJ8zEF5rAGnwVYVaUlbS/P7ihKkR+ruapeYlDcqt2Mw3vrV6KWzsjJyKYKcVR8eaApskCEmlS6MFxsyJO+8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9YYk8vULrj0jx2PjjSor58CKuZi2Z22yg8G0E7TlE5+R1s8p6 OvY14ISlTBL3EcMZTW9UUjdWp3fq1IN4g7UnW/ecd9bDmOeiGkEaMRVUyp2q8MVR X-Gm-Gg: Acq92OFRhz4PFciX2uIeQYQwEHWslb390y0JctF2P5qrbYOHRzS20SwpKxCfa/lO4A3 uAFYDmsIz+5erCj53YG3HKTf1hyn9FLwcpf3QnYj9NT1j0xtHXbBXqzl+/p5aSQYYaApfhNywHE ctqsOGeKsyqs16eGbvLvx9qlcoDaoQ7SnNUtvnlTSwBJp9zt9lemQjYPpTdbRH2CXDctvCsF/KM MVx6mlrxRadAhJKXwH1eNwdVi1srMB1cDrzK1gCnf/gpXpwpMHfZWYx1NYYArjzgHbgSBCD5wQU 1TUuqX6I+WdBK2bwIrviDdnAzAbkIY5i9zuKUsB34McfxRqBY8CI4W8bmzsHOoKAQJmbPqolLlm v9NQPn7muEZIkO3Jf8QPSW34YmlP4GoDavE6mXPFdKF+oc+qMqtzNbSsXPYTwX4KC6iihhCd/lX sL8ihKLC0KbNOv/7eNiArFlNKzbW2Qdv0613v2v4AgrIfBDNbeNz52bBL+carqFeXfwJvYSxdOB ZqM2weRd10WGX+jepGoDkmwyPloo0GP/fr0w9t8ORjQZVkDOrM= X-Received: by 2002:a05:622a:1812:b0:50f:c9a2:1643 with SMTP id d75a77b69052e-517662835efmr36605851cf.11.1780392408389; Tue, 02 Jun 2026 02:26:48 -0700 (PDT) Received: from localhost ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5176e062a2esm6993281cf.7.2026.06.02.02.26.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 02:26:47 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 02 Jun 2026 02:26:44 -0700 Message-Id: To: "Bartosz Golaszewski" , "Rosen Penev" Cc: "Madhavan Srinivasan" , , "Michael Ellerman" , "Nicholas Piggin" , "Linus Walleij" , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , "open list" , Subject: Re: [PATCH 5/7] gpio: ppc44x: Convert GPIO to generic MMIO From: "Rosen Penev" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20260602050131.856789-1-rosenp@gmail.com> <20260602050131.856789-6-rosenp@gmail.com> In-Reply-To: On Tue Jun 2, 2026 at 12:51 AM PDT, Bartosz Golaszewski wrote: > On Tue, 2 Jun 2026 07:01:29 +0200, Rosen Penev said: >> Use gpio_generic_chip_init() to set up the PPC44x GPIO chip >> instead of open-coding the basic get, set, locking and state handling. >> >> Keep the PPC44x-specific direction callbacks because they still need to >> program ODR and the OSR/TSR registers around the generic data and >> direction registers. >> >> Assisted-by: Codex:GPT-5.5 >> Signed-off-by: Rosen Penev >> --- > > ... > >> @@ -124,10 +102,11 @@ static int >> ppc4xx_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) >> { >> struct ppc4xx_gpio_chip *chip =3D gpiochip_get_data(gc); >> + struct gpio_generic_chip *gen_gc =3D &chip->chip; >> struct ppc4xx_gpio __iomem *regs =3D chip->regs; >> unsigned long flags; >> >> - spin_lock_irqsave(&chip->lock, flags); >> + gpio_generic_chip_lock_irqsave(gen_gc, flags); > > If you're already doing it, can you use lock guards too? Sure. btw, I avoided placing https://lore.kernel.org/all/20260517063754.21819-1-rosenp@gmail.com/ in the beginning of the series. My thinking is that's for older kernels. I believe either the generic API or devm_gpiochip_add_data fixes this. > > Bart