From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90FE6360EEA for ; Tue, 16 Jun 2026 12:40:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781613604; cv=none; b=eSJx22HpS1/poM50r3M8uuguS3+/ovYqOUYCS8sS/HW7nJzKU9mmro8v+UvzTsZEw5LjH6djvZvfKf0Wiy6OMve7cgYJz0A3Ki6XYSGTHF4nYnSVohxMAPf4qZN/UlahqYSO/JJ+rKTIrPM1Tu0q8AOzc48R7ElqJfaq89idURo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781613604; c=relaxed/simple; bh=+qoGij95oCB5Tcj73SYSEIQXpI4gExKhrc1Em04cpas=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=NdCUDYe2IoJcjwWI9/E/STuCBX7D7tJLVqeAplDlcObou4PEYu4xW7l+2+9PSU9vRdPsVBs9dJSnlbgthMre9+7bqbZ+RvegC78BY1J7jKOKn2t7MDzAcwDboPTFmjoIOUg2FznYzAVx9t+IR5y15IUqjT8GcjtpgGPEXsmZCYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pEo8i2LW; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pEo8i2LW" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-30bb2df6fbbso1333487eec.0 for ; Tue, 16 Jun 2026 05:40:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781613603; x=1782218403; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+qoGij95oCB5Tcj73SYSEIQXpI4gExKhrc1Em04cpas=; b=pEo8i2LWRYoozGPu5oIpXOukzWB/Elcq6XtfxfC2tyRr47iSJC2PG5aoWpB3A7wP45 Flsjf4/D7ahJd/dr8sDScT/0slGgGKOoRNo7Ri35sBqrcPRQWkoqhRtJRTX2KaETNbR/ B4/pRdjZCrDXMtB3kl8qbpIhvJP4MfPUuQmPoFqvtZbI/Px5Po1TagmF6BunWzeZALf3 2UnTdQzgJtfknLPVvkQ1yHVRj0LesSqvCgZik/6xo4MxO8EPhVTQAWRLcdJI5eXtMnky rPcUwF6cgtCRXTwZKZRJ2wCBOgImHacR5A4vTsUAf065+C2+be3qxoVp6dxqK8TUtrSZ hLxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781613603; x=1782218403; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+qoGij95oCB5Tcj73SYSEIQXpI4gExKhrc1Em04cpas=; b=BQxz2o/WqRkmF3zHXHEHFDIYjpxjoguCu0dFX+ScStZHohb85Sms6nGlKtlI83b/lZ E5qQoqH6VyPmsIy0nJWVUJ9sAXWjl+1xKu7FD4SIkCUR369qJeP8Odqrt/2ElZyNGbPT l7Ce7+a28ytr8DasX7DD32dfuj0kgbSfeRPEEDxGNSXlwxslCH0Ni3CNkJdwas6pOmvR vyj9oHKX63JKB0y3gfgLVOk83rXZ6ORl7IX/CKYNs+o6/aNcrCyDL1oAgOkn4qiGKuHQ YchYymJUCo2Vu+4P+nPvvOkYR2kCNDcQq3lkEhpCkvbN9ckkMVXpmL5O4uvRETY3aVn7 AFLQ== X-Forwarded-Encrypted: i=1; AFNElJ9kWDi2NQbi/7Aq/EpgvRIEfitJwtU+Bo5ClB2ccFiBzmPXvhrDM9ZQMVh8XvL/VC3kInAsk2UakoY6aKM=@vger.kernel.org X-Gm-Message-State: AOJu0YxiOKfhOSUbmU1VI9NfPiiTT/ZFo68pWrAdiwYZx9oL7QD+FIg9 IU8uTMw9O+H1fvyQxzA4t9Swf4WdWJUfVGaK4YjhA9dT7S4luVPrYjJFnPij1rg+0GU= X-Gm-Gg: Acq92OGZwphrzHjgrGsvRH5uV7LOgErviJxxpKoOZIusk9f6GWLjK5fn1G6cT6x1/1Q TDPoGrZeI66Ctgni2PM9/2XRSTI13dZZdyDt90t6QLyQ6NvonIn0CMkgEIwrlzmQKOy5JDX25SF y05TxHdUW6hNztQajjxTz+cSn2rsa+6XiJ2NVeLd2bFLBBZWisUn5ldI0cUgr2A/6SimEaAxsQp jdRjSKCGREYDr0wT7ymTPt5N/gWs2sE6r8k+RzQ5E+3sXzMDmu6Em2ThQP1/oAtVF0JYwOqpJM6 QigY7MVjG9uCONoT3xOGxVV+JOQXloZkn3Qdt6owSUloZHD/U15/FGB9UG0loGCsdU1bqIxz8Qt p2PaGi88NRs+ywjcA+IHpygPzbMrFUE6xjKpjY/4TD7yEdQ9yLgV+CGHrdtuKD9lxnnNkR4q3Bv cyjnqqeLjSOA1EW/2XFK49g9VAxZgttVDbRFtBKnqmbQ4BkeNCY90= X-Received: by 2002:a05:7300:d10:b0:2ed:e12:3773 with SMTP id 5a478bee46e88-30ba5fb4473mr2390102eec.35.1781613602609; Tue, 16 Jun 2026 05:40:02 -0700 (PDT) Received: from localhost ([198.176.50.157]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3081e48bfa7sm18872680eec.5.2026.06.16.05.39.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 05:40:02 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 16 Jun 2026 20:39:57 +0800 Message-Id: Cc: "Chas Williams" <3chas3@gmail.com>, "David S . Miller" , "Eric Dumazet" , "Paolo Abeni" , "Simon Horman" , , , , "Xiang Mei" Subject: Re: [PATCH v2] atm: fix use-after-free in sigd_put_skb() From: "Weiming Shi" To: "Jakub Kicinski" , "Weiming Shi" X-Mailer: aerc 0.21.0 References: <20260609162107.2865310-2-bestswngs@gmail.com> <20260612161051.2d4df09b@kernel.org> In-Reply-To: <20260612161051.2d4df09b@kernel.org> On Sat Jun 13, 2026 at 7:10 AM CST, Jakub Kicinski wrote: > On Wed, 10 Jun 2026 00:21:08 +0800 Weiming Shi wrote: >> sigd_put_skb() delivers a signalling message to the daemon socket named >> by the global @sigd pointer, ending in a call to sk_data_ready(). It >> reads @sigd with no synchronisation, so it can race with a close of the >> daemon socket: sigd_close() clears @sigd and the socket is then torn >> down and freed. > > Hm, we intend to only retain the portions of the ATM stack which are > still used in PPPoATM and ADSL. I don't believe the signaling stuff=20 > is used there. I will post a patch to delete this code. Thanks, that makes sense to me.=20