From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78643CD98ED for ; Thu, 18 Jun 2026 07:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ghPkSH6wI54dpS/4E7fbbx/Hx++/38tkYqLaumCkCTw=; b=dO/AKCQ9wd1LbX 68tb3c6yulvaLZqY6bLBnKKGJB9fuK+y9BuyBx0/ZVzNZg3ORTgaAxSPW6a4Ntcy/egHNc1wfDwkM yNVOwA4bhGLSufzZQ6IaOqyLh+Hf+KIcciG8NWGl7rUVuL6SOfSMGFt4i8OjLmRT69JvEBiY3KGt3 HiEJBhRq+gEDlvxq40ZaKZs6QLHDaETp+nDS0LHOpgP2FHpYTicP0AXmLrTW3qMMxPjbhRSN7+u2w ZywAFqUPItMdslyY+Lfm9hBrePN9snecMoqSvzNyeg6WyB+nm+uPNzYKxkbRJ+ilyag2nGxJ0c27V 0lA3P7WiprPSl0ZhgUKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wa7ee-00000000oQA-1Pdx; Thu, 18 Jun 2026 07:59:16 +0000 Received: from out-170.mta0.migadu.com ([91.218.175.170]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wa7eb-00000000oP8-2ju1 for linux-rockchip@lists.infradead.org; Thu, 18 Jun 2026 07:59:15 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1781769539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vmts3eVcq1AB/MaOX1+dMbZWrM8G02gzaeVnUoYstpY=; b=iHsAZ1Jp6nMQWYrVGGLThRws4MJ9eNCU22+ngX8PXCh56gz2+Vbb24ZIj6VGb6/jM/lMya 7u+JmEvYY1JMZM82d6xmfBZcRD77TXUYJe7RDF4Rvhk6o9Y4oUKwc+bcBM43seA8EKzAXD jqJ8XMf6IIrR60MXQaKBLDsvNNEHTWt4MUAG6DUP4bCRjZlgF3DPSSZcWF4biChXaQ2rvJ rMa6+HeOo+GYXNQnVeNDf02rSmTd03tFHgF1wMH8fR/NRxStYWyprrfJFu6hm+FJmrw0Pc 98X6LUc1KD/DrZ71YOD/uup/O4qaQgMykCC/fGXLxh8paDGre4D2TXrTsR25LA== Date: Thu, 18 Jun 2026 09:58:52 +0200 Message-Id: Cc: , "Andy Yan" , , , , , Subject: Re: [PATCH 1/9] dt-bindings: display: vop2: Add missing reset properties X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Cristian Ciocaltea" , "Sandy Huang" , =?utf-8?q?Heiko_St=C3=BCbner?= , "Andy Yan" , "David Airlie" , "Simona Vetter" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Philipp Zabel" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" References: <20260617-dw-hdmi-qp-yuv-v1-0-a665cfd06d7d@collabora.com> <20260617-dw-hdmi-qp-yuv-v1-1-a665cfd06d7d@collabora.com> In-Reply-To: <20260617-dw-hdmi-qp-yuv-v1-1-a665cfd06d7d@collabora.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260618_005913_834211_1C1E9AA2 X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Cristian, Thanks for this series :-) Just 1 nit (at the end) ... On Wed Jun 17, 2026 at 8:52 PM CEST, Cristian Ciocaltea wrote: > Document the VOP2 resets corresponding to the AXI, AHB and DCLK_VP0..2 > clocks, which are common to all supported SoCs, plus DCLK_VP3 which is > provided only on RK3588. > > Signed-off-by: Cristian Ciocaltea > --- > .../bindings/display/rockchip/rockchip-vop2.yaml | 42 ++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > index 93da1fb9adc4..d3bc5380f910 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -82,6 +82,20 @@ properties: > - {} > - {} > > + resets: > + minItems: 5 > + maxItems: 6 > + > + reset-names: > + minItems: 5 > + items: > + - const: axi > + - const: ahb > + - const: dclk_vp0 > + - const: dclk_vp1 > + - const: dclk_vp2 > + - const: dclk_vp3 > + > rockchip,grf: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -148,6 +162,12 @@ allOf: > clock-names: > maxItems: 5 > > + resets: > + maxItems: 5 > + > + reset-names: > + maxItems: 5 > + > interrupts: > maxItems: 1 > > @@ -194,6 +214,12 @@ allOf: > - {} > - const: pll_hdmiphy0 > > + resets: > + maxItems: 5 > + > + reset-names: > + maxItems: 5 > + > interrupts: > minItems: 4 > > @@ -246,6 +272,12 @@ allOf: > - const: pll_hdmiphy0 > - const: pll_hdmiphy1 > > + resets: > + minItems: 6 > + > + reset-names: > + minItems: 6 > + > interrupts: > maxItems: 1 > > @@ -289,6 +321,16 @@ examples: > "dclk_vp0", > "dclk_vp1", > "dclk_vp2"; > + resets = <&cru SRST_A_VOP>, > + <&cru SRST_H_VOP>, > + <&cru SRST_VOP0>, > + <&cru SRST_VOP1>, > + <&cru SRST_VOP2>; > + reset-names = "axi", > + "ahb", > + "dclk_vp0", > + "dclk_vp1", > + "dclk_vp2"; > power-domains = <&power RK3568_PD_VO>; Place reset* props below power-domains (like in patch 9) ? So everyone who copies your example has the correct sorting order. Cheers, Diederik > rockchip,grf = <&grf>; > iommus = <&vop_mmu>; _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7B99CD98F0 for ; Thu, 18 Jun 2026 07:59:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DA4210EC50; Thu, 18 Jun 2026 07:59:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=cknow-tech.com header.i=@cknow-tech.com header.b="iHsAZ1Jp"; dkim-atps=neutral Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8358510EC50 for ; Thu, 18 Jun 2026 07:59:02 +0000 (UTC) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1781769539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vmts3eVcq1AB/MaOX1+dMbZWrM8G02gzaeVnUoYstpY=; b=iHsAZ1Jp6nMQWYrVGGLThRws4MJ9eNCU22+ngX8PXCh56gz2+Vbb24ZIj6VGb6/jM/lMya 7u+JmEvYY1JMZM82d6xmfBZcRD77TXUYJe7RDF4Rvhk6o9Y4oUKwc+bcBM43seA8EKzAXD jqJ8XMf6IIrR60MXQaKBLDsvNNEHTWt4MUAG6DUP4bCRjZlgF3DPSSZcWF4biChXaQ2rvJ rMa6+HeOo+GYXNQnVeNDf02rSmTd03tFHgF1wMH8fR/NRxStYWyprrfJFu6hm+FJmrw0Pc 98X6LUc1KD/DrZ71YOD/uup/O4qaQgMykCC/fGXLxh8paDGre4D2TXrTsR25LA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 18 Jun 2026 09:58:52 +0200 Message-Id: Cc: , "Andy Yan" , , , , , Subject: Re: [PATCH 1/9] dt-bindings: display: vop2: Add missing reset properties X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Cristian Ciocaltea" , "Sandy Huang" , =?utf-8?q?Heiko_St=C3=BCbner?= , "Andy Yan" , "David Airlie" , "Simona Vetter" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Philipp Zabel" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Luca Ceresoli" References: <20260617-dw-hdmi-qp-yuv-v1-0-a665cfd06d7d@collabora.com> <20260617-dw-hdmi-qp-yuv-v1-1-a665cfd06d7d@collabora.com> In-Reply-To: <20260617-dw-hdmi-qp-yuv-v1-1-a665cfd06d7d@collabora.com> X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Cristian, Thanks for this series :-) Just 1 nit (at the end) ... On Wed Jun 17, 2026 at 8:52 PM CEST, Cristian Ciocaltea wrote: > Document the VOP2 resets corresponding to the AXI, AHB and DCLK_VP0..2 > clocks, which are common to all supported SoCs, plus DCLK_VP3 which is > provided only on RK3588. > > Signed-off-by: Cristian Ciocaltea > --- > .../bindings/display/rockchip/rockchip-vop2.yaml | 42 ++++++++++++++++= ++++++ > 1 file changed, 42 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-= vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop= 2.yaml > index 93da1fb9adc4..d3bc5380f910 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.ya= ml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.ya= ml > @@ -82,6 +82,20 @@ properties: > - {} > - {} > =20 > + resets: > + minItems: 5 > + maxItems: 6 > + > + reset-names: > + minItems: 5 > + items: > + - const: axi > + - const: ahb > + - const: dclk_vp0 > + - const: dclk_vp1 > + - const: dclk_vp2 > + - const: dclk_vp3 > + > rockchip,grf: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -148,6 +162,12 @@ allOf: > clock-names: > maxItems: 5 > =20 > + resets: > + maxItems: 5 > + > + reset-names: > + maxItems: 5 > + > interrupts: > maxItems: 1 > =20 > @@ -194,6 +214,12 @@ allOf: > - {} > - const: pll_hdmiphy0 > =20 > + resets: > + maxItems: 5 > + > + reset-names: > + maxItems: 5 > + > interrupts: > minItems: 4 > =20 > @@ -246,6 +272,12 @@ allOf: > - const: pll_hdmiphy0 > - const: pll_hdmiphy1 > =20 > + resets: > + minItems: 6 > + > + reset-names: > + minItems: 6 > + > interrupts: > maxItems: 1 > =20 > @@ -289,6 +321,16 @@ examples: > "dclk_vp0", > "dclk_vp1", > "dclk_vp2"; > + resets =3D <&cru SRST_A_VOP>, > + <&cru SRST_H_VOP>, > + <&cru SRST_VOP0>, > + <&cru SRST_VOP1>, > + <&cru SRST_VOP2>; > + reset-names =3D "axi", > + "ahb", > + "dclk_vp0", > + "dclk_vp1", > + "dclk_vp2"; > power-domains =3D <&power RK3568_PD_VO>; Place reset* props below power-domains (like in patch 9) ? So everyone who copies your example has the correct sorting order. Cheers, Diederik > rockchip,grf =3D <&grf>; > iommus =3D <&vop_mmu>;