All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
To: Krzysztof Niemiec <krzysztof.niemiec@intel.com>,
	<dri-devel@lists.freedesktop.org>
Cc: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Krzysztof Karas <krzysztof.karas@intel.com>,
	Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
	Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Subject: Re: [PATCH 1/2] gpu: Fix dependencies in CONFIG_GPU_BUDDY_KUNIT_TEST
Date: Fri, 19 Jun 2026 12:09:58 +0200	[thread overview]
Message-ID: <DJCY007UJ52C.3G2MFQ6DMZ5VB@intel.com> (raw)
In-Reply-To: <20260618152331.36763-2-krzysztof.niemiec@intel.com>

Hi Krzysztof,

On Thu Jun 18, 2026 at 5:23 PM CEST, Krzysztof Niemiec wrote:
> CONFIG_GPU_BUDDY is currently not selectable by the user, mirroring
> how CONFIG_DRM_BUDDY does it - the idea is for a driver that makes use
> of it to include a "select GPU_BUDDY" line in its kconfig.
> CONFIG_DRM_BUDDY is also selected when building with
> CONFIG_DRM_KUNIT_TEST, as it can be thought of as building a mock
> "driver" running the tests, that makes use of the buddy functionality.
>
> CONFIG_GPU_BUDDY_KUNIT_TEST doesn't follow that logic, requiring
> GPU_BUDDY to be selected already instead of selecting it itself. This
> requires building the test kernel with another driver that uses
> DRM_BUDDY, as this is currently the only kconfig option that selects
> GPU_BUDDY. That shouldn't be required to run unit tests for a module
> now completely independent from DRM, let alone any specific driver.
>
> Fix the dependency declaration in CONFIG_GPU_BUDDY_KUNIT_TEST to make it
> work as intended, mirroring the setup in CONFIG_DRM_KUNIT_TEST.
>
> Signed-off-by: Krzysztof Niemiec <krzysztof.niemiec@intel.com>
> ---
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

-- 
Best regards,
Sebastian


  reply	other threads:[~2026-06-19 10:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 15:23 [PATCH 0/2] GPU buddy allocator test fixes Krzysztof Niemiec
2026-06-18 15:23 ` [PATCH 1/2] gpu: Fix dependencies in CONFIG_GPU_BUDDY_KUNIT_TEST Krzysztof Niemiec
2026-06-19 10:09   ` Sebastian Brzezinka [this message]
2026-06-19 11:24   ` Andi Shyti
2026-06-18 15:23 ` [PATCH 2/2] gpu/tests: Add a dedicated .kunitconfig Krzysztof Niemiec
2026-06-19 10:09   ` Sebastian Brzezinka
2026-06-19 11:26   ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJCY007UJ52C.3G2MFQ6DMZ5VB@intel.com \
    --to=sebastian.brzezinka@intel.com \
    --cc=airlied@gmail.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=janusz.krzysztofik@linux.intel.com \
    --cc=joelagnelf@nvidia.com \
    --cc=krzysztof.karas@intel.com \
    --cc=krzysztof.niemiec@intel.com \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.