From: "Danilo Krummrich" <dakr@kernel.org>
To: "Maurice Hieronymus" <mhi@mailbox.org>
Cc: "Onur Özkan" <work@onurozkan.dev>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>, "Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Lyude Paul" <lyude@redhat.com>,
linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, "Fiona Behrens" <me@kloenk.dev>
Subject: Re: [PATCH v2 2/4] rust: pci: add managed Device::enable_device()
Date: Sun, 21 Jun 2026 14:02:06 +0200 [thread overview]
Message-ID: <DJEPMYC7J6ZG.D0ODUD4YGFCT@kernel.org> (raw)
In-Reply-To: <23297c85b12edcf0eafb183827e0db750620e6cb.camel@mailbox.org>
On Sun Jun 21, 2026 at 12:19 AM CEST, Maurice Hieronymus wrote:
> Isn't it confusing when we only have `enable_device_managed` and
> `enable_device_mem_unmanaged` but not `enable_device_unmanaged` and
> `enable_device_mem_managed`?
I think we only need enable_device_managed() and a enable_device() /
disable_device() pair.
enable_device_managed() should be preferred, the unmanaged functions may still
be used for runtime PM.
The existing enable_device_mem() should just be removed and nova-core should use
enable_device_managed() in probe() instead.
If you are interested, feel free to create a small separate patch series making
those changes; you can stack this one on top of it.
next prev parent reply other threads:[~2026-06-21 12:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-20 8:45 [PATCH v2 0/4] rust: samples: add an EDU PCI driver sample (MMIO + IRQ + DMA) Maurice Hieronymus
2026-06-20 8:45 ` [PATCH v2 1/4] rust: pci: make Vendor::from_raw() public Maurice Hieronymus
2026-06-20 8:50 ` sashiko-bot
2026-06-20 9:48 ` Onur Özkan
2026-06-20 8:45 ` [PATCH v2 2/4] rust: pci: add managed Device::enable_device() Maurice Hieronymus
2026-06-20 9:00 ` sashiko-bot
2026-06-20 9:54 ` Onur Özkan
2026-06-20 22:19 ` Maurice Hieronymus
2026-06-21 12:02 ` Danilo Krummrich [this message]
2026-06-20 8:45 ` [PATCH v2 3/4] rust: completion: add complete() Maurice Hieronymus
2026-06-20 8:51 ` sashiko-bot
2026-06-20 9:48 ` Onur Özkan
2026-06-20 8:45 ` [PATCH v2 4/4] rust: samples: add EDU PCI driver sample Maurice Hieronymus
2026-06-20 8:59 ` sashiko-bot
2026-06-20 9:45 ` Onur Özkan
2026-06-21 12:27 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJEPMYC7J6ZG.D0ODUD4YGFCT@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=me@kloenk.dev \
--cc=mhi@mailbox.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.