From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Danilo Krummrich" <dakr@kernel.org>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Benno Lossin" <lossin@kernel.org>, "Gary Guo" <gary@garyguo.net>,
<nova-gpu@lists.linux.dev>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>, <rust-for-linux@vger.kernel.org>,
"Joel Fernandes" <joelagnelf@nvidia.com>
Subject: Re: [PATCH v3 3/3] gpu: nova-core: gsp: Extract and display usable FB regions from GSP
Date: Mon, 22 Jun 2026 10:11:10 +0900 [thread overview]
Message-ID: <DJF6F4194K7C.P89RQTXATU6O@nvidia.com> (raw)
In-Reply-To: <DJDY31W202BF.4OHIYPH1MEDX@kernel.org>
On Sat Jun 20, 2026 at 11:26 PM JST, Danilo Krummrich wrote:
> On Sat Jun 20, 2026 at 4:06 PM CEST, Alexandre Courbot wrote:
>> I expect that the users of the VRAM regions (i.e. the MM subsystem) will
>> not be able to contruct properly if no region is detected, and that sounds
>> like the right place to raise an error rather than making an assumption
>> here that no VRAM region is an error. For instance, I am not sure what
>> the regions layout will be on Tegra systems, although your comment about
>> OpenRM seems to hint that there are regions defined for them as well.
>
> Well, the question is whether it would just be an assumption that no VRAM region
> is an error. I'm not entirely sure, but I think it generally is an error. If
> that's confirmed I'd rather fail early and with a clear message, and not carry
> on with something we already know won't work out.
I took a deeper look at OpenRM. The zero FB region error is emitted when
mirroring the list of FB regions [1], which is a default HAL method.
Zero-VRAM chips like Tegra replace it with an empty stub.
So `gpu.rs` doesn't look like the right place to do that check imho -
especially since the list we are checking against is the list of
*usable* regions, whereas OpenRM checks the full list. The current code
is just getting the list from the GSP - the code that does something
meaningful with it doesn't exist yet, and it is that code that should
error if there are no FB regions at all.
[1] https://github.com/NVIDIA/open-gpu-kernel-modules/blob/570.148/src/nvidia/src/kernel/gpu/mem_mgr/mem_mgr_gsp_client.c#L61
next prev parent reply other threads:[~2026-06-22 1:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 13:24 [PATCH v3 0/3] gpu: nova-core: obtain and display VRAM amount Alexandre Courbot
2026-06-17 13:24 ` [PATCH v3 1/3] gpu: nova-core: move GSP unload state to a pinned Gpu subobject Alexandre Courbot
2026-06-17 13:24 ` [PATCH v3 2/3] gpu: nova-core: move GPU static information acquisition to a GSP method Alexandre Courbot
2026-06-17 13:24 ` [PATCH v3 3/3] gpu: nova-core: gsp: Extract and display usable FB regions from GSP Alexandre Courbot
2026-06-20 11:30 ` Danilo Krummrich
2026-06-20 14:06 ` Alexandre Courbot
2026-06-20 14:26 ` Danilo Krummrich
2026-06-22 1:11 ` Alexandre Courbot [this message]
2026-06-22 7:24 ` Eliot Courtney
2026-06-20 10:49 ` [PATCH v3 0/3] gpu: nova-core: obtain and display VRAM amount Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJF6F4194K7C.P89RQTXATU6O@nvidia.com \
--to=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.