From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A1993B19D0 for ; Tue, 23 Jun 2026 21:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782251550; cv=none; b=UT4MoWXqWCdBEe65moaQ+HaiekieBZqphwJFs3wsuZ9O7WwJdTYXdeu9gEiPLNqpkqEPc+wUt9qPfVuZG6nz1TZUViyy/wcIZKKkbxNUdb7pz1juI3oNoHLMrdRn5Pt8p9aM3Izwa/GLHgivIzI0wnjxRjnrM9i8C9M8UKjJcWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782251550; c=relaxed/simple; bh=DEcLyTmhwS+RlC8yglBZkBjdWRmROimrD2+mka7sjzw=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=aCEAmrDMTkllHTx6DZxpdqlvnYQmg4SWZFp8IW3fsKKWnky5lv29hfsDoW8UzvkGXwK+Co2rMCvD3F42Y+wiaxvh7vWo3Bj+yHEMdvmsmZyI4abKdnFRw4+NHk9TfeFCC+0rus2eA5a+8+O8NrSp5ikeo1aBPVfQ+wSFUzhOrgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b=wVPOfHJ8; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20251104.gappssmtp.com header.i=@etsalapatis-com.20251104.gappssmtp.com header.b="wVPOfHJ8" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-13986d61b4fso560789c88.0 for ; Tue, 23 Jun 2026 14:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20251104.gappssmtp.com; s=20251104; t=1782251548; x=1782856348; darn=vger.kernel.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GFlyRL2o4sdMxWc71sn5UWmBL09Nr89DIg0wWzeHTvA=; b=wVPOfHJ8GFlKHbzbrbCUAocTF2i11vPx6ZLMqBWzdCl2UNW4s109kduJYQj7REuCcb 9eBOdO28GUeCLE8dzzLdfYBwWuaslwMSktvoN7jqQmtEbATK32rb3g9x+5KFSgfxnIek cvlAtt5iAjzuYGqWfgQYViKWe/MwUdF8LPR8Mre3nWDepAC8tpvf3JjHhsQdYRZfu+dz Jcm1RGPiGGBNSBD/6QKCU9uGix+Uz1t4zbUvO5yQTfSdf8q9qCl01pND+kdP8suzx+l2 qxrrZR8n7LN72KFVZS1UBHs20lRa3892d6OEeDzDGz+dVmHIzclb4kOO9CjD6r1OtKlr UKRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782251548; x=1782856348; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GFlyRL2o4sdMxWc71sn5UWmBL09Nr89DIg0wWzeHTvA=; b=KMfXAtb6NFF2+4jvuC/hgpRaNVuw2qCtbBUr3hup3gybYzwhsVJgdUCLuV4wgrdMtN wPvRH5orkko5ZBOrv0xRhArDJKJqiUcz+1eZqXBZD1cEGvJ8KfklyZqy6oFG4B4wzuqm 8XozjrTRf/D4fQf4jxzzkav9+py3aRvKbLsX9PR2V7mLoZYrqTewYrl7KuLG3v1G4P1B g46VZfsUxsJ79x9AZ8TVPbFEy2mPhsXYsyyl07UYnEzPwpESBrz3MUiklV+6H6n1YQMF v3fP1WRHM3si1gjmD1ylR7l7ilL5kGbSRoniayweKKSI/8jiKcQgq29KFAMXZmnuZrOy pZXA== X-Forwarded-Encrypted: i=1; AFNElJ9pCqf7fj1qKoNPn5DfvEdiQZtUxBthjQ73KtwFOKvFTIJnz37cEP/ZD1MkXS+X2aS6GGjkgpTz24xElK4=@vger.kernel.org X-Gm-Message-State: AOJu0YxHbNOcrBSjX3QjjSsoRg7BpSWw1addhfOsygfK4wuGj4H+Wv+4 8RUqS6wlIr8wGS+QBSBBpebPJ2PrVDo2Zqbvo7FTCAhYExkZ00ShzzuSAKx72vHPQfA= X-Gm-Gg: AfdE7cnisW0s0BlsPP8gk+EuzSlWXT/HtEjzVxA7nyDCPg17yZwzoH+Chvnahv1y6kv ydUhwzB5JTXHzt3n4aquDk3Tr6KK13PwB1TGIzEfJZdaahoPZ8Q7z5QajcTrIP4PmRZTPgYXSXp RVhBE0uiaZK493lTsIOEX0x6AA63y0wuYMbaMlld305EKPsJs1gsYZ2Y33eSfoKTYhvjhzAUpZz sOYP9uHkV/anbFVOJurtIsUjJujO5UPHv8Y01FvqwamymUvpTlLYLZzmqOGRBEyEhG05AQCTSr9 l8G6Q9ib5cdMgiCBa0w+vvIqlj3H5ujvtUXL1GWT9qZI574F3HRzfO73JFMJz46lz+cjXBSHk5a L3oP8S9bzhhphVDGFz7Yy2D8EOsnv2eC0lHJtnwyk+osA5GFI1S03V8c/7+vUCMYl2wvzZw== X-Received: by 2002:a05:7022:410:b0:11a:342e:8a98 with SMTP id a92af1059eb24-139d0b58d17mr456804c88.0.1782251548209; Tue, 23 Jun 2026 14:52:28 -0700 (PDT) Received: from localhost ([2620:10d:c090:600::2526]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-139adcce488sm14516255c88.8.2026.06.23.14.52.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 14:52:27 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 23 Jun 2026 17:52:25 -0400 Message-Id: Subject: Re: [PATCH bpf-next v4 1/2] bpf: Reject offset refcount acquire arguments From: "Emil Tsalapatis" To: , , , , , , Cc: , , , , , , , , , , , , , , , X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <2f894647f56f71838fdddeb97a3e057ed35ea92e.1782192383.git.chenyy23@mails.tsinghua.edu.cn> <2c2797dac0dc56bf183087ed97aed819d1184568d2249b11439ab542afa43b4a@mail.kernel.org> In-Reply-To: <2c2797dac0dc56bf183087ed97aed819d1184568d2249b11439ab542afa43b4a@mail.kernel.org> On Tue Jun 23, 2026 at 3:01 AM EDT, bot+bpf-ci wrote: >> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c >> index 2abc79dbf281..f65eff28ecd2 100644 >> --- a/kernel/bpf/verifier.c >> +++ b/kernel/bpf/verifier.c > > [ ... ] > >> @@ -12135,7 +12146,8 @@ static int check_kfunc_args(struct bpf_verifier_= env *env, struct bpf_kfunc_call_ >> >> if (regno =3D=3D meta->release_regno) >> arg_type |=3D OBJ_RELEASE; >> - ret =3D check_func_arg_reg_off(env, reg, argno, arg_type); >> + ret =3D __check_func_arg_reg_off(env, reg, argno, arg_type, >> + btf_id_fixed_off_ok); > > This isn't a bug, but does this call need to be split across two lines? > The line length limit is 100 characters, and it looks like it would fit > on a single line: Bot is right, we don't split diagnostics across lines. > > ret =3D __check_func_arg_reg_off(env, reg, argno, arg_type, btf_id_fixe= d_off_ok); > >> if (ret < 0) >> return ret; > > > --- > AI reviewed your patch. Please fix the bug or email reply why it's not a = bug. > See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/READM= E.md > > CI run summary: https://github.com/kernel-patches/bpf/actions/runs/280072= 09948