From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25C10CDE001 for ; Wed, 24 Jun 2026 15:39:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8831F10EF95; Wed, 24 Jun 2026 15:39:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="R2tbTHoH"; dkim-atps=neutral Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC9FA10E057 for ; Wed, 24 Jun 2026 15:39:31 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 1B7574E407D5; Wed, 24 Jun 2026 15:39:30 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C776B601C5; Wed, 24 Jun 2026 15:39:29 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B65AB106C83D2; Wed, 24 Jun 2026 17:39:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782315568; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=7wlapFSWGO6DNer+Ht2N3RKQcuhgJMsXd2Wu+AmSoUk=; b=R2tbTHoHg6xp8JHCk54cyMomtr3bBIbZWDSp+cCHNJ9OtWW9AnRTIPAEs/OcMPdUKK5JsB k1kNCA8XHXGluZErZz0oiODLWi6Rjj6JmeMb5WlzQLrDI33rqMd7/NTArt1Hx8h+/8SDyb 4wcxhbwXNOGXUr2zV6+Pid3E9PaXrfYhfy5rSCzSwOfqGX1klzu5jp9oZy6sr19dEeTcCt q9vMmT/B2ERe48YTHNtQEThtcTQaOnh0NHReQpRz7CDPJ9TH8CQiyLEdBvtOPQ6KBgoS/d 2EpjsuTaGx+EfvHQQHy/zY8pEP3SfIHLt38I9JcBfnfOydt3GUe0TJtqZwm3Fw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 24 Jun 2026 17:39:19 +0200 Message-Id: Subject: Re: [PATCH 06/37] drm/display: bridge-connector: use a drm_bridge_connector internally, not a drm_connector Cc: "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Inki Dae" , "Jagan Teki" , "Marek Szyprowski" , "Marek Vasut" , "Stefan Agner" , "Frank Li" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , , , , To: "Maxime Ripard" , "Luca Ceresoli" From: "Luca Ceresoli" X-Mailer: aerc 0.21.0 References: <20260519-drm-bridge-hotplug-v1-0-45e2bdb3dfb4@bootlin.com> <20260519-drm-bridge-hotplug-v1-6-45e2bdb3dfb4@bootlin.com> <20260608-little-lyrebird-of-competition-c25f7d@houat> <20260624-chicken-of-infinite-enthusiasm-8b0e3f@houat> In-Reply-To: <20260624-chicken-of-infinite-enthusiasm-8b0e3f@houat> X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed Jun 24, 2026 at 1:47 PM CEST, Maxime Ripard wrote: > On Fri, Jun 12, 2026 at 02:57:39PM +0200, Luca Ceresoli wrote: >> On Mon Jun 8, 2026 at 1:41 PM CEST, Maxime Ripard wrote: >> > On Tue, May 19, 2026 at 12:37:23PM +0200, Luca Ceresoli wrote: >> >> Currently drm_bridge_connector_init() always returns the added connec= tor or >> >> errors out. When adding bridge hotplug the bridge-connector can be >> >> successfully initialized without creating a connector, which can be a= dded >> >> later when the pipeline will be complete. >> >> >> >> For this the internal function drm_bridge_connector_add_connector() m= ust be >> >> able to return a valid drm_bridge_connector even without any drm_conn= ector. >> >> >> >> In preparation to support bridge hotplug, change its return value to = be the >> >> same drm_bridge_connector pointer it gets as input, or a PTR_ERR. >> >> >> >> No functional changes, just changing an internal API. >> >> >> >> Note the return value could now become an int (0 or negative error) b= ecause >> >> returning the same value received as input does not carry any added >> >> value. However this would be change a lot of lines, so leave such cha= nge as >> >> a future cleanup. >> > >> > You just created that function and changed "a lot of lines" already, s= o >> > I'm not sure that argument holds. >> >> Do you refer to the previous patch? >> >> My comment is more about the following patches. It means I separated >> changes moving code to a subfunction from changes to the the return valu= e >> in separate patches, so that each patch is trivial to review for >> correctness. >> >> Makes sense? > > What confused me is that I took it as "I'm not going to do that work > (yet?)". If you do it later on, I'd drop the "future cleanup" part, or > rephrase it. Ah, I see the issue. I really meant "this change [returning int] is done in a following commit". I guess I'll just drop the whole paragraph. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com