Re: [PATCH i-g-t 01/25] tools: igt_stats: drop libigt.so, link against minimal sub-libraries

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

Hi Krzysztof,

On Thu Jun 25, 2026 at 8:11 AM CEST, Krzysztof Karas wrote:
> Hi Sebastian,
>
> The patch works as advertised, but Ashutosh had some qualms
> about the series, so I'll refrain from giving my r-bs for now.
> I too have some suggestions down below.
>
> On 2026-06-24 at 10:47:08 +0200, Sebastian Brzezinka wrote:
>> igt_stats only needs the statistics helpers and a small assert stub.
>> Link it against lib_igt_stats and lib_igt_tools_stub instead of the
>> full libigt.so stack.
>> 
>> ldd before: 35  (ldd | wc -l)
>> ldd after:   4   (ldd | wc -l)
>> 
>> Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
>> ---
>>  lib/meson.build   | 14 ++++++++++++++
>>  tools/meson.build |  6 +++++-
>>  2 files changed, 19 insertions(+), 1 deletion(-)
>> 
>> diff --git a/lib/meson.build b/lib/meson.build
>> index f25ecd8b2..96903d06f 100644
>> --- a/lib/meson.build
>> +++ b/lib/meson.build
>> @@ -389,6 +389,20 @@ lib_igt_profiling_build = static_library('igt_profiling',
>>  lib_igt_profiling = declare_dependency(link_with : lib_igt_profiling_build,
>>  				        include_directories : inc)
>>  
>> +lib_igt_tools_stub_build = static_library('igt_tools_stub',
>> +	['igt_tools_stub.c'],
>> +	include_directories : inc)
>> +
>> +lib_igt_tools_stub = declare_dependency(link_with : lib_igt_tools_stub_build,
>> +					include_directories : inc)
>> +
> I think this change deserves its own patch. Stub dependency is
> used accross this series, so pleade do not obscure it here, as
> a part of igt_stats dedicated change.
>
You may be right here.

> Another thing: I'd find reading this series easier if you
> bunched together all the patches using stub dependency.
The per-tool split is intentional for two reasons: each patch shows
the ldd improvement for that specific tool, and if any tool turns out
to have a backward compatibility issue it can be reverted individually
without touching the rest of the series.


-- 
Best regards,
Sebastian