All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zi Yan" <ziy@nvidia.com>
To: "Zhen Ni" <zhen.ni@easystack.cn>, <akpm@linux-foundation.org>,
	<vbabka@kernel.org>
Cc: <surenb@google.com>, <mhocko@suse.com>, <jackmanb@google.com>,
	<hannes@cmpxchg.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 0/4] mm/page_owner: add per-fd filter infrastructure for print_mode and NUMA filtering
Date: Thu, 25 Jun 2026 14:22:33 -0400	[thread overview]
Message-ID: <DJIC8FHUE508.1H55DFNUVM9EE@nvidia.com> (raw)
In-Reply-To: <20260625043101.338794-1-zhen.ni@easystack.cn>

On Thu Jun 25, 2026 at 12:30 AM EDT, Zhen Ni wrote:
> This patch series introduces per-file-descriptor filtering capabilities to the
> page_owner feature.
>
> Changes in v11:
> - Remove 'nid' member from struct page_owner to save memory
> - Read page->flags directly with poison checking
> - Add signal(SIGPIPE, SIG_IGN) to ignore SIGPIPE and handle EPIPE gracefully
> - Treat EPIPE from fwrite() and fflush() as success (broken pipe case)
>
> Changes in v10:
> - Add 'nid' member to struct page_owner and record it at allocation time
> - Remove cond_resched() in page iteration loop (unconditional call)
> - Improve error handling: check fwrite() and fflush() return values
> - Handle EPIPE correctly: treat broken pipe as success
>
> Changes in v9:
> - Add spinlock_t lock to struct page_owner_filter_state
> - Use memdesc_nid() instead of page_to_nid()
> - Fix isdigit() usage
> - Optimize I/O performance
>
> Changes in v8:
> - Fix buffer overflow, strsep() memory corruption, and unsafe string handling issues
> - Add cond_resched() to prevent RCU stalls in page iteration loop
> - Improve validation and error handling (e.g., "1-2-3") in userspace tool
> - Fix documentation warnings and improve code comments
>
> v8 additional testing with invalid inputs:
>   ./page_owner_filter -n 1-2-3
>   Error: Multiple dashes in nid_list
>
>   ./page_owner_filter -n 0,1-2-3
>   Error: Multiple dashes in nid_list
>
>   ./page_owner_filter -n 1-2-3,2-3
>   Error: Multiple dashes in nid_list
>
> Changes in v7:
> - print_mode and NUMA node filter implementation (patches 1-2)
> - Add page_owner_filter userspace tool (patch 3)
> - Update documentation for per-fd interface (patch 4)
>
> Changes in v6:
> - Address SeongJae Park's review comments for patch 1/3:
>   * Remove unnecessary braces in if/else statement
>   * Use stack array instead of kmalloc for input buffer
> - Address SeongJae Park's review comments for patch 2/3:
>   * Add node validity check using nodes_subset() to reject non-existent nodes
>   * Separate variable declaration and statement
>   * Use kmalloc_objs() for consistency with kernel patterns
>   * Remove 100 bytes overhead
> - Add lore links to all previous versions
>
> Changes in v5:
> - Optimize nodes_empty() check in page iteration loop
> - Add __data_racy qualifier to nid_mask field
>
> Changes in v4:
> - Change print_mode from numeric (0/1) to string-based interface
>   * Use "full_stack"/"stack_handle" strings instead of numbers
>   * Display current mode with bracket notation: "[full_stack] stack_handle"
> - Remove "-1" support from NUMA filter
>   * Use empty string to clear filter (echo > nid)
> - Use strncpy_from_user() instead of copy_from_user()
> - Rename nid_filter_fops to page_owner_nid_filter_fops for consistency
> - Merge patch 1 (infrastructure) and patch 2 (print_mode) from v3
> - Update documentation to match new interface
>   * String-based examples
>   * Tab indentation in code blocks
>
> Changes in v3:
> - Remove READ_ONCE/WRITE_ONCE for nodemask_t (fixes compilation errors)
>   * nodemask_t is a large structure (128 bytes) that triggers compile-time asserts
>   * Direct assignment is safe for this use case
> - Add comment explaining input length calculation formula
>   * 6 bytes = ",NNNNN" (comma + 5-digit node number)
> - Simplify "-1" check using kstrtoint() instead of dual strcmp()
> - Move nodemask_t mask read outside PFN iteration loop for performance
>   * Avoids 128-byte structure copy on each iteration
> - Add documentation for filter features (patch 3/3)
>
> Changes in v2:
> - Renamed 'compact' to 'print_mode' with enum type for better clarity
>   * PAGE_OWNER_PRINT_FULL_STACK (0): print full stack traces
>   * PAGE_OWNER_PRINT_STACK_HANDLE (1): print only stack handles
> - Changed NUMA filter from single node to nodelist with bitmask support
>   * Uses nodelist_parse() to support "0", "0,2", "0-3", "0,2-4,7" formats
>   * Uses nodemask_t internally for efficient multi-node filtering
>   * Output uses %*pbl format (e.g., "0-2", "0,2-4,7")
> - Improved memory handling in nid_filter_write using dynamic allocation
>   * Limit: (100 + 6 * MAX_NUMNODES) to handle worst-case input
>
>
> Problem Statement
> =================
>
> In production environments with large memory configurations (e.g., 250GB+),
> collecting page_owner information often results in files ranging from
> several gigabytes to over 10GB. This creates significant challenges:
>
> 1. Storage pressure on production systems
> 2. Difficulty transferring large files from production environments
> 3. Post-processing overhead with tools/mm/page_owner_sort.c
>
> The primary contributor to file size is redundant stack trace
> information. While the kernel already deduplicates stacks via
> stackdepot, page_owner retrieves and stores full stack traces for
> each page, only to deduplicate them again during post-processing.
>
> Additionally, in NUMA-aware environments (e.g., DPDK-based cloud
> deployments where QEMU processes are bound to specific NUMA nodes),
> OOM events are often node-specific rather than system-wide.
> Previously, page_owner could not filter by NUMA node, forcing users to
> collect and analyze data for all nodes.
>
> Solution
> ========
>
> This patch series introduces a per-file-descriptor filter infrastructure
> with two initial filters:
>
> 1. **Print Mode Filter**: Outputs only stack handles instead of
>    full stack traces. The handle-to-stack mapping can be retrieved
>    from the existing show_stacks_handles interface. This dramatically
>    reduces output size while preserving all allocation metadata.
>
> 2. **NUMA Node Filter**: Allows filtering pages by specific NUMA node(s)
>    using flexible nodelist format, enabling targeted analysis of memory
>    issues in NUMA-aware deployments.
>
> The per-fd design allows multiple concurrent page_owner reads with
> different filters, solving coordination issues in multi-user production
> environments.
>
> Implementation
> ==============
>
> The series is structured as follows:
>
> - Patch 1: Implement print_mode filter infrastructure
>   * Add file->private_data to store per-fd filter state
>   * Add .open, .release, and .write file operations
>   * Support "stack", "handle", and "stack_handle" modes via "mode=" write commands
> - Patch 2: Implement NUMA node filter infrastructure
>   * Add nid_filter field to per-fd state
>   * Support flexible nodelist format via "nid=" write commands (single, multiple, ranges)
>   * Validate nodes and reject non-existent nodes using nodes_subset()
> - Patch 3: Add page_owner_filter userspace tool
>   * Manages per-fd filters via write() interface
>   * Provides user-friendly command-line interface
>   * Includes comprehensive input validation
> - Patch 4: Document filter features and usage
>
> Usage Example
> =============
>
> Using the page_owner_filter tool with per-fd filters:
>
>     # ./page_owner_filter -m stack_handle -n "0,2-3" -o page_owner.txt
>
> The tool opens /sys/kernel/debug/page_owner, sets filters via write(),
> then reads the filtered output to the specified file (or stdout).
>
> Sample print_mode output (showing handles only):
>
>     Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper),
>     ts 0 ns PFN 0x40000 type Unmovable Block 512 type Unmovable
>     Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     handle: 1048577
>
>     Page allocated via order 0, mask 0x252000(__GFP_NOWARN|
>     __GFP_NORETRY|__GFP_COMP|__GFP_THISNODE), pid 0, tgid 0 (swapper),
>     ts 0 ns PFN 0x40002 type Unmovable Block 512 type Unmovable
>     Flags 0x23fffe0000000200(workingset|node=0|zone=0|lastcpupid=0x1ffff)
>     handle: 1048577
>
> Testing
> =======
>
> Tested on a 4-node NUMA system. Verified that:
>
> 1. **Kernel without page_owner enabled**:
>    Tool properly detects and reports missing page_owner support:
>    ```
>    $ ./page_owner_filter -m stack
>    Error: /sys/kernel/debug/page_owner does not exist
>    Make sure page_owner is enabled in kernel
>    ```
>
> 2. **Kernel without per-fd filter support**:
>    Tool properly detects and reports missing filter support:
>    ```
>    $ ./page_owner_filter -m stack
>    Error: Kernel rejected the filter command.
>    Possible causes:
>      - Kernel does not support per-fd filtering
>      - NUMA node has no memory
>      - Unknown reason
>    ```
>
> 3. **Comprehensive userspace tool testing**:
>    Tested 26 test cases covering:
>    - Help messages (-h, --help)
>    - Invalid inputs (mode, nid format, range validation)
>    - Valid modes (stack, handle, stack_handle)
>    - Valid nid filters (single node, multiple nodes, ranges)
>    - Combined mode and nid filters
>    - Node validity verification (grep-based verification)
>    - Error handling for out-of-range nodes
>
>    Test script (test_page_owner_filter.sh):
>    ```bash
>    #!/bin/bash
>    # Test script for page_owner_filter tool
>
>    cd "$(dirname "$0")"
>
>    echo "========================================="
>    echo "page_owner_filter Test Suite"
>    echo "========================================="
>    echo
>
>    echo "Test 1: -h"
>    echo "./page_owner_filter -h"
>    ./page_owner_filter -h
>    echo
>
>    echo "Test 2: --help"
>    echo "./page_owner_filter --help"
>    ./page_owner_filter --help
>    echo
>
>    echo "Test 3: Invalid mode"
>    echo ./page_owner_filter -m invalid
>    ./page_owner_filter -m invalid
>    echo
>
>    echo "Test 4: Invalid nid with letters"
>    echo ./page_owner_filter -n 0,a,2
>    ./page_owner_filter -n 0,a,2
>    echo
>
>    echo "Test 5: Invalid nid with double comma"
>    echo ./page_owner_filter -n 0,,2
>    ./page_owner_filter -n 0,,2
>    echo
>
>    echo "Test 6: Invalid nid starting with comma"
>    echo ./page_owner_filter -n ,0,1
>    ./page_owner_filter -n ,0,1
>    echo
>
>    echo "Test 7: Invalid nid ending with comma"
>    echo ./page_owner_filter -n "0,1,"
>    ./page_owner_filter -n "0,1,"
>    echo
>
>    echo "Test 8: No filters specified"
>    echo ./page_owner_filter
>    ./page_owner_filter
>    echo
>
>    echo "Test 9: Invalid nid - node 4 (out of range)"
>    echo ./page_owner_filter -n 4
>    ./page_owner_filter -n 4
>    echo
>
>    echo "Test 10: Invalid nid - large number"
>    echo './page_owner_filter -n 65535'
>    ./page_owner_filter -n 65535
>    echo
>
>    echo "Test 11: Invalid mode AND invalid nid"
>    echo ./page_owner_filter -m wrong -n abc
>    ./page_owner_filter -m wrong -n abc
>    echo
>
>    echo "Test 12: Two invalid modes (try both)"
>    echo ./page_owner_filter -m wrong1 -m wrong2
>    ./page_owner_filter -m wrong1 -m wrong2
>    echo
>
>    echo "Test 13: Valid mode - stack"
>    echo './page_owner_filter -m stack | head -20'
>    ./page_owner_filter -m stack | head -20
>    echo
>
>    echo "Test 14: Valid mode - handle"
>    echo './page_owner_filter -m handle | head -20'
>    ./page_owner_filter -m handle | head -20
>    echo
>
>    echo "Test 15: Valid mode - stack_handle"
>    echo './page_owner_filter -m stack_handle | head -20'
>    ./page_owner_filter -m stack_handle | head -20
>    echo
>
>    echo "Test 16: All modes"
>    echo './page_owner_filter -m stack -m handle -m stack_handle | head -20'
>    ./page_owner_filter -m stack -m handle -m stack_handle | head -20
>    echo
>
>    echo "Test 17: Valid nid - single"
>    echo './page_owner_filter -n 0 | head -20'
>    ./page_owner_filter -n 0 | head -20
>    echo 'Verify: should have node=0, should NOT have node=1,2,3'
>    echo './page_owner_filter -n 0 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c'
>    ./page_owner_filter -n 0 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>    echo
>
>    echo "Test 18: Valid nid - multiple"
>    echo 'Verify: should have node=0,1,3, should NOT have node=2'
>    echo './page_owner_filter -n 0,1,3 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c'
>    ./page_owner_filter -n 0,1,3 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>    echo
>
>    echo "Test 19: Valid nid - range"
>    echo 'Verify: should have node=2,3, should NOT have node=0,1'
>    echo './page_owner_filter -n 2-3 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c'
>    ./page_owner_filter -n 2-3 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>    echo
>
>    echo "Test 20: Valid nid - range"
>    echo 'Verify: should have node=0,1,2,3'
>    echo './page_owner_filter -n 2-3,0-1 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c'
>    ./page_owner_filter -n 2-3,0-1 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>    echo
>
>    echo "Test 21: Valid nid - range"
>    echo 'Verify: should have node=2, should NOT have node=0,1,3'
>    echo './page_owner_filter -n 2-2 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c'
>    ./page_owner_filter -n 2-2 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>    echo
>
>    echo "Test 22: Invalid nid - range start must be <= end"
>    echo './page_owner_filter -n 3-0'
>    ./page_owner_filter -n 3-0
>    echo
>
>    echo './page_owner_filter -n 1-0,0-1'
>    ./page_owner_filter -n 1-0,0-1
>    echo
>
>    echo './page_owner_filter -n 2-3,1-0,0-1'
>    ./page_owner_filter -n 2-3,1-0,0-1
>    echo
>
>    echo './page_owner_filter -n 3,1-0,1'
>    ./page_owner_filter -n 3,1-0,1
>    echo
>
>    echo "Test 23: Invalid nid - NUMA node 4 and above have no memory"
>    echo './page_owner_filter -n 0-4'
>    ./page_owner_filter -n 0-4
>    echo
>
>    echo './page_owner_filter -n 1,0-4'
>    ./page_owner_filter -n 1,0-4
>    echo
>
>    echo './page_owner_filter -n 7-8'
>    ./page_owner_filter -n 7-8
>    echo
>
>    echo './page_owner_filter -n 8-1'
>    ./page_owner_filter -n 8-1
>    echo
>
>    echo "Test 24: Valid nid - range and comma mixed"
>    echo 'Verify: should have node=0,2,3, should NOT have node=1'
>    echo './page_owner_filter -n 2-3,0| grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c'
>    ./page_owner_filter -n 2-3,0 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>    echo
>
>    echo "Test 25: Valid nid - range and comma mixed"
>    echo 'Verify: should have node=1,2,3, should NOT have node=0'
>    echo './page_owner_filter -n 1,2-3| grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c'
>    ./page_owner_filter -n 1,2-3 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>    echo
>
>    echo "Test 26: Valid handle mode + nid filter"
>    echo './page_owner_filter -m handle -n "0,1" | head -20'
>    ./page_owner_filter -m handle -n "0,1" | head -20
>    echo 'Verify: should show stacks, and only node=0,1 (not 2,3)'
>    echo './page_owner_filter -m handle -n "0,1" | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c'
>    ./page_owner_filter -m handle -n "0,1" | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>    echo
>
>
>    echo "========================================="
>    echo "Tests completed. Please check output above."
>    echo "========================================="
>    ```
>        
>    Test output:
>    ```
>    =========================================
>    page_owner_filter Test Suite
>    =========================================
>
>    Test 1: -h
>    ./page_owner_filter -h
>    Usage: ./page_owner_filter [OPTIONS]
>
>    Options:
>      -m, --mode MODE      : print_mode (stack, handle, or stack_handle)
>      -n, --nid NID_LIST   : NUMA node IDs (comma-separated or ranges)
>      -o, --output FILE    : output file (default: stdout)
>      -h, --help           : show this help message
>
>    Examples:
>      ./page_owner_filter -m stack
>      ./page_owner_filter -m handle
>      ./page_owner_filter -m stack_handle
>      ./page_owner_filter -m stack -o output.txt
>      ./page_owner_filter -n 0,1,2
>      ./page_owner_filter -m stack -n 0
>
>    Test 2: --help
>    ./page_owner_filter --help
>    Usage: ./page_owner_filter [OPTIONS]
>
>    Options:
>      -m, --mode MODE      : print_mode (stack, handle, or stack_handle)
>      -n, --nid NID_LIST   : NUMA node IDs (comma-separated or ranges)
>      -o, --output FILE    : output file (default: stdout)
>      -h, --help           : show this help message
>
>    Examples:
>      ./page_owner_filter -m stack
>      ./page_owner_filter -m handle
>      ./page_owner_filter -m stack_handle
>      ./page_owner_filter -m stack -o output.txt
>      ./page_owner_filter -n 0,1,2
>      ./page_owner_filter -m stack -n 0
>
>    Test 3: Invalid mode
>    ./page_owner_filter -m invalid
>    Error: Invalid mode 'invalid'
>    Valid modes: stack, handle, stack_handle
>
>    Test 4: Invalid nid with letters
>    ./page_owner_filter -n 0,a,2
>    Error: Invalid character 'a' in nid_list
>
>    Test 5: Invalid nid with double comma
>    ./page_owner_filter -n 0,,2
>    Error: Invalid nid_list format
>
>    Test 6: Invalid nid starting with comma
>    ./page_owner_filter -n ,0,1
>    Error: Invalid nid_list format
>
>    Test 7: Invalid nid ending with comma
>    ./page_owner_filter -n 0,1,
>    Error: Invalid nid_list format
>
>    Test 8: No filters specified
>    ./page_owner_filter
>    Error: At least one filter (-m or -n) must be specified
>
>    Usage: ./page_owner_filter [OPTIONS]
>
>    Options:
>      -m, --mode MODE      : print_mode (stack, handle, or stack_handle)
>      -n, --nid NID_LIST   : NUMA node IDs (comma-separated or ranges)
>      -o, --output FILE    : output file (default: stdout)
>      -h, --help           : show this help message
>
>    Examples:
>      ./page_owner_filter -m stack
>      ./page_owner_filter -m handle
>      ./page_owner_filter -m stack_handle
>      ./page_owner_filter -m stack -o output.txt
>      ./page_owner_filter -n 0,1,2
>      ./page_owner_filter -m stack -n 0
>
>    Test 9: Invalid nid - node 4 (out of range)
>    ./page_owner_filter -n 4
>    Error: Kernel rejected the filter command.
>    Possible causes:
>      - Kernel does not support per-fd filtering
>      - NUMA node has no memory
>      - Unknown reason
>
>    Test 10: Invalid nid - large number
>    ./page_owner_filter -n 65535
>    write filter command: Numerical result out of range
>
>    Test 11: Invalid mode AND invalid nid
>    ./page_owner_filter -m wrong -n abc
>    Error: Invalid mode 'wrong'
>    Valid modes: stack, handle, stack_handle
>
>    Test 12: Two invalid modes (try both)
>    ./page_owner_filter -m wrong1 -m wrong2
>    Error: Invalid mode 'wrong1'
>    Valid modes: stack, handle, stack_handle
>
>    Test 13: Valid mode - stack
>    ./page_owner_filter -m stack | head -20
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40000 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>     page_ext_init+0x204/0x298
>     mm_core_init+0xdc/0x14c
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40001 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>     page_ext_init+0x204/0x298
>     mm_core_init+0xdc/0x14c
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40002 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>     page_ext_init+0x204/0x298
>     mm_core_init+0xdc/0x14c
>
>    Test 14: Valid mode - handle
>    ./page_owner_filter -m handle | head -20
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40000 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40001 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40002 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40003 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40004 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000040(head|node=0|zone=0|lastcpupid=0x1ffff)
>    handle: 1048577
>
>
>    Test 15: Valid mode - stack_handle
>    ./page_owner_filter -m stack_handle | head -20
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40000 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>     page_ext_init+0x204/0x298
>     mm_core_init+0xdc/0x14c
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40001 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>     page_ext_init+0x204/0x298
>     mm_core_init+0xdc/0x14c
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40002 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>
>    Test 16: All modes
>    ./page_owner_filter -m stack -m handle -m stack_handle | head -20
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40000 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>     page_ext_init+0x204/0x298
>     mm_core_init+0xdc/0x14c
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40001 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>     page_ext_init+0x204/0x298
>     mm_core_init+0xdc/0x14c
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40002 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>
>    Test 17: Valid nid - single
>    ./page_owner_filter -n 0 | head -20
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40000 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>     page_ext_init+0x204/0x298
>     mm_core_init+0xdc/0x14c
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40001 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>     page_ext_init+0x204/0x298
>     mm_core_init+0xdc/0x14c
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40002 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>     register_early_stack+0x2c/0x70
>     init_page_owner+0x2c/0x460
>     page_ext_init+0x204/0x298
>     mm_core_init+0xdc/0x14c
>    Verify: should have node=0, should NOT have node=1,2,3
>    ./page_owner_filter -n 0 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>      91327 node=0
>
>    Test 18: Valid nid - multiple
>    Verify: should have node=0,1,3, should NOT have node=2
>    ./page_owner_filter -n 0,1,3 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>      91299 node=0
>      43515 node=1
>     110404 node=3
>
>    Test 19: Valid nid - range
>    Verify: should have node=2,3, should NOT have node=0,1
>    ./page_owner_filter -n 2-3 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>      19391 node=2
>     110287 node=3
>
>    Test 20: Valid nid - range
>    Verify: should have node=0,1,2,3
>    ./page_owner_filter -n 2-3,0-1 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>      91562 node=0
>      43527 node=1
>      19495 node=2
>     110286 node=3
>
>    Test 21: Valid nid - range
>    Verify: should have node=2, should NOT have node=0,1,3
>    ./page_owner_filter -n 2-2 | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>      19505 node=2
>
>    Test 22: Invalid nid - range start must be <= end
>    ./page_owner_filter -n 3-0
>    Error: Invalid range 3-0 (start must be <= end)
>
>    ./page_owner_filter -n 1-0,0-1
>    Error: Invalid range 1-0 (start must be <= end)
>
>    ./page_owner_filter -n 2-3,1-0,0-1
>    Error: Invalid range 1-0 (start must be <= end)
>
>    ./page_owner_filter -n 3,1-0,1
>    Error: Invalid range 1-0 (start must be <= end)
>
>    Test 23: Invalid nid - NUMA node 4 and above have no memory
>    ./page_owner_filter -n 0-4
>    Error: Kernel rejected the filter command.
>    Possible causes:
>      - Kernel does not support per-fd filtering
>      - NUMA node has no memory
>      - Unknown reason
>
>    ./page_owner_filter -n 1,0-4
>    Error: Kernel rejected the filter command.
>    Possible causes:
>      - Kernel does not support per-fd filtering
>      - NUMA node has no memory
>      - Unknown reason
>
>    ./page_owner_filter -n 7-8
>    Error: Kernel rejected the filter command.
>    Possible causes:
>      - Kernel does not support per-fd filtering
>      - NUMA node has no memory
>      - Unknown reason
>
>    ./page_owner_filter -n 8-1
>    Error: Invalid range 8-1 (start must be <= end)
>
>    Test 24: Valid nid - range and comma mixed
>    Verify: should have node=0,2,3, should NOT have node=1
>    ./page_owner_filter -n 2-3,0| grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>      91741 node=0
>      19389 node=2
>     110286 node=3
>
>    Test 25: Valid nid - range and comma mixed
>    Verify: should have node=1,2,3, should NOT have node=0
>    ./page_owner_filter -n 1,2-3| grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>      43462 node=1
>      19402 node=2
>     110288 node=3
>
>    Test 26: Valid handle mode + nid filter
>    ./page_owner_filter -m handle -n "0,1" | head -20
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40000 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40001 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40002 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40003 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000000(node=0|zone=0|lastcpupid=0x1ffff)
>    handle: 1048577
>
>    Page allocated via order 0, mask 0x0(), pid 0, tgid 0 (swapper), ts 0 ns
>    PFN 0x40004 type Unmovable Block 512 type Unmovable Flags 0x3fffe0000000040(head|node=0|zone=0|lastcpupid=0x1ffff)
>    handle: 1048577
>
>    Verify: should show stacks, and only node=0,1 (not 2,3)
>    ./page_owner_filter -m handle -n "0,1" | grep "PFN" | grep -o "node=[0-9]" | sort | uniq -c
>      91677 node=0
>      43458 node=1
>
>    =========================================
>    Tests completed. Please check output above.
>    =========================================
>    ```

I ran the test script and also ran page_owner_filter program myself. I
did not observe any issue. Feel free to add:
Tested-by: Zi Yan <ziy@nvidia.com>


-- 
Best Regards,
Yan, Zi


      parent reply	other threads:[~2026-06-25 18:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  4:30 [PATCH v11 0/4] mm/page_owner: add per-fd filter infrastructure for print_mode and NUMA filtering Zhen Ni
2026-06-25  4:30 ` [PATCH v11 1/4] mm/page_owner: add print_mode filter Zhen Ni
2026-06-25 18:26   ` Zi Yan
2026-06-25 19:20     ` Andrew Morton
2026-06-25 19:24       ` Zi Yan
2026-06-25  4:30 ` [PATCH v11 2/4] mm/page_owner: add NUMA node filter Zhen Ni
2026-06-25 18:37   ` Zi Yan
2026-06-26  8:20     ` zhen.ni
2026-06-25 19:27   ` Zi Yan
2026-06-25 20:04     ` Andrew Morton
2026-06-25  4:31 ` [PATCH v11 3/4] tools/mm: add page_owner_filter userspace tool Zhen Ni
2026-06-25  4:50   ` Andrew Morton
2026-06-25  4:31 ` [PATCH v11 4/4] mm/page_owner: document page_owner filter Zhen Ni
2026-06-25  4:55 ` [PATCH v11 0/4] mm/page_owner: add per-fd filter infrastructure for print_mode and NUMA filtering Andrew Morton
2026-06-25 12:57   ` zhen.ni
2026-06-25 18:22 ` Zi Yan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DJIC8FHUE508.1H55DFNUVM9EE@nvidia.com \
    --to=ziy@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=zhen.ni@easystack.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.