From: "Zi Yan" <ziy@nvidia.com>
To: "Ye Liu" <ye.liu@linux.dev>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Vlastimil Babka" <vbabka@kernel.org>
Cc: "Suren Baghdasaryan" <surenb@google.com>,
"Michal Hocko" <mhocko@suse.com>,
"Brendan Jackman" <jackmanb@google.com>,
"Johannes Weiner" <hannes@cmpxchg.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/6] mm/page_owner: move free_ts_nsec output to free section in __dump_page_owner()
Date: Fri, 26 Jun 2026 14:55:16 -0400 [thread overview]
Message-ID: <DJJ7K125ZT44.1D6ZSH2JPWIES@nvidia.com> (raw)
In-Reply-To: <20260626024550.25677-6-ye.liu@linux.dev>
On Thu Jun 25, 2026 at 10:45 PM EDT, Ye Liu wrote:
> The free_ts_nsec field is a free-event timestamp, but it was printed
> in the allocation summary line alongside ts_nsec (allocation time).
> Move it to the free section where it logically belongs, together with
> free_pid and free_tgid. This also makes __dump_page_owner() consistent
> with print_page_owner(), which only prints ts_nsec in the allocation
> summary.
>
> The output now groups all free-related information (pid, tgid,
> timestamp, stack trace) in one place.
>
> No functional change except output formatting.
>
> Signed-off-by: Ye Liu <ye.liu@linux.dev>
> ---
> mm/page_owner.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index 958151ccb587..eaccff355cb4 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -660,10 +660,10 @@ void __dump_page_owner(const struct page *page)
> else
> pr_alert("page_owner tracks the page as freed\n");
>
> - pr_alert("page last allocated via order %u, migratetype %s, gfp_mask %#x(%pGg), pid %d, tgid %d (%s), ts %llu, free_ts %llu\n",
> + pr_alert("page last allocated via order %u, migratetype %s, gfp_mask %#x(%pGg), pid %d, tgid %d (%s), ts %llu\n",
Is it going to break existing programs parsing this information? This is
under debugfs, so probably does not matter?
> page_owner->order, migratetype_names[mt], gfp_mask, &gfp_mask,
> page_owner->pid, page_owner->tgid, page_owner->comm,
> - page_owner->ts_nsec, page_owner->free_ts_nsec);
> + page_owner->ts_nsec);
>
> handle = READ_ONCE(page_owner->handle);
> if (!handle)
> @@ -675,8 +675,9 @@ void __dump_page_owner(const struct page *page)
> if (!handle) {
> pr_alert("page_owner free stack trace missing\n");
> } else {
> - pr_alert("page last free pid %d tgid %d stack trace:\n",
> - page_owner->free_pid, page_owner->free_tgid);
> + pr_alert("page last free pid %d tgid %d ts %llu stack trace:\n",
> + page_owner->free_pid, page_owner->free_tgid,
> + page_owner->free_ts_nsec);
> stack_depot_print(handle);
> }
>
--
Best Regards,
Yan, Zi
next prev parent reply other threads:[~2026-06-26 18:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 2:45 [PATCH v2 0/6] mm/page_owner: misc cleanups Ye Liu
2026-06-26 2:45 ` [PATCH v2 1/6] mm/page_owner: extract skip_buddy_pages() helper to unify buddy page skipping Ye Liu
2026-06-26 18:35 ` Zi Yan
2026-06-26 2:45 ` [PATCH v2 2/6] mm/page_owner: use MIGRATE_REASON_NONE instead of -1 for last_migrate_reason Ye Liu
2026-06-26 18:45 ` Zi Yan
2026-06-26 2:45 ` [PATCH v2 3/6] mm/page_owner: hoist CONFIG_MEMCG to function level for print_page_owner_memcg() Ye Liu
2026-06-26 18:52 ` Zi Yan
2026-06-26 2:45 ` [PATCH v2 4/6] mm/page_owner: add missing newline to count_threshold format string Ye Liu
2026-06-26 18:53 ` Zi Yan
2026-06-26 2:45 ` [PATCH v2 5/6] mm/page_owner: move free_ts_nsec output to free section in __dump_page_owner() Ye Liu
2026-06-26 18:55 ` Zi Yan [this message]
2026-06-26 2:45 ` [PATCH v2 6/6] mm/page_owner: drop redundant page_owner prefix from static symbols Ye Liu
2026-06-26 18:56 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJJ7K125ZT44.1D6ZSH2JPWIES@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.