From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Johan Hovold" <johan@kernel.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, driver-core@lists.linux.dev
Subject: Re: [PATCH 3/4] usb: serial: spcp8x5: don't keep usb_device_id
Date: Tue, 30 Jun 2026 23:52:00 +0200 [thread overview]
Message-ID: <DJMPTIYEGQ6S.BYJ6RF0WWBX0@kernel.org> (raw)
In-Reply-To: <20260630-usb_dyn_id_uaf-v1-3-160a02be5ac2@garyguo.net>
On Tue Jun 30, 2026 at 1:38 PM CEST, Gary Guo wrote:
> USB probe functions should not keep usb_device_id for longer than probe due
> to presence of dynamic ID removal. USB serial does not support ID removal,
> however in this case only driver_data is ever needed, there is no reason
> keeping the usb_device_id in the first place, so convert it as well.
>
> Signed-off-by: Gary Guo <gary@garyguo.net>
> ---
Reviewed-by: Danilo Krummrich <dakr@kernel.org>
next prev parent reply other threads:[~2026-06-30 21:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 11:38 [PATCH 0/4] usb: fix UAF related to dynamic ID Gary Guo
2026-06-30 11:38 ` [PATCH 1/4] wifi: ath9k_htc: don't keep usb_device_id Gary Guo
2026-06-30 21:51 ` Danilo Krummrich
2026-06-30 11:38 ` [PATCH 2/4] usb: usbtmc: " Gary Guo
2026-06-30 21:51 ` Danilo Krummrich
2026-06-30 11:38 ` [PATCH 3/4] usb: serial: spcp8x5: " Gary Guo
2026-06-30 21:52 ` Danilo Krummrich [this message]
2026-06-30 11:38 ` [PATCH 4/4] usb: fix UAF when probe runs concurrent to dyn ID removal Gary Guo
2026-06-30 21:55 ` Danilo Krummrich
2026-06-30 13:26 ` [PATCH 0/4] usb: fix UAF related to dynamic ID Manuel Ebner
2026-06-30 13:39 ` Danilo Krummrich
2026-07-01 15:02 ` Manuel Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJMPTIYEGQ6S.BYJ6RF0WWBX0@kernel.org \
--to=dakr@kernel.org \
--cc=driver-core@lists.linux.dev \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.