From: "Zi Yan" <ziy@nvidia.com>
To: "Pedro Falcato" <pfalcato@suse.de>,
"Gregg Leventhal" <gleventhal@janestreet.com>
Cc: "Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>, "Matthew Wilcox" <willy@infradead.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Song Liu" <song@kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
"Eric Hagberg" <ehagberg@janestreet.com>,
"David Hildenbrand" <david@kernel.org>,
"Lorenzo Stoakes" <ljs@kernel.org>
Subject: Re: Subject: [BUG/RFC] write-open file THP cache purge can discard dirty page cache
Date: Tue, 30 Jun 2026 18:48:39 -0400 [thread overview]
Message-ID: <DJMR0W6NUSAI.3UF6I74VFDFSH@nvidia.com> (raw)
In-Reply-To: <akQekZUyoKadiGCH@pedro-suse.lan>
On Tue Jun 30, 2026 at 3:55 PM EDT, Pedro Falcato wrote:
> On Tue, Jun 30, 2026 at 07:49:12PM +0100, Pedro Falcato wrote:
> snip
>>
>> Other idea: perhaps doing filemap_write_and_wait() after the nr_thps
>> increment in collapse_file() will Just Work and result in a _much_
>> simpler fix. And it avoids any weird forward-progress issues as no one can
>> write to folios at that point.
>>
>
> Gregg, if you could test this patch, it would be much appreciated. This patch
> (hopefully) makes it so no dirty folio will ever coexist with a ro-THP, thus
> hopefully sidestepping the entire issue in a simple way. Only compile-tested
> and not reviewed.
I tested the patch on v6.12 kernel with the reproducer from Gregg and
confirmed that the issue is fixed.
Feel free to add
Tested-by: Zi Yan <ziy@nvidia.com>
--
Best Regards,
Yan, Zi
next prev parent reply other threads:[~2026-06-30 22:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 17:01 Subject: [BUG/RFC] write-open file THP cache purge can discard dirty page cache Gregg Leventhal
2026-06-30 17:18 ` Gregg Leventhal
2026-06-30 18:31 ` Pedro Falcato
2026-06-30 18:49 ` Pedro Falcato
2026-06-30 19:55 ` Pedro Falcato
2026-06-30 22:34 ` Matthew Wilcox
2026-06-30 22:48 ` Zi Yan [this message]
2026-07-01 12:05 ` Pedro Falcato
2026-07-01 11:54 ` Matthew Wilcox
2026-07-01 12:04 ` Pedro Falcato
2026-07-01 12:48 ` Pedro Falcato
2026-07-01 13:07 ` Gregg Leventhal
2026-07-01 14:23 ` Pedro Falcato
2026-06-30 18:36 ` Matthew Wilcox
2026-06-30 19:05 ` Zi Yan
2026-06-30 19:07 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJMR0W6NUSAI.3UF6I74VFDFSH@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=david@kernel.org \
--cc=ehagberg@janestreet.com \
--cc=gleventhal@janestreet.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=pfalcato@suse.de \
--cc=song@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.