From: "Emil Tsalapatis" <emil@etsalapatis.com>
To: <bot+bpf-ci@kernel.org>, <emil@etsalapatis.com>, <bpf@vger.kernel.org>
Cc: <ast@kernel.org>, <andrii@kernel.org>, <memxor@gmail.com>,
<daniel@iogearbox.net>, <eddyz87@gmail.com>,
<mattbobrowski@google.com>, <song@kernel.org>,
<martin.lau@kernel.org>, <yonghong.song@linux.dev>,
<clm@meta.com>, <ihor.solodrai@linux.dev>
Subject: Re: [PATCH bpf-next v2 5/5] selftests/bpf: libarena: Add parallel bitmap selftest
Date: Wed, 01 Jul 2026 16:40:19 -0400 [thread overview]
Message-ID: <DJNIX6BLBZU3.3TAKCXAF7L0XY@etsalapatis.com> (raw)
In-Reply-To: <c4b56704d686ce2c0a944b0726914b06a593620812d129573855a7d89c9ce646@mail.kernel.org>
On Wed Jul 1, 2026 at 3:38 PM EDT, bot+bpf-ci wrote:
>> diff --git a/tools/testing/selftests/bpf/libarena/selftests/test_parallel_bitmap.bpf.c b/tools/testing/selftests/bpf/libarena/selftests/test_parallel_bitmap.bpf.c
>> new file mode 100644
>> index 000000000000..5381deeb8d37
>> --- /dev/null
>> +++ b/tools/testing/selftests/bpf/libarena/selftests/test_parallel_bitmap.bpf.c
>> @@ -0,0 +1,191 @@
>> +// SPDX-License-Identifier: LGPL-2.1 OR BSD-2-Clause
>> +
>> +#include <bpf_atomic.h>
>> +
>> +#include <libarena/common.h>
>> +
>> +#include <libarena/asan.h>
>> +#include <libarena/bitmap.h>
>> +
>> +#define TEST_BITMAP_THREADS 2
>> +#define TEST_BITMAP_BITS (2 * BITS_PER_LONG_LONG)
>> +#define TEST_BITMAP_WORDS BITS_TO_LONG_LONGS(TEST_BITMAP_BITS)
>
> This isn't a bug, but TEST_BITMAP_WORDS does not appear to be used
> anywhere in this file - could it be dropped, or is a use intended?
>
> The sibling serial test (test_bitmap.bpf.c) defines the analogous
> TEST_WORDS macro and does use it as a loop bound.
>
Ack to this and the bot nits. Sashiko failed to apply the patch,
but the CI did so just fine.
>> +#define TEST_BITMAP_SYNC_SPINS BPF_MAX_LOOPS
>
> [ ... ]
>
>
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/28541348016
prev parent reply other threads:[~2026-07-01 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 18:52 [PATCH bpf-next v2 0/5] selftests/bpf: libarena cleanup and bitmap struct Emil Tsalapatis
2026-07-01 18:52 ` [PATCH bpf-next v2 1/5] selftests/bpf: libarena: Fix can-loop zero variable definition Emil Tsalapatis
2026-07-01 18:52 ` [PATCH bpf-next v2 2/5] selftests/bpf: libarena: Clean up allocation state before buddy tests Emil Tsalapatis
2026-07-01 18:52 ` [PATCH bpf-next v2 3/5] selftests/bpf: Add arena-based bitmap data structure Emil Tsalapatis
2026-07-01 19:38 ` bot+bpf-ci
2026-07-01 18:52 ` [PATCH bpf-next v2 4/5] selftests/bpf: libarena: Add bitmap selftets Emil Tsalapatis
2026-07-01 19:38 ` bot+bpf-ci
2026-07-01 18:52 ` [PATCH bpf-next v2 5/5] selftests/bpf: libarena: Add parallel bitmap selftest Emil Tsalapatis
2026-07-01 19:38 ` bot+bpf-ci
2026-07-01 20:40 ` Emil Tsalapatis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJNIX6BLBZU3.3TAKCXAF7L0XY@etsalapatis.com \
--to=emil@etsalapatis.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=martin.lau@kernel.org \
--cc=mattbobrowski@google.com \
--cc=memxor@gmail.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.