From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9C6EC4450A for ; Thu, 16 Jul 2026 22:18:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 261B810E265; Thu, 16 Jul 2026 22:18:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="outd0xgz"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0152710E265 for ; Thu, 16 Jul 2026 22:18:25 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id B7F4D60A5E; Thu, 16 Jul 2026 22:18:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E11AA1F000E9; Thu, 16 Jul 2026 22:18:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784240304; bh=YToMbk+5SWefsd4xbt2YpFEizUl7t5lozTbx1lRtW1o=; h=Date:Cc:To:From:Subject:References:In-Reply-To; b=outd0xgzqvc18hsO7GUsFT6XPLtyiwkUA4jMemgDgx0+/Ioc/Si/a2rMfZdoqk9Xc jSX1p0kdHO3JqdSwyledgofmnEi5hNNNVHNb+esMcZNDzcX5duSP3A1JsgWuBVg+MC gTGgApOz9lUkr9KzozvhxSv9B3xoIVcdjuasddRfiiuZI9X9Zl8dUmcZ41e0KFIZX+ Ay1rUdreAOx7oioX71F1MZ22mNa4eBZQFv35uxFH5xKaiRsOtGIyfVfdkxrMteluoc Khx2V/yMjn7TlKsyYwOe3QL9j3Cn4QUS7GzsDlYA4Z5JvIoxQ/zfBP95HIA00lhBT4 turQbJlrSreUw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 17 Jul 2026 00:18:19 +0200 Message-Id: Cc: "Gary Guo" , "Alice Ryhl" , "Daniel Almeida" , "Miguel Ojeda" , "Boqun Feng" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Trevor Gross" , "Tamir Duberstein" , "Alexandre Courbot" , =?utf-8?q?Onur_=C3=96zkan?= , "David Airlie" , "Simona Vetter" , , , , To: "Gary Guo" From: "Danilo Krummrich" Subject: Re: [PATCH 2/2] rust: drm: fix non-const `read8` in unit test References: <20260716142545.3622278-1-gary@kernel.org> <20260716142545.3622278-2-gary@kernel.org> In-Reply-To: <20260716142545.3622278-2-gary@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu Jul 16, 2026 at 4:25 PM CEST, Gary Guo wrote: > From: Gary Guo > > With CONFIG_CC_OPTIMIZE_FOR_SIZE, the address validity check in non-const > `read8` invocaction is not optimized away, leading to build failure. > > Signed-off-by: Gary Guo Fixes: d055768429b3 ("rust: drm: gem: shmem: Add vmap functions") > --- > rust/kernel/drm/gem/shmem.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rust/kernel/drm/gem/shmem.rs b/rust/kernel/drm/gem/shmem.rs > index 580e0808d6c0..a687d46d170d 100644 > --- a/rust/kernel/drm/gem/shmem.rs > +++ b/rust/kernel/drm/gem/shmem.rs > @@ -688,7 +688,7 @@ fn vmap_io() -> Result { > // Ensure the ordering in memory is correct > let expected =3D 0xFEDCBA98_u32.to_ne_bytes().into_iter(); > for (offset, expected) in (0x20..=3D0x23).zip(expected) { > - assert_eq!(vmap.read8(offset), expected); > + assert_eq!(vmap.try_read8(offset).unwrap(), expected); > } > =20 > Ok(()) > --=20 > 2.54.0